You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2016/05/14 13:09:12 UTC

[jira] [Comment Edited] (CODEC-211) Create enum MessageDigestAlgorithm and deprecate class MessageDigestAlgorithms

    [ https://issues.apache.org/jira/browse/CODEC-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283540#comment-15283540 ] 

Sebb edited comment on CODEC-211 at 5/14/16 1:08 PM:
-----------------------------------------------------

There's more to be done to follow through.
-For example, DigestUtils.getDigest(String) needs to be deprecated in favour of a method that uses the enum.-
For example there should be a DigestUtils.getDigest(MessageDigestAlgorithm) method which allows the enum to be used by external code.
Otherwise there's little point in having the enum.
Likewise internal usage of the MessageDigestAlgorithms constants needs to be replaced with MessageDigestAlgorithm enums (done)
At present there are quite a few deprecation warnings (done)


was (Author: sebb@apache.org):
There's more to be done to follow through.
For example, DigestUtils.getDigest(String) needs to be deprecated in favour of a method that uses the enum.
Otherwise there's little point in having the enum.
Likewise internal usage of the MessageDigestAlgorithms constants needs to be replaced with MessageDigestAlgorithm enums
At present there are quite a few deprecation warnings

> Create enum MessageDigestAlgorithm and deprecate class MessageDigestAlgorithms
> ------------------------------------------------------------------------------
>
>                 Key: CODEC-211
>                 URL: https://issues.apache.org/jira/browse/CODEC-211
>             Project: Commons Codec
>          Issue Type: New Feature
>    Affects Versions: 1.10
>         Environment: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T08:41:47-08:00)
> Maven home: E:\Java\apache-maven-3.3.9\bin\..
> Java version: 1.7.0_79, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_79\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>            Reporter: Gary Gregory
>            Assignee: Gary Gregory
>             Fix For: 1.11
>
>
> Create enum MessageDigestAlgorithm and deprecate class MessageDigestAlgorithms.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)