You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2022/03/09 12:25:52 UTC
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
pranav.lodha@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18299
Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
......................................................................
IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
The test was getting skipped as it was not in exhaustive strategy, to fix that its
been moved to TestHmsIntegrationSanity(ImpalaTestSuite) class. Now there are two tests,
test_desc_json_tbl and test_desc_json_tbl_hive to check whether tables created in
impala can be described in hive and vice versa. The tests can be checked by running
the below commands:
impala-py.test --exploration=exhaustive
tests/metadata/test_hms_integration.py::TestHmsIntegrationSanity::test_desc_json_tbl
impala-py.test --exploration=exhaustive
tests/metadata/test_hms_integration.py::TestHmsIntegrationSanity::test_desc_json_tbl_hive
Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
---
M tests/metadata/test_hms_integration.py
1 file changed, 19 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/18299/1
--
To view, visit http://gerrit.cloudera.org:8080/18299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Gerrit-Change-Number: 18299
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
pranav.lodha@cloudera.com has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18299 )
Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
......................................................................
IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
The test was getting skipped as it was not in exhaustive strategy, to fix that its
been moved to TestHmsIntegrationSanity(ImpalaTestSuite) class. Now there are two tests,
test_desc_json_tbl and test_desc_json_tbl_hive to check whether JSON tables created in
impala can be described in hive and vice versa. The tests can be checked by running
the below commands:
impala-py.test --exploration=exhaustive
tests/metadata/test_hms_integration.py::TestHmsIntegrationSanity::test_desc_json_tbl
impala-py.test --exploration=exhaustive
tests/metadata/test_hms_integration.py::TestHmsIntegrationSanity::test_desc_json_tbl_hive
Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
---
M tests/metadata/test_hms_integration.py
1 file changed, 22 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/18299/3
--
To view, visit http://gerrit.cloudera.org:8080/18299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Gerrit-Change-Number: 18299
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18299 )
Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
......................................................................
IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
The test was getting skipped as it was not in exhaustive strategy,
to fix that its been moved to TestHmsIntegrationSanity(ImpalaTestSuite)
class. Now there are two tests, test_desc_json_tbl and
test_desc_json_tbl_hive to check whether JSON tables created in
impala can be described in hive and vice versa.
Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Reviewed-on: http://gerrit.cloudera.org:8080/18299
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/metadata/test_hms_integration.py
1 file changed, 25 insertions(+), 19 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Gerrit-Change-Number: 18299
Gerrit-PatchSet: 9
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18299 )
Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Gerrit-Change-Number: 18299
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 10 Mar 2022 12:02:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18299 )
Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
......................................................................
Patch Set 8: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Gerrit-Change-Number: 18299
Gerrit-PatchSet: 8
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 11 Mar 2022 08:19:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18299 )
Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
......................................................................
Patch Set 8:
> Patch Set 6: Verified-1
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7923/
The failure is unrelated. Filed IMPALA-11177
--
To view, visit http://gerrit.cloudera.org:8080/18299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Gerrit-Change-Number: 18299
Gerrit-PatchSet: 8
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 11 Mar 2022 03:44:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18299 )
Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
......................................................................
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/18299/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18299/1//COMMIT_MSG@9
PS1, Line 9: The test was getting skipped as it was not in exhaustive strategy, to fix that its
: been moved to TestHmsIntegrationSanity(ImpalaTestSuite) class. Now there are two tests,
: test_desc_json_tbl and test_desc_json_tbl_hive to check whether tables created in
: impala can be described in hive and vice versa.
nit: please fix the width to be 72.
http://gerrit.cloudera.org:8080/#/c/18299/1//COMMIT_MSG@13
PS1, Line 13: the below commands:
: impala-py.test --exploration=exhaustive
: tests/metadata/test_hms_integration.py::TestHmsIntegrationSanity::test_desc_json_tbl
: impala-py.test --exploration=exhaustive
: tests/metadata/test_hms_integration.py::TestHmsIntegrationSanity::test_desc_json_tbl_hive
nit: don't need to add these
http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py
File tests/metadata/test_hms_integration.py:
http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py@108
PS1, Line 108: tables
nit: JSON tables
http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py@109
PS1, Line 109: unique_table_impala
nit: we can use a simpler table name, e.g. just as "json_tbl", and using it directly in the string.
self.client.execute("create table {0}.json_tbl (x int) stored as jsonfile"
.format(unique_database))
http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py@116
PS1, Line 116: tables
nit: JSON tables
http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py@117
PS1, Line 117: unique_table_hive
nit: I'd prefer a simpler table name and use it directly in the string. E.g.
self.run_stmt_in_hive("create table {0}.json_tbl (x int) stored as jsonfile"
.format(unique_database))
self.client.execute("INVALIDATE METADATA {0}.json_tbl".format(unique_database))
--
To view, visit http://gerrit.cloudera.org:8080/18299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Gerrit-Change-Number: 18299
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 10 Mar 2022 06:35:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18299 )
Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10275/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Gerrit-Change-Number: 18299
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 10 Mar 2022 08:32:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18299 )
Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10278/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Gerrit-Change-Number: 18299
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 10 Mar 2022 11:50:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
pranav.lodha@cloudera.com has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/18299 )
Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
......................................................................
IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
The test was getting skipped as it was not in exhaustive strategy,
to fix that its been moved to TestHmsIntegrationSanity(ImpalaTestSuite)
class. Now there are two tests, test_desc_json_tbl and
test_desc_json_tbl_hive to check whether JSON tables created in
impala can be described in hive and vice versa.
Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
---
M tests/metadata/test_hms_integration.py
1 file changed, 25 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/18299/6
--
To view, visit http://gerrit.cloudera.org:8080/18299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Gerrit-Change-Number: 18299
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18299 )
Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18299/3/tests/metadata/test_hms_integration.py
File tests/metadata/test_hms_integration.py:
http://gerrit.cloudera.org:8080/#/c/18299/3/tests/metadata/test_hms_integration.py@108
PS3, Line 108: """This function tests if JSON tables created
: in impala can be described in hive"""
nit: you don't need to wrap comments in such a small width..
http://gerrit.cloudera.org:8080/#/c/18299/3/tests/metadata/test_hms_integration.py@123
PS3, Line 123: """
nit: please use # instead.
--
To view, visit http://gerrit.cloudera.org:8080/18299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Gerrit-Change-Number: 18299
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 10 Mar 2022 08:29:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18299 )
Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Gerrit-Change-Number: 18299
Gerrit-PatchSet: 8
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 11 Mar 2022 03:20:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18299 )
Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10271/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Gerrit-Change-Number: 18299
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 09 Mar 2022 12:44:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18299 )
Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18299/6/tests/metadata/test_hms_integration.py
File tests/metadata/test_hms_integration.py:
http://gerrit.cloudera.org:8080/#/c/18299/6/tests/metadata/test_hms_integration.py@127
PS6, Line 127: #
flake8: E265 block comment should start with '# '
--
To view, visit http://gerrit.cloudera.org:8080/18299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Gerrit-Change-Number: 18299
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 10 Mar 2022 10:38:59 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18299 )
Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
......................................................................
Patch Set 6: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7923/
--
To view, visit http://gerrit.cloudera.org:8080/18299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Gerrit-Change-Number: 18299
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 10 Mar 2022 14:31:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18299 )
Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py
File tests/metadata/test_hms_integration.py:
http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py@112
PS1, Line 112: e
flake8: E501 line too long (110 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py@113
PS1, Line 113:
flake8: E501 line too long (138 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18299/1/tests/metadata/test_hms_integration.py@122
PS1, Line 122: b
flake8: E501 line too long (115 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/18299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Gerrit-Change-Number: 18299
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 09 Mar 2022 12:26:51 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18299 )
Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
......................................................................
Patch Set 8:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7926/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Gerrit-Change-Number: 18299
Gerrit-PatchSet: 8
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 11 Mar 2022 03:20:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18299 )
Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10277/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Gerrit-Change-Number: 18299
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 10 Mar 2022 10:58:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11156: TestHmsIntegration.test desc json table failed in exhaustive build
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
pranav.lodha@cloudera.com has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/18299 )
Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
......................................................................
IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in exhaustive build
The test was getting skipped as it was not in exhaustive strategy,
to fix that its been moved to TestHmsIntegrationSanity(ImpalaTestSuite)
class. Now there are two tests, test_desc_json_tbl and
test_desc_json_tbl_hive to check whether JSON tables created in
impala can be described in hive and vice versa.
Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
---
M tests/metadata/test_hms_integration.py
1 file changed, 25 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/18299/7
--
To view, visit http://gerrit.cloudera.org:8080/18299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Gerrit-Change-Number: 18299
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>