You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/19 14:18:32 UTC
[GitHub] codecov-io edited a comment on issue #5388: Move VIZ_TYPES to
separate module
codecov-io edited a comment on issue #5388: Move VIZ_TYPES to separate module
URL: https://github.com/apache/incubator-superset/pull/5388#issuecomment-405378666
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5388?src=pr&el=h1) Report
> Merging [#5388](https://codecov.io/gh/apache/incubator-superset/pull/5388?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/99ce7b79fa7a92a7ed0000af20103422f4313963?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5388 +/- ##
==========================================
+ Coverage 59.09% 59.09% +<.01%
==========================================
Files 372 373 +1
Lines 23747 23748 +1
Branches 2758 2758
==========================================
+ Hits 14033 14034 +1
Misses 9699 9699
Partials 15 15
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5388?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5388/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9DaGFydC5qc3g=) | `83.13% <100%> (ø)` | :arrow_up: |
| [superset/assets/src/modules/vizTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/5388/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9tb2R1bGVzL3ZpelR5cGVzLmpz) | `100% <100%> (ø)` | |
| [superset/assets/src/visualizations/nvd3\_vis.js](https://codecov.io/gh/apache/incubator-superset/pull/5388/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9udmQzX3Zpcy5qcw==) | `8.97% <100%> (ø)` | :arrow_up: |
| [superset/assets/src/modules/AnnotationTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/5388/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9tb2R1bGVzL0Fubm90YXRpb25UeXBlcy5qcw==) | `64% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5388?src=pr&el=footer). Last update [99ce7b7...28d4885](https://codecov.io/gh/apache/incubator-superset/pull/5388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org