You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by "mjesteve (via GitHub)" <gi...@apache.org> on 2024/05/23 21:21:49 UTC

[I] CSS support [type=xxx] [royale-compiler]

mjesteve opened a new issue, #238:
URL: https://github.com/apache/royale-compiler/issues/238

   The sass-maven-plugin is no longer maintained. This plugin is tested and verified in the Royale project but I think it would be interesting to move forward. I have been testing the dart-sass-maven-plugin and I think it is a valid and stable option.
   
   The tests I have carried out have been satisfactory but I have found problems with the styles applicable to specific "types":
   `input[type="checkbox"]`
   In these cases, the dart-sass plugin generates the CSS as `input[type=checkbox]` and this is not valid for royale-compiler.
   
   Would it be convenient to include this possibility in our compiler?
   
   Thx


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] CSS support [type=xxx] [royale-compiler]

Posted by "joshtynjala (via GitHub)" <gi...@apache.org>.
joshtynjala commented on issue #238:
URL: https://github.com/apache/royale-compiler/issues/238#issuecomment-2135972415

   @mjesteve Commit d347bf7fa57dd9d67cb83401d3db06ce925a661c looks good to me. Go ahead and merge it into develop.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] CSS support [type=xxx] [royale-compiler]

Posted by "mjesteve (via GitHub)" <gi...@apache.org>.
mjesteve commented on issue #238:
URL: https://github.com/apache/royale-compiler/issues/238#issuecomment-2136118324

   I will incorporate your changes and test it before confirming.
   Thx Josh


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] CSS support [type=xxx] [royale-compiler]

Posted by "joshtynjala (via GitHub)" <gi...@apache.org>.
joshtynjala commented on issue #238:
URL: https://github.com/apache/royale-compiler/issues/238#issuecomment-2128142512

   According to the CSS specification:
   
   > Attribute values must be identifiers or strings.
   
   Source: https://www.w3.org/TR/CSS2/selector.html#attribute-selectors
   
   In the case of `input[type=checkbox]`, `checkbox` is considered a valid identifier, so we should ideally support it.
   
   Related notes about identifiers.
   
   > In CSS, identifiers (including element names, classes, and IDs in [selectors](https://www.w3.org/TR/CSS2/selector.html)) can contain only the characters [a-zA-Z0-9] and ISO 10646 characters U+00A0 and higher, plus the hyphen (-) and the underscore (_); they cannot start with a digit, two hyphens, or a hyphen followed by a digit. Identifiers can also contain escaped characters and any ISO 10646 character as a numeric code (see next item). For instance, the identifier "B&W?" > may be written as "B\&W\?" or "B\26 W\3F".
   > 
   > Note that Unicode is code-by-code equivalent to ISO 10646
   
   Source: https://www.w3.org/TR/CSS2/syndata.html#value-def-identifier


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] CSS support [type=xxx] [royale-compiler]

Posted by "mjesteve (via GitHub)" <gi...@apache.org>.
mjesteve closed issue #238: CSS support [type=xxx]
URL: https://github.com/apache/royale-compiler/issues/238


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] CSS support [type=xxx] [royale-compiler]

Posted by "mjesteve (via GitHub)" <gi...@apache.org>.
mjesteve commented on issue #238:
URL: https://github.com/apache/royale-compiler/issues/238#issuecomment-2134076295

   False positive. I don't know why, "today", when doing a complete compilation (I did it the other day several times) it compiles, it doesn't give an error, but the code generated by the compiler in App.js is not correct:
   
   ![image](https://github.com/apache/royale-compiler/assets/55754195/0b46c28a-d3aa-4846-ac18-8da49ac803cd)
   
   For it to work, the double quotes must be single:
   
   ![image](https://github.com/apache/royale-compiler/assets/55754195/917ccb60-4fbe-4f19-a251-3cf396e89c0a)
   
   I'm missing the second part of the modification. I have modified the lexer, right? and now the transpilation part is missing?
   I'm going to continue investigating...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] CSS support [type=xxx] [royale-compiler]

Posted by "joshtynjala (via GitHub)" <gi...@apache.org>.
joshtynjala commented on issue #238:
URL: https://github.com/apache/royale-compiler/issues/238#issuecomment-2135735734

   > it doesn't give an error, but the code generated by the compiler in App.js is not correct
   
   I can reproduce this issue, even without your changes. It's an existing bug. I've committed a fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] CSS support [type=xxx] [royale-compiler]

Posted by "mjesteve (via GitHub)" <gi...@apache.org>.
mjesteve commented on issue #238:
URL: https://github.com/apache/royale-compiler/issues/238#issuecomment-2131459372

   @Josh, "I have tried it" jajajaja :P 
   I've been looking at the code and your indications ( attribute-selectors, identifier) and I think I've identified ....
   (CSS.g)
   ![image](https://github.com/apache/royale-compiler/assets/55754195/d0b1b2ca-3598-49ab-9295-bd510e8c799a)
   
   To support identifiers in attributeSelector would we have to do something like this?
   
   ```
   attributeValue
       :    STRING
       |    ID
       ;
   ```
   รณ
    ```
   attributeSelector
       :   SQUARE_OPEN attributeName attributeOperator* attributeName* attributeValue* SQUARE_END
       ;
   ```
   CSSTree.g
   Identifico estos bloques:
   
   ![image](https://github.com/apache/royale-compiler/assets/55754195/2d898ab5-9335-471e-8342-4ff791b6b0bd)
   
   Is it the good direction?
   
   Bear with me :P 
   Now I'm looking at what the ".g" files are :P
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] CSS support [type=xxx] [royale-compiler]

Posted by "mjesteve (via GitHub)" <gi...@apache.org>.
mjesteve commented on issue #238:
URL: https://github.com/apache/royale-compiler/issues/238#issuecomment-2131940143

   @Josh I have made some changes that work for me. [d347bf7](https://github.com/apache/royale-compiler/commit/d347bf7fa57dd9d67cb83401d3db06ce925a661c)
   I have compiled the SDK and then compiled my sass projects and have not had any problems.
   I don't know if the changes are correct or if they are incomplete or have errors, could you look at them?
   
   Thx.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org