[jira] [Comment Edited] (HIVE-17686) BucketingSortingOpProcFactory.FileSinkInferrer - throw/return?

["Sergey Shelukhin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-17686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190664#comment-16190664 ] 

Sergey Shelukhin edited comment on HIVE-17686 at 10/4/17 1:47 AM:
------------------------------------------------------------------

The comment referred to actually covers this; the existing code tries to infer buckets and discards the information if it cannot be done; so that is what this does also. This message is only intended as a warning in the logs.


was (Author: sershe):
The commented referred to actually covers this; the existing code tries to infer buckets and discards the information if it cannot be done; so that is what this does also. This message is only intended as a warning in the logs.

> BucketingSortingOpProcFactory.FileSinkInferrer - throw/return?
> --------------------------------------------------------------
>
>                 Key: HIVE-17686
>                 URL: https://issues.apache.org/jira/browse/HIVE-17686
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Transactions
>            Reporter: Eugene Koifman
>            Assignee: Sergey Shelukhin
>
> {noformat}
>       if (fop.getConf().isMmTable()) {
>         // See the comment inside updatePartitionBucketSortColumns.
>         LOG.warn("Currently, inferring buckets is not going to work for MM tables (by design).");
>       }
> {noformat}
> should this throw/return rather than just log?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)