You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/07 10:36:00 UTC

[GitHub] [flink] XComp commented on a diff in pull request #19780: [FLINK-27727][tests] Migrate TypeSerializerUpgradeTestBase to JUnit5

XComp commented on code in PR #19780:
URL: https://github.com/apache/flink/pull/19780#discussion_r989945698


##########
flink-core/src/test/java/org/apache/flink/api/java/typeutils/runtime/RowSerializerUpgradeTest.java:
##########
@@ -40,15 +38,9 @@
 import static org.hamcrest.Matchers.is;
 
 /** A {@link TypeSerializerUpgradeTestBase} for {@link RowSerializer}. */
-@RunWith(Parameterized.class)
 public class RowSerializerUpgradeTest extends TypeSerializerUpgradeTestBase<Row, Row> {

Review Comment:
   Fair enough. I'm wondering whether we should add `@VisibleForTesting` in that case to indicate that that class was left `public` on purpose. :thinking: WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org