[jira] [Commented] (TINKERPOP-2630) Clarify that a server cannot support Graphson1.0 over HTTP

["Divij Vaidya (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433907#comment-17433907 ] 

Divij Vaidya commented on TINKERPOP-2630:
-----------------------------------------

Thanks Stephen.

Perhaps, I should have been more clear but my original concern is not solved.

I wanted to highlight somewhere in the docs that Mime type "application/vnd.gremlin-v1.0+json" cannot be used to fetch graphson1 is any condition. The reason I wanted to highlight this is because if the server is configured correctly, "application/vnd.gremlin-v2.0+json" and "application/vnd.gremlin-v3.0+json" will work for an HTTP request but no matter how you configure the server, "application/vnd.gremlin-v1.0+json" will not. This is a gotcha which stumps users when they assume that MIME for graphson1.0 will work in a similar manner to graphson2 and graphson3.

> Clarify that a server cannot support Graphson1.0 over HTTP
> ----------------------------------------------------------
>
>                 Key: TINKERPOP-2630
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2630
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: documentation
>    Affects Versions: 3.4.12
>            Reporter: Divij Vaidya
>            Assignee: Stephen Mallette
>            Priority: Minor
>             Fix For: 3.6.0, 3.4.13, 3.5.2
>
>
> If a user sends an HTTP request to the server with MIME type for Graphson1.0 in the accept header, the server will always return an error, irrespective of the configured serializers. 
> This is because the only serializer which support MIME type `application/vnd.gremlin-v1.0+json` is `GraphSONMessageSerializerGremlinV1d0` and it will not work with HTTP requests because it's not a `MessageTextSerializer`
> We should clarify this somewhere in the docs. 
> Alternatively, we can support graphson v1.0 over HTTP by:
> 1. Register both `GraphSONMessageSerializerV1d0` and `GraphSONMessageSerializerGremlinV1d0` serializers with the server.
> 2. Add graphson v1.0 to supported mime types of `GraphSONMessageSerializerV1d0`
> 3. Change HttpEndpointHandler's chooseSerializer method to favour a MessageTextSerializer when two serializers are available for asme MIME type.
> Given that graphson 1.0 is on the path to deprecation, I would suggest that we just make a change to the documentation at this stage instead of alternative option.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)