[GitHub] zeppelin pull request #2993: ZEPPELIN-3517 Remove zeppelin.pyspark.python in...

[zjffdu <gi...@git.apache.org>]

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/2993

    ZEPPELIN-3517 Remove zeppelin.pyspark.python in PySparkInterpreter

    ### What is this PR for?
    `zeppelin.pyspark.python` should be removed as it is zeppelin specific property, and only affect the driver, but not on executor. So we should use spark property instead. 
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3517
    
    ### How should this be tested?
    * CI pass
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3517

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2993.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2993
    
----
commit 0b0c30b5f9f6a3f45fa4fbbd30f7ffba2c4e3156
Author: Jeff Zhang <zj...@...>
Date:   2018-05-31T05:24:43Z

    ZEPPELIN-3517. Remove zeppelin.pyspark.python in PySparkInterpreter

----


---

[GitHub] zeppelin pull request #2993: ZEPPELIN-3517 Remove zeppelin.pyspark.python in...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2993


---

[GitHub] zeppelin issue #2993: ZEPPELIN-3517 Remove zeppelin.pyspark.python in PySpar...

[felixcheung <gi...@git.apache.org>]

Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2993
  
    I’m all for not having special config though I’d prefer not to the break users with existing note or config right away, without some sort of deprecation period. But it’s your call
    
    
    



---

[GitHub] zeppelin issue #2993: ZEPPELIN-3517 Remove zeppelin.pyspark.python in PySpar...

[zjffdu <gi...@git.apache.org>]

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2993
  
    @felixcheung The only place to do mapping is in zeppelin server side, and I it is not to put any interpreter specific login in zeppelin server side. And I think it's better for zeppelin to use the same configuration as spark instead of introducing zeppelin specific configuration. 


---

[GitHub] zeppelin issue #2993: ZEPPELIN-3517 Remove zeppelin.pyspark.python in PySpar...

[r-kamath <gi...@git.apache.org>]

Github user r-kamath commented on the issue:

    https://github.com/apache/zeppelin/pull/2993
  
    LGTM


---

[GitHub] zeppelin issue #2993: ZEPPELIN-3517 Remove zeppelin.pyspark.python in PySpar...

[zjffdu <gi...@git.apache.org>]

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2993
  
    Thanks @felixcheung . I still think it is better to remove it. As it is difficult to deprecate this and let users to aware of that. Zeppelin is a notebook instead of library. If we don't remove it and just deprecate it in documentation, I believe most of users won't be know that and would continue to use it and may ask question in user mail list why they hit python version mismatch issue between driver and executors. 


---