You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by jkbradley <gi...@git.apache.org> on 2018/04/03 20:39:46 UTC

[GitHub] spark pull request #20633: [SPARK-23455][ML] Default Params in ML should be ...

Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20633#discussion_r178955105
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
    @@ -791,7 +791,7 @@ trait Params extends Identifiable with Serializable {
        *               this method gets called.
        * @param value  the default value
        */
    -  protected final def setDefault[T](param: Param[T], value: T): this.type = {
    +  private[ml] final def setDefault[T](param: Param[T], value: T): this.type = {
    --- End diff --
    
    Makes sense; I like your solution.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org