You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/17 10:50:04 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5335: fix bug about webflux broken trace

wu-sheng commented on a change in pull request #5335:
URL: https://github.com/apache/skywalking/pull/5335#discussion_r471397836



##########
File path: apm-sniffer/apm-sdk-plugin/spring-plugins/spring-webflux-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/webflux/v5/DispatcherHandlerHandleMethodInterceptor.java
##########
@@ -79,6 +78,7 @@ public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allA
         return ((Mono) ret).doFinally(s -> {
             AbstractSpan span = (AbstractSpan) exchange.getAttributes().get("SKYWALING_SPAN");
             if (span != null) {
+                ContextManager.stopSpan(span);

Review comment:
       I double this is a fix. This should be a part of another thread.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org