[GitHub] [hbase] Apache9 commented on a diff in pull request #4651: HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

[GitBox <gi...@apache.org>]

Apache9 commented on code in PR #4651:
URL: https://github.com/apache/hbase/pull/4651#discussion_r930608839


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java:
##########
@@ -1717,7 +1716,13 @@ public void mergeRegionsSync(final byte[] nameOfRegionA, final byte[] nameOfRegi
   @Override
   public void mergeRegions(final byte[] nameOfRegionA, final byte[] nameOfRegionB,
     final boolean forcible) throws IOException {
-    mergeRegionsAsync(nameOfRegionA, nameOfRegionB, forcible);
+    try {

Review Comment:
   IIRC this is a known issue. You can see the comments in the Admin interface.
   
   ```
     /**
      * Merge two regions. Asynchronous operation.
      * @param nameOfRegionA encoded or full name of region a
      * @param nameOfRegionB encoded or full name of region b
      * @param forcible      <code>true</code> if do a compulsory merge, otherwise we will only merge
      *                      two adjacent regions
      * @throws IOException if a remote or network exception occurs
      * @deprecated Since 2.0. Will be removed in 3.0. Use
      *             {@link #mergeRegionsAsync(byte[], byte[], boolean)} instead.
      */
     @Deprecated
     void mergeRegions(byte[] nameOfRegionA, byte[] nameOfRegionB, boolean forcible)
       throws IOException;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org