[GitHub] [airflow] pateash commented on a diff in pull request #25714: Adding ClickHouse Provider

[GitBox <gi...@apache.org>]

pateash commented on code in PR #25714:
URL: https://github.com/apache/airflow/pull/25714#discussion_r977686463


##########
airflow/providers/clickhouse/sensors/clickhouse.py:
##########
@@ -0,0 +1,71 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from typing import Any, Callable, Dict, Optional
+
+from airflow.providers.clickhouse.hooks.clickhouse import ClickHouseHook
+from airflow.sensors.sql import SqlSensor
+
+
+class ClickHouseSensor(SqlSensor):

Review Comment:
   HI @eladkal,
   Sorry for the late response, I was OOO.
   
   the reason I didn't used DBApiHook is because it's intended to be used with databases ( mostly transactional ),
   
   and Clickhouse being a OLAP, i really think that it will be better not to expose methods like insert_rows(), which uses sqlalchemy.
   rather if someone wants to have this functionality they should use the underlying library ( **clickhouse-driver**  ) and implement their own operator using the hook and connection object.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org