You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/15 12:31:05 UTC

[GitHub] [flink] gsralex opened a new pull request #13651: [FLINK-19649][sql-parser] Fix unparse method of sql create table. Keep syntax the same for tables without columns

gsralex opened a new pull request #13651:
URL: https://github.com/apache/flink/pull/13651


   In Flink's module flink-sql-parser, the sqlCreateTable.class unparse method the create table statement does not match the new rules of the print connector.
   
   The print connector supports this:
   
   `CREATE TABLE table_print WITH ('connector' = 'print') LIKE table (EXCLUDING ALL)`
   
   When a print table is created without any columns, the parentheses must be omitted.
   
   However, the unparse generated statements in SqlCreateTable contain parentheses. This will affect the SqlCreateTable.toString() ,SqlCreateTable.toSqlString() methods.
   
   `
   CREATE TABLE table_print() WITH ('connector' = 'print') LIKE table (EXCLUDING ALL)  `
   
   Might need to add the following to the unparse method for columnList.size > 0.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gsralex commented on pull request #13651: [FLINK-19649][sql-parser] Fix unparse method of sql create table. Keep syntax the same for tables without columns

Posted by GitBox <gi...@apache.org>.
gsralex commented on pull request #13651:
URL: https://github.com/apache/flink/pull/13651#issuecomment-709808720


   > > Please add some unit tests.
   > 
   > Okay, I'll add some unit tests.
   
   Hi, Kurt. I've added some unit tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13651: [FLINK-19649][sql-parser] Fix unparse method of sql create table. Keep syntax the same for tables without columns

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13651:
URL: https://github.com/apache/flink/pull/13651#issuecomment-709309235


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "eb69ec2bfbe2d8250056898954f43bacf16c4b40",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7688",
       "triggerID" : "eb69ec2bfbe2d8250056898954f43bacf16c4b40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "049be6bba93a8cfd12e8a60ca7961909e94e3fee",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7725",
       "triggerID" : "049be6bba93a8cfd12e8a60ca7961909e94e3fee",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * eb69ec2bfbe2d8250056898954f43bacf16c4b40 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7688) 
   * 049be6bba93a8cfd12e8a60ca7961909e94e3fee Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7725) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gsralex commented on pull request #13651: [FLINK-19649][sql-parser] Fix unparse method of sql create table. Keep syntax the same for tables without columns

Posted by GitBox <gi...@apache.org>.
gsralex commented on pull request #13651:
URL: https://github.com/apache/flink/pull/13651#issuecomment-709682544


   > Please add some unit tests.
   
   Okay, I'll add some unit tests. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13651: [FLINK-19649][sql-parser] Fix unparse method of sql create table. Keep syntax the same for tables without columns

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13651:
URL: https://github.com/apache/flink/pull/13651#issuecomment-709309235


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "eb69ec2bfbe2d8250056898954f43bacf16c4b40",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "eb69ec2bfbe2d8250056898954f43bacf16c4b40",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * eb69ec2bfbe2d8250056898954f43bacf16c4b40 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13651: [FLINK-19649][sql-parser] Fix unparse method of sql create table. Keep syntax the same for tables without columns

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13651:
URL: https://github.com/apache/flink/pull/13651#issuecomment-709309235


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "eb69ec2bfbe2d8250056898954f43bacf16c4b40",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7688",
       "triggerID" : "eb69ec2bfbe2d8250056898954f43bacf16c4b40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "049be6bba93a8cfd12e8a60ca7961909e94e3fee",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "049be6bba93a8cfd12e8a60ca7961909e94e3fee",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * eb69ec2bfbe2d8250056898954f43bacf16c4b40 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7688) 
   * 049be6bba93a8cfd12e8a60ca7961909e94e3fee UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13651: [FLINK-19649][sql-parser] Fix unparse method of sql create table. Keep syntax the same for tables without columns

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13651:
URL: https://github.com/apache/flink/pull/13651#issuecomment-709309235


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "eb69ec2bfbe2d8250056898954f43bacf16c4b40",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7688",
       "triggerID" : "eb69ec2bfbe2d8250056898954f43bacf16c4b40",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * eb69ec2bfbe2d8250056898954f43bacf16c4b40 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7688) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] KurtYoung merged pull request #13651: [FLINK-19649][sql-parser] Fix unparse method of sql create table. Keep syntax the same for tables without columns

Posted by GitBox <gi...@apache.org>.
KurtYoung merged pull request #13651:
URL: https://github.com/apache/flink/pull/13651


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13651: [FLINK-19649][sql-parser] Fix unparse method of sql create table. Keep syntax the same for tables without columns

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13651:
URL: https://github.com/apache/flink/pull/13651#issuecomment-709309235


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "eb69ec2bfbe2d8250056898954f43bacf16c4b40",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7688",
       "triggerID" : "eb69ec2bfbe2d8250056898954f43bacf16c4b40",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * eb69ec2bfbe2d8250056898954f43bacf16c4b40 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7688) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13651: [FLINK-19649][sql-parser] Fix unparse method of sql create table. Keep syntax the same for tables without columns

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13651:
URL: https://github.com/apache/flink/pull/13651#issuecomment-709286155


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 049be6bba93a8cfd12e8a60ca7961909e94e3fee (Fri Oct 16 10:57:23 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-19649).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] KurtYoung commented on pull request #13651: [FLINK-19649][sql-parser] Fix unparse method of sql create table. Keep syntax the same for tables without columns

Posted by GitBox <gi...@apache.org>.
KurtYoung commented on pull request #13651:
URL: https://github.com/apache/flink/pull/13651#issuecomment-709667247


   Please add some unit tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13651: [FLINK-19649][sql-parser] Fix unparse method of sql create table. Keep syntax the same for tables without columns

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13651:
URL: https://github.com/apache/flink/pull/13651#issuecomment-709286155


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit eb69ec2bfbe2d8250056898954f43bacf16c4b40 (Thu Oct 15 12:33:20 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-19649).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13651: [FLINK-19649][sql-parser] Fix unparse method of sql create table. Keep syntax the same for tables without columns

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13651:
URL: https://github.com/apache/flink/pull/13651#issuecomment-709309235


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "eb69ec2bfbe2d8250056898954f43bacf16c4b40",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7688",
       "triggerID" : "eb69ec2bfbe2d8250056898954f43bacf16c4b40",
       "triggerType" : "PUSH"
     }, {
       "hash" : "049be6bba93a8cfd12e8a60ca7961909e94e3fee",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7725",
       "triggerID" : "049be6bba93a8cfd12e8a60ca7961909e94e3fee",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 049be6bba93a8cfd12e8a60ca7961909e94e3fee Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7725) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org