You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by "Collinson, Alasdair" <Al...@senacor.com> on 2015/04/29 10:18:14 UTC
Disabled Validators
Hi!
In a component I'm developing, there's an AbstractRangeValidator which should only be used under certain conditions. Since this is also a Behavior I would have expected overriding Behavior#isEnabled(Component) would deactivate the validator whenever we return false here. However, in FormComponent#validateValidators() there is no reference to Behavior#isEnabled(Component) and the validator is processed. Is this a bug or is that feature meant for something completely different? If so, what would be the best way to enable a validator only in certain conditions?
Thanks a lot,
Alasdair
Alasdair Collinson
______________________________
Senacor Technologies AG
Joseph-Schumpeter-Allee 1
53227 Bonn
T +49 (228) 7636 - 247
F +49 (228) 7636 - 100
M +49 (171) 30 19 990
Alasdair.Collinson@senacor.com
www.senacor.com
Senacor Technologies Aktiengesellschaft - Sitz: Schwaig b. Nbg. - Amtsgericht Nbg.- Reg.-Nr.: HRB 23098
Vorstand: Matthias Tomann, Marcus Purzer - Aufsichtsratsvorsitzender: Mathias J. Lindermeir
Diese E-Mail inklusive Anlagen enth?lt vertrauliche und/oder rechtlich gesch?tzte Informationen. Wenn Sie
nicht der richtige Adressat sind oder diese E-Mail irrt?mlich erhalten, informieren Sie bitte den Absender
und vernichten Sie diese E-Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser E-Mail ist
nicht gestattet.
This e-mail including any attachments may contain confidential and/or privileged information. If you are
not the intended recipient (or have received this e-mail in error) please notify the sender immediately and
destroy this e-mail. Any unauthorized copying, disclosure or distribution of the materials in this e-mail is
strictly forbidden.
AW: Disabled Validators
Posted by "Collinson, Alasdair" <Al...@senacor.com>.
That was fast. :-D
Thanks,
Alasdair
________________________________________
Von: Martin Grigorov <mg...@apache.org>
Gesendet: Mittwoch, 29. April 2015 14:09
An: users@wicket.apache.org
Betreff: Re: Disabled Validators
Implemented!
Yes. You will have to move the logic whether to validate inside #validate()
method.
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Wed, Apr 29, 2015 at 2:51 PM, Collinson, Alasdair <
Alasdair.Collinson@senacor.com> wrote:
> Hi Martin!
>
> Thanks for the reply, I've created a JIRA Ticket. [1] I guess we'll have
> to work around the problem in the meantime.
>
> Regards,
> Alasdair
>
> [1] https://issues.apache.org/jira/browse/WICKET-5897
> ________________________________________
> Von: Martin Grigorov <mg...@apache.org>
> Gesendet: Mittwoch, 29. April 2015 13:33
> An: users@wicket.apache.org
> Betreff: Re: Disabled Validators
>
> Hi,
>
> Validators became Behaviors [1] post factum [2].
> I think it is a good idea to make use of #isEnabled() for them too.
> Please file a ticket at JIRA. Thanks!
>
> 1.
>
> https://github.com/apache/wicket/blob/b4f69ac3492506c9841ad5c7cfc16a163d1df3d3/wicket-core/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java#L525
> 2. https://issues.apache.org/jira/browse/WICKET-3214
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Wed, Apr 29, 2015 at 11:18 AM, Collinson, Alasdair <
> Alasdair.Collinson@senacor.com> wrote:
>
> > Hi!
> >
> > In a component I'm developing, there's an AbstractRangeValidator which
> > should only be used under certain conditions. Since this is also a
> Behavior
> > I would have expected overriding Behavior#isEnabled(Component) would
> > deactivate the validator whenever we return false here. However, in
> > FormComponent#validateValidators() there is no reference to
> > Behavior#isEnabled(Component) and the validator is processed. Is this a
> bug
> > or is that feature meant for something completely different? If so, what
> > would be the best way to enable a validator only in certain conditions?
> >
> > Thanks a lot,
> > Alasdair
> >
> > Alasdair Collinson
> > ______________________________
> > Senacor Technologies AG
> > Joseph-Schumpeter-Allee 1
> > 53227 Bonn
> >
> > T +49 (228) 7636 - 247
> > F +49 (228) 7636 - 100
> > M +49 (171) 30 19 990
> >
> > Alasdair.Collinson@senacor.com
> > www.senacor.com
> >
> >
> > Senacor Technologies Aktiengesellschaft - Sitz: Schwaig b. Nbg. -
> > Amtsgericht Nbg.- Reg.-Nr.: HRB 23098
> > Vorstand: Matthias Tomann, Marcus Purzer - Aufsichtsratsvorsitzender:
> > Mathias J. Lindermeir
> >
> > Diese E-Mail inklusive Anlagen enth?lt vertrauliche und/oder rechtlich
> > gesch?tzte Informationen. Wenn Sie
> > nicht der richtige Adressat sind oder diese E-Mail irrt?mlich erhalten,
> > informieren Sie bitte den Absender
> > und vernichten Sie diese E-Mail. Das unerlaubte Kopieren sowie die
> > unbefugte Weitergabe dieser E-Mail ist
> > nicht gestattet.
> >
> > This e-mail including any attachments may contain confidential and/or
> > privileged information. If you are
> > not the intended recipient (or have received this e-mail in error) please
> > notify the sender immediately and
> > destroy this e-mail. Any unauthorized copying, disclosure or distribution
> > of the materials in this e-mail is
> > strictly forbidden.
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Disabled Validators
Posted by Martin Grigorov <mg...@apache.org>.
Implemented!
Yes. You will have to move the logic whether to validate inside #validate()
method.
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Wed, Apr 29, 2015 at 2:51 PM, Collinson, Alasdair <
Alasdair.Collinson@senacor.com> wrote:
> Hi Martin!
>
> Thanks for the reply, I've created a JIRA Ticket. [1] I guess we'll have
> to work around the problem in the meantime.
>
> Regards,
> Alasdair
>
> [1] https://issues.apache.org/jira/browse/WICKET-5897
> ________________________________________
> Von: Martin Grigorov <mg...@apache.org>
> Gesendet: Mittwoch, 29. April 2015 13:33
> An: users@wicket.apache.org
> Betreff: Re: Disabled Validators
>
> Hi,
>
> Validators became Behaviors [1] post factum [2].
> I think it is a good idea to make use of #isEnabled() for them too.
> Please file a ticket at JIRA. Thanks!
>
> 1.
>
> https://github.com/apache/wicket/blob/b4f69ac3492506c9841ad5c7cfc16a163d1df3d3/wicket-core/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java#L525
> 2. https://issues.apache.org/jira/browse/WICKET-3214
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Wed, Apr 29, 2015 at 11:18 AM, Collinson, Alasdair <
> Alasdair.Collinson@senacor.com> wrote:
>
> > Hi!
> >
> > In a component I'm developing, there's an AbstractRangeValidator which
> > should only be used under certain conditions. Since this is also a
> Behavior
> > I would have expected overriding Behavior#isEnabled(Component) would
> > deactivate the validator whenever we return false here. However, in
> > FormComponent#validateValidators() there is no reference to
> > Behavior#isEnabled(Component) and the validator is processed. Is this a
> bug
> > or is that feature meant for something completely different? If so, what
> > would be the best way to enable a validator only in certain conditions?
> >
> > Thanks a lot,
> > Alasdair
> >
> > Alasdair Collinson
> > ______________________________
> > Senacor Technologies AG
> > Joseph-Schumpeter-Allee 1
> > 53227 Bonn
> >
> > T +49 (228) 7636 - 247
> > F +49 (228) 7636 - 100
> > M +49 (171) 30 19 990
> >
> > Alasdair.Collinson@senacor.com
> > www.senacor.com
> >
> >
> > Senacor Technologies Aktiengesellschaft - Sitz: Schwaig b. Nbg. -
> > Amtsgericht Nbg.- Reg.-Nr.: HRB 23098
> > Vorstand: Matthias Tomann, Marcus Purzer - Aufsichtsratsvorsitzender:
> > Mathias J. Lindermeir
> >
> > Diese E-Mail inklusive Anlagen enth?lt vertrauliche und/oder rechtlich
> > gesch?tzte Informationen. Wenn Sie
> > nicht der richtige Adressat sind oder diese E-Mail irrt?mlich erhalten,
> > informieren Sie bitte den Absender
> > und vernichten Sie diese E-Mail. Das unerlaubte Kopieren sowie die
> > unbefugte Weitergabe dieser E-Mail ist
> > nicht gestattet.
> >
> > This e-mail including any attachments may contain confidential and/or
> > privileged information. If you are
> > not the intended recipient (or have received this e-mail in error) please
> > notify the sender immediately and
> > destroy this e-mail. Any unauthorized copying, disclosure or distribution
> > of the materials in this e-mail is
> > strictly forbidden.
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
AW: Disabled Validators
Posted by "Collinson, Alasdair" <Al...@senacor.com>.
Hi Martin!
Thanks for the reply, I've created a JIRA Ticket. [1] I guess we'll have to work around the problem in the meantime.
Regards,
Alasdair
[1] https://issues.apache.org/jira/browse/WICKET-5897
________________________________________
Von: Martin Grigorov <mg...@apache.org>
Gesendet: Mittwoch, 29. April 2015 13:33
An: users@wicket.apache.org
Betreff: Re: Disabled Validators
Hi,
Validators became Behaviors [1] post factum [2].
I think it is a good idea to make use of #isEnabled() for them too.
Please file a ticket at JIRA. Thanks!
1.
https://github.com/apache/wicket/blob/b4f69ac3492506c9841ad5c7cfc16a163d1df3d3/wicket-core/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java#L525
2. https://issues.apache.org/jira/browse/WICKET-3214
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Wed, Apr 29, 2015 at 11:18 AM, Collinson, Alasdair <
Alasdair.Collinson@senacor.com> wrote:
> Hi!
>
> In a component I'm developing, there's an AbstractRangeValidator which
> should only be used under certain conditions. Since this is also a Behavior
> I would have expected overriding Behavior#isEnabled(Component) would
> deactivate the validator whenever we return false here. However, in
> FormComponent#validateValidators() there is no reference to
> Behavior#isEnabled(Component) and the validator is processed. Is this a bug
> or is that feature meant for something completely different? If so, what
> would be the best way to enable a validator only in certain conditions?
>
> Thanks a lot,
> Alasdair
>
> Alasdair Collinson
> ______________________________
> Senacor Technologies AG
> Joseph-Schumpeter-Allee 1
> 53227 Bonn
>
> T +49 (228) 7636 - 247
> F +49 (228) 7636 - 100
> M +49 (171) 30 19 990
>
> Alasdair.Collinson@senacor.com
> www.senacor.com
>
>
> Senacor Technologies Aktiengesellschaft - Sitz: Schwaig b. Nbg. -
> Amtsgericht Nbg.- Reg.-Nr.: HRB 23098
> Vorstand: Matthias Tomann, Marcus Purzer - Aufsichtsratsvorsitzender:
> Mathias J. Lindermeir
>
> Diese E-Mail inklusive Anlagen enth?lt vertrauliche und/oder rechtlich
> gesch?tzte Informationen. Wenn Sie
> nicht der richtige Adressat sind oder diese E-Mail irrt?mlich erhalten,
> informieren Sie bitte den Absender
> und vernichten Sie diese E-Mail. Das unerlaubte Kopieren sowie die
> unbefugte Weitergabe dieser E-Mail ist
> nicht gestattet.
>
> This e-mail including any attachments may contain confidential and/or
> privileged information. If you are
> not the intended recipient (or have received this e-mail in error) please
> notify the sender immediately and
> destroy this e-mail. Any unauthorized copying, disclosure or distribution
> of the materials in this e-mail is
> strictly forbidden.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Disabled Validators
Posted by Martin Grigorov <mg...@apache.org>.
Hi,
Validators became Behaviors [1] post factum [2].
I think it is a good idea to make use of #isEnabled() for them too.
Please file a ticket at JIRA. Thanks!
1.
https://github.com/apache/wicket/blob/b4f69ac3492506c9841ad5c7cfc16a163d1df3d3/wicket-core/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java#L525
2. https://issues.apache.org/jira/browse/WICKET-3214
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Wed, Apr 29, 2015 at 11:18 AM, Collinson, Alasdair <
Alasdair.Collinson@senacor.com> wrote:
> Hi!
>
> In a component I'm developing, there's an AbstractRangeValidator which
> should only be used under certain conditions. Since this is also a Behavior
> I would have expected overriding Behavior#isEnabled(Component) would
> deactivate the validator whenever we return false here. However, in
> FormComponent#validateValidators() there is no reference to
> Behavior#isEnabled(Component) and the validator is processed. Is this a bug
> or is that feature meant for something completely different? If so, what
> would be the best way to enable a validator only in certain conditions?
>
> Thanks a lot,
> Alasdair
>
> Alasdair Collinson
> ______________________________
> Senacor Technologies AG
> Joseph-Schumpeter-Allee 1
> 53227 Bonn
>
> T +49 (228) 7636 - 247
> F +49 (228) 7636 - 100
> M +49 (171) 30 19 990
>
> Alasdair.Collinson@senacor.com
> www.senacor.com
>
>
> Senacor Technologies Aktiengesellschaft - Sitz: Schwaig b. Nbg. -
> Amtsgericht Nbg.- Reg.-Nr.: HRB 23098
> Vorstand: Matthias Tomann, Marcus Purzer - Aufsichtsratsvorsitzender:
> Mathias J. Lindermeir
>
> Diese E-Mail inklusive Anlagen enth?lt vertrauliche und/oder rechtlich
> gesch?tzte Informationen. Wenn Sie
> nicht der richtige Adressat sind oder diese E-Mail irrt?mlich erhalten,
> informieren Sie bitte den Absender
> und vernichten Sie diese E-Mail. Das unerlaubte Kopieren sowie die
> unbefugte Weitergabe dieser E-Mail ist
> nicht gestattet.
>
> This e-mail including any attachments may contain confidential and/or
> privileged information. If you are
> not the intended recipient (or have received this e-mail in error) please
> notify the sender immediately and
> destroy this e-mail. Any unauthorized copying, disclosure or distribution
> of the materials in this e-mail is
> strictly forbidden.
>