You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <jh...@pivotal.io> on 2016/10/10 17:35:50 UTC

Review Request 52698: GEODE-1972: Move Geode Hibernate module to a feature branch

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52698/
-----------------------------------------------------------

Review request for geode.


Repository: geode


Description
-------

This removes hibernate from Geode


Diffs
-----

  extensions/geode-modules-assembly/build.gradle f037aad 
  gradle/sonar.gradle 33140d3 
  settings.gradle 0b7002b 

Diff: https://reviews.apache.org/r/52698/diff/


Testing
-------


Thanks,

Jason Huynh


Re: Review Request 52698: GEODE-1972: Move Geode Hibernate module to a feature branch

Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52698/#review152021
-----------------------------------------------------------


Ship it!




Ship It!

- Anthony Baker


On Oct. 10, 2016, 5:36 p.m., Jason Huynh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52698/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2016, 5:36 p.m.)
> 
> 
> Review request for geode.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> This removes hibernate from Geode
> 
> 
> Diffs
> -----
> 
>   extensions/geode-modules-assembly/build.gradle f037aad 
>   extensions/geode-modules-hibernate/build.gradle 5169b04 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/EnumType.java 0a8218e 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/GemFireCache.java 134bbf6 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/GemFireCacheListener.java 0738f36 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/GemFireCacheProvider.java 2ccb5c0 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/GemFireQueryCacheFactory.java fba1d9f 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/GemFireRegionFactory.java 088d0b1 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/Access.java a14f7ac 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/ClientServerRegionFactoryDelegate.java bbe3917 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/CollectionAccess.java d921ade 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/EntityRegionWriter.java d4f6f2f 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/EntityVersion.java 9851d29 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/EntityVersionImpl.java ad866a6 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/EntityWrapper.java a829de6 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/GemFireBaseRegion.java 022187a 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/GemFireCollectionRegion.java 5cb53ea 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/GemFireEntityRegion.java 0f514a4 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/GemFireQueryResultsRegion.java 28c9095 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/KeyWrapper.java dc8793f 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/NonStrictReadWriteAccess.java d6e9968 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/ReadOnlyAccess.java e99210f 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/ReadWriteAccess.java 5597c97 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/RegionFactoryDelegate.java 1891528 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/TransactionalAccess.java c8ec670 
>   extensions/geode-modules-hibernate/src/test/java/org/apache/geode/modules/Event.java 39eec22 
>   extensions/geode-modules-hibernate/src/test/java/org/apache/geode/modules/HibernateJUnitTest.java a9d6c64 
>   extensions/geode-modules-hibernate/src/test/java/org/apache/geode/modules/Owner.java 772f131 
>   extensions/geode-modules-hibernate/src/test/java/org/apache/geode/modules/Person.java c98bb81 
>   extensions/geode-modules-hibernate/src/test/java/org/apache/geode/modules/SecondVMTest.java cdc8e07 
>   extensions/geode-modules-hibernate/src/test/resources/log4j.properties c136990 
>   extensions/geode-modules-hibernate/src/test/resources/org/apache/geode/modules/Event.hbm.xml 2473641 
>   extensions/geode-modules-hibernate/src/test/resources/org/apache/geode/modules/Person.hbm.xml 2105b1d 
>   gradle/sonar.gradle 33140d3 
>   settings.gradle 0b7002b 
> 
> Diff: https://reviews.apache.org/r/52698/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>


Re: Review Request 52698: GEODE-1972: Move Geode Hibernate module to a feature branch

Posted by Mark Bretl <mb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52698/#review152029
-----------------------------------------------------------


Ship it!




Ship It!

- Mark Bretl


On Oct. 10, 2016, 10:36 a.m., Jason Huynh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52698/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2016, 10:36 a.m.)
> 
> 
> Review request for geode.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> This removes hibernate from Geode
> 
> 
> Diffs
> -----
> 
>   extensions/geode-modules-assembly/build.gradle f037aad 
>   extensions/geode-modules-hibernate/build.gradle 5169b04 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/EnumType.java 0a8218e 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/GemFireCache.java 134bbf6 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/GemFireCacheListener.java 0738f36 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/GemFireCacheProvider.java 2ccb5c0 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/GemFireQueryCacheFactory.java fba1d9f 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/GemFireRegionFactory.java 088d0b1 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/Access.java a14f7ac 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/ClientServerRegionFactoryDelegate.java bbe3917 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/CollectionAccess.java d921ade 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/EntityRegionWriter.java d4f6f2f 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/EntityVersion.java 9851d29 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/EntityVersionImpl.java ad866a6 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/EntityWrapper.java a829de6 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/GemFireBaseRegion.java 022187a 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/GemFireCollectionRegion.java 5cb53ea 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/GemFireEntityRegion.java 0f514a4 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/GemFireQueryResultsRegion.java 28c9095 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/KeyWrapper.java dc8793f 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/NonStrictReadWriteAccess.java d6e9968 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/ReadOnlyAccess.java e99210f 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/ReadWriteAccess.java 5597c97 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/RegionFactoryDelegate.java 1891528 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/TransactionalAccess.java c8ec670 
>   extensions/geode-modules-hibernate/src/test/java/org/apache/geode/modules/Event.java 39eec22 
>   extensions/geode-modules-hibernate/src/test/java/org/apache/geode/modules/HibernateJUnitTest.java a9d6c64 
>   extensions/geode-modules-hibernate/src/test/java/org/apache/geode/modules/Owner.java 772f131 
>   extensions/geode-modules-hibernate/src/test/java/org/apache/geode/modules/Person.java c98bb81 
>   extensions/geode-modules-hibernate/src/test/java/org/apache/geode/modules/SecondVMTest.java cdc8e07 
>   extensions/geode-modules-hibernate/src/test/resources/log4j.properties c136990 
>   extensions/geode-modules-hibernate/src/test/resources/org/apache/geode/modules/Event.hbm.xml 2473641 
>   extensions/geode-modules-hibernate/src/test/resources/org/apache/geode/modules/Person.hbm.xml 2105b1d 
>   gradle/sonar.gradle 33140d3 
>   settings.gradle 0b7002b 
> 
> Diff: https://reviews.apache.org/r/52698/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>


Re: Review Request 52698: GEODE-1972: Move Geode Hibernate module to a feature branch

Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52698/#review152014
-----------------------------------------------------------


Ship it!




Ship It!

- Dan Smith


On Oct. 10, 2016, 5:36 p.m., Jason Huynh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52698/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2016, 5:36 p.m.)
> 
> 
> Review request for geode.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> This removes hibernate from Geode
> 
> 
> Diffs
> -----
> 
>   extensions/geode-modules-assembly/build.gradle f037aad 
>   extensions/geode-modules-hibernate/build.gradle 5169b04 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/EnumType.java 0a8218e 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/GemFireCache.java 134bbf6 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/GemFireCacheListener.java 0738f36 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/GemFireCacheProvider.java 2ccb5c0 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/GemFireQueryCacheFactory.java fba1d9f 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/GemFireRegionFactory.java 088d0b1 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/Access.java a14f7ac 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/ClientServerRegionFactoryDelegate.java bbe3917 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/CollectionAccess.java d921ade 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/EntityRegionWriter.java d4f6f2f 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/EntityVersion.java 9851d29 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/EntityVersionImpl.java ad866a6 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/EntityWrapper.java a829de6 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/GemFireBaseRegion.java 022187a 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/GemFireCollectionRegion.java 5cb53ea 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/GemFireEntityRegion.java 0f514a4 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/GemFireQueryResultsRegion.java 28c9095 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/KeyWrapper.java dc8793f 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/NonStrictReadWriteAccess.java d6e9968 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/ReadOnlyAccess.java e99210f 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/ReadWriteAccess.java 5597c97 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/RegionFactoryDelegate.java 1891528 
>   extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/TransactionalAccess.java c8ec670 
>   extensions/geode-modules-hibernate/src/test/java/org/apache/geode/modules/Event.java 39eec22 
>   extensions/geode-modules-hibernate/src/test/java/org/apache/geode/modules/HibernateJUnitTest.java a9d6c64 
>   extensions/geode-modules-hibernate/src/test/java/org/apache/geode/modules/Owner.java 772f131 
>   extensions/geode-modules-hibernate/src/test/java/org/apache/geode/modules/Person.java c98bb81 
>   extensions/geode-modules-hibernate/src/test/java/org/apache/geode/modules/SecondVMTest.java cdc8e07 
>   extensions/geode-modules-hibernate/src/test/resources/log4j.properties c136990 
>   extensions/geode-modules-hibernate/src/test/resources/org/apache/geode/modules/Event.hbm.xml 2473641 
>   extensions/geode-modules-hibernate/src/test/resources/org/apache/geode/modules/Person.hbm.xml 2105b1d 
>   gradle/sonar.gradle 33140d3 
>   settings.gradle 0b7002b 
> 
> Diff: https://reviews.apache.org/r/52698/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>


Re: Review Request 52698: GEODE-1972: Move Geode Hibernate module to a feature branch

Posted by Jason Huynh <jh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52698/
-----------------------------------------------------------

(Updated Oct. 10, 2016, 5:36 p.m.)


Review request for geode.


Repository: geode


Description
-------

This removes hibernate from Geode


Diffs (updated)
-----

  extensions/geode-modules-assembly/build.gradle f037aad 
  extensions/geode-modules-hibernate/build.gradle 5169b04 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/EnumType.java 0a8218e 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/GemFireCache.java 134bbf6 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/GemFireCacheListener.java 0738f36 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/GemFireCacheProvider.java 2ccb5c0 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/GemFireQueryCacheFactory.java fba1d9f 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/GemFireRegionFactory.java 088d0b1 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/Access.java a14f7ac 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/ClientServerRegionFactoryDelegate.java bbe3917 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/CollectionAccess.java d921ade 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/EntityRegionWriter.java d4f6f2f 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/EntityVersion.java 9851d29 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/EntityVersionImpl.java ad866a6 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/EntityWrapper.java a829de6 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/GemFireBaseRegion.java 022187a 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/GemFireCollectionRegion.java 5cb53ea 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/GemFireEntityRegion.java 0f514a4 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/GemFireQueryResultsRegion.java 28c9095 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/KeyWrapper.java dc8793f 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/NonStrictReadWriteAccess.java d6e9968 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/ReadOnlyAccess.java e99210f 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/ReadWriteAccess.java 5597c97 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/RegionFactoryDelegate.java 1891528 
  extensions/geode-modules-hibernate/src/main/java/org/apache/geode/modules/hibernate/internal/TransactionalAccess.java c8ec670 
  extensions/geode-modules-hibernate/src/test/java/org/apache/geode/modules/Event.java 39eec22 
  extensions/geode-modules-hibernate/src/test/java/org/apache/geode/modules/HibernateJUnitTest.java a9d6c64 
  extensions/geode-modules-hibernate/src/test/java/org/apache/geode/modules/Owner.java 772f131 
  extensions/geode-modules-hibernate/src/test/java/org/apache/geode/modules/Person.java c98bb81 
  extensions/geode-modules-hibernate/src/test/java/org/apache/geode/modules/SecondVMTest.java cdc8e07 
  extensions/geode-modules-hibernate/src/test/resources/log4j.properties c136990 
  extensions/geode-modules-hibernate/src/test/resources/org/apache/geode/modules/Event.hbm.xml 2473641 
  extensions/geode-modules-hibernate/src/test/resources/org/apache/geode/modules/Person.hbm.xml 2105b1d 
  gradle/sonar.gradle 33140d3 
  settings.gradle 0b7002b 

Diff: https://reviews.apache.org/r/52698/diff/


Testing
-------


Thanks,

Jason Huynh