Re: [PR] [SPARK-53738][SQL] Fix planned write when query output contains foldable orderings [spark]

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #52584:
URL: https://github.com/apache/spark/pull/52584#discussion_r2536978854


##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/command/V1WriteHiveCommandSuite.scala:
##########
@@ -126,4 +127,37 @@ class V1WriteHiveCommandSuite
       }
     }
   }
+
+  test("v1 write to hive table with sort by literal column preserve custom order") {
+    withCovnertMetastore { _ =>
+      withPlannedWrite { enabled =>

Review Comment:
   @pan3793 This `enabled` is not actually being utilized in the test, so does this test case really need to be wrapped with `withPlannedWrite`? This will result in the test content being executed twice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org