You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@paimon.apache.org by "JingsongLi (via GitHub)" <gi...@apache.org> on 2023/03/29 03:08:12 UTC

[GitHub] [incubator-paimon] JingsongLi opened a new issue, #747: [Feature] Flink Catalog supports partition methods

JingsongLi opened a new issue, #747:
URL: https://github.com/apache/incubator-paimon/issues/747

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/incubator-paimon/issues) and found nothing similar.
   
   
   ### Motivation
   
   Flink Catalog can support:
   listPartitions
   listPartitionsByFilter
   getPartition
   partitionExists
   dropPartition
   
   ### Solution
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] zhuangchong commented on issue #747: [Feature] Flink Catalog supports partition methods

Posted by "zhuangchong (via GitHub)" <gi...@apache.org>.

zhuangchong commented on issue #747:
URL: https://github.com/apache/incubator-paimon/issues/747#issuecomment-1660114244

   This pr has been done, I will close this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] liugddx commented on issue #747: [Feature] Flink Catalog supports partition methods

Posted by "liugddx (via GitHub)" <gi...@apache.org>.

liugddx commented on issue #747:
URL: https://github.com/apache/incubator-paimon/issues/747#issuecomment-1508274715

   https://github.com/apache/iceberg/pull/1815/files


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] ericxiao251 commented on issue #747: [Feature] Flink Catalog supports partition methods

Posted by "ericxiao251 (via GitHub)" <gi...@apache.org>.

ericxiao251 commented on issue #747:
URL: https://github.com/apache/incubator-paimon/issues/747#issuecomment-1504555569

   I did a bit of digging and I think we might want to leverage the `CatalogTable` class from `package org.apache.flink.table.catalog` to manage a table's partitions. But this class only tells you if the table is partitioned (`isPartitioned`) and what the partition keys are (`getPartitionKeys`). The reason why I think we could use the `CatalogTable` class is based on the other function in the `FlinkCatalog` that also depends on the `CatalogTable` class  ([`renameTable`](https://github.com/apache/incubator-paimon/blob/master/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/FlinkCatalog.java#L392-L404)).
   
   I think I am missing something - but it seems like we might need to add some partitions functionality to `CatalogTable` in the Flink project before we can implement any of the partition functions above in Paimon?
   
   @JingsongLi do you have any recommendations on how one would go about implementing these partition functions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] ericxiao251 commented on issue #747: [Feature] Flink Catalog supports partition methods

Posted by "ericxiao251 (via GitHub)" <gi...@apache.org>.

ericxiao251 commented on issue #747:
URL: https://github.com/apache/incubator-paimon/issues/747#issuecomment-1509193807

   👋🏼 thanks @liugddx and @JingsongLi for the direction! I wasn't able to leverage the `BinaryRow` class, but was able to use the `InternalRow` class.
   
   Would either of you have a chance to look at the initial implementation and let me know if I am on the right track? It looks like a lot more code than some of the examples both of you've listed, so i am not sure if I have overcomplicated anything. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] zhuangchong closed issue #747: [Feature] Flink Catalog supports partition methods

Posted by "zhuangchong (via GitHub)" <gi...@apache.org>.

zhuangchong closed issue #747: [Feature] Flink Catalog supports partition methods
URL: https://github.com/apache/incubator-paimon/issues/747


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] felixYyu commented on issue #747: [Feature] Flink Catalog supports partition methods

Posted by "felixYyu (via GitHub)" <gi...@apache.org>.

felixYyu commented on issue #747:
URL: https://github.com/apache/incubator-paimon/issues/747#issuecomment-1489726255

   I also want to finish it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] leaves12138 commented on issue #747: [Feature] Flink Catalog supports partition methods

Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.

leaves12138 commented on issue #747:
URL: https://github.com/apache/incubator-paimon/issues/747#issuecomment-1518969964

   We can realize listPartitions method and dropPartition method in Paimon Catalog


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] xuzhiwen1255 commented on issue #747: [Feature] Flink Catalog supports partition methods

Posted by "xuzhiwen1255 (via GitHub)" <gi...@apache.org>.

xuzhiwen1255 commented on issue #747:
URL: https://github.com/apache/incubator-paimon/issues/747#issuecomment-1487910427

   Hi, can you assign it to me?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] ericxiao251 commented on issue #747: [Feature] Flink Catalog supports partition methods

Posted by "ericxiao251 (via GitHub)" <gi...@apache.org>.

ericxiao251 commented on issue #747:
URL: https://github.com/apache/incubator-paimon/issues/747#issuecomment-1504472844

   Hi, I would like to work on this as well. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] JingsongLi commented on issue #747: [Feature] Flink Catalog supports partition methods

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.

JingsongLi commented on issue #747:
URL: https://github.com/apache/incubator-paimon/issues/747#issuecomment-1504896032

   Hi @ericxiao251 , we just need to implement functions in `FlinkCatalog`, for example, for `listPartitions`, it is similiar to `PartitionExpire.readPartitions`, here we need to convert `BinaryRow`s to `CatalogPartitionSpec`s. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org