You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2020/04/10 09:23:41 UTC
[kudu-CR] [metrics] make 'merged entities count of tablet' visible when only one entity merged
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15707
Change subject: [metrics] make 'merged_entities_count_of_tablet' visible when only one entity merged
......................................................................
[metrics] make 'merged_entities_count_of_tablet' visible when only one entity merged
Before this patch, the metric 'merged_entities_count_of_tablet' is hidden
when tablet server aggregate metrics by the same attribute and there is
only one entity merged, because it's modification epoch is not updated.
We should expose the metric in this condition.
Change-Id: Ia74cae25b5bde7d61db1186e44abdff487d3f23f
---
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/util/metrics.cc
2 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/15707/1
--
To view, visit http://gerrit.cloudera.org:8080/15707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia74cae25b5bde7d61db1186e44abdff487d3f23f
Gerrit-Change-Number: 15707
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
[kudu-CR] [metrics] make 'merged entities count of tablet' visible when only one entity merged
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15707 )
Change subject: [metrics] make 'merged_entities_count_of_tablet' visible when only one entity merged
......................................................................
[metrics] make 'merged_entities_count_of_tablet' visible when only one entity merged
Before this patch, the metric 'merged_entities_count_of_tablet' is hidden
when tablet server aggregate metrics by the same attribute and there is
only one entity merged, because it's modification epoch is not updated.
We should expose the metric in this condition.
Change-Id: Ia74cae25b5bde7d61db1186e44abdff487d3f23f
Reviewed-on: http://gerrit.cloudera.org:8080/15707
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/util/metrics.cc
2 files changed, 16 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia74cae25b5bde7d61db1186e44abdff487d3f23f
Gerrit-Change-Number: 15707
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [metrics] make 'merged entities count of tablet' visible when only one entity merged
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15707 )
Change subject: [metrics] make 'merged_entities_count_of_tablet' visible when only one entity merged
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia74cae25b5bde7d61db1186e44abdff487d3f23f
Gerrit-Change-Number: 15707
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 17 Apr 2020 19:46:03 +0000
Gerrit-HasComments: No
[kudu-CR] [metrics] make 'merged entities count of tablet' visible when only one entity merged
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15707 )
Change subject: [metrics] make 'merged_entities_count_of_tablet' visible when only one entity merged
......................................................................
Patch Set 1:
Thank you for the fix!
--
To view, visit http://gerrit.cloudera.org:8080/15707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia74cae25b5bde7d61db1186e44abdff487d3f23f
Gerrit-Change-Number: 15707
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 17 Apr 2020 19:46:19 +0000
Gerrit-HasComments: No