You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/09/15 19:38:30 UTC
[GitHub] [cloudstack] mlsorensen opened a new pull request, #6742: Ignore calls to PowerFlex for host revocation when host is null
mlsorensen opened a new pull request, #6742:
URL: https://github.com/apache/cloudstack/pull/6742
Signed-off-by: Marcus Sorensen <ml...@apple.com>
### Description
This PR Fixes #6739 (for PowerFlex/ScaleIO only, Datera still needs to be addressed), which can occur if the last host the VM ran on is deleted from CloudStack. At the point the VM is deleted, cloudstack attempts to make a final call to revoke access to volumes, passing the last host the VM ran on. If this host is gone, we get an error and are unable to delete the VM.
It's possible that there may be a more holistic fix to this by identifying all of the places where `revokeAccess()` is called and checking for null host. It's possible other storage plugins don't even need host information to revoke access to volumes and may need this call to revoke. Therefore I'm only applying this fix to the ScaleIOPrimaryDataStoreDriver to skip revoking access when there is no host to revoke access for, and this should protect us as well when a new part of the code tries to use `revokeAccess()` in the future.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Tested in a local branch against PowerFlex primary storage, and with internal testing environments. Repeated steps outlined in #6739. We also had quite a few VMs that would not delete before this change was put into place, which cleaned up successfully afterward.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6742: Ignore calls to PowerFlex for host revocation when host is null
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6742:
URL: https://github.com/apache/cloudstack/pull/6742#issuecomment-1271404550
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6742: Ignore calls to PowerFlex for host revocation when host is null
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6742:
URL: https://github.com/apache/cloudstack/pull/6742#issuecomment-1271130127
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6742: Ignore calls to PowerFlex for host revocation when host is null
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6742:
URL: https://github.com/apache/cloudstack/pull/6742#issuecomment-1260517866
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #6742: Ignore calls to PowerFlex for host revocation when host is null
Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged PR #6742:
URL: https://github.com/apache/cloudstack/pull/6742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6742: Ignore calls to PowerFlex for host revocation when host is null
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6742:
URL: https://github.com/apache/cloudstack/pull/6742#issuecomment-1271339519
<b>Trillian Build Failed (tid-5079)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6742: Ignore calls to PowerFlex for host revocation when host is null
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6742:
URL: https://github.com/apache/cloudstack/pull/6742#issuecomment-1260593727
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6742: Ignore calls to PowerFlex for host revocation when host is null
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6742:
URL: https://github.com/apache/cloudstack/pull/6742#issuecomment-1271326343
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6742: Ignore calls to PowerFlex for host revocation when host is null
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6742:
URL: https://github.com/apache/cloudstack/pull/6742#discussion_r982399530
##########
plugins/storage/volume/scaleio/src/main/java/org/apache/cloudstack/storage/datastore/driver/ScaleIOPrimaryDataStoreDriver.java:
##########
@@ -189,6 +189,11 @@ public boolean grantAccess(DataObject dataObject, Host host, DataStore dataStore
@Override
public void revokeAccess(DataObject dataObject, Host host, DataStore dataStore) {
+ if (host == null) {
+ LOGGER.warn("Declining to revoke access to PowerFlex volume when a host is not provided");
Review Comment:
could be `info`, right? or is this indicative of a possible (user) error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6742: Ignore calls to PowerFlex for host revocation when host is null
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6742:
URL: https://github.com/apache/cloudstack/pull/6742#issuecomment-1271403761
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6742: Ignore calls to PowerFlex for host revocation when host is null
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6742:
URL: https://github.com/apache/cloudstack/pull/6742#issuecomment-1262582220
<b>Trillian test result (tid-5039)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40692 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6742-t5039-kvm-centos7.zip
Smoke tests completed. 102 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 671.36 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6742: Ignore calls to PowerFlex for host revocation when host is null
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6742:
URL: https://github.com/apache/cloudstack/pull/6742#issuecomment-1261793559
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6742: Ignore calls to PowerFlex for host revocation when host is null
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6742:
URL: https://github.com/apache/cloudstack/pull/6742#issuecomment-1271319251
<b>Trillian Build Failed (tid-5078)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6742: Ignore calls to PowerFlex for host revocation when host is null
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6742:
URL: https://github.com/apache/cloudstack/pull/6742#issuecomment-1272150760
<b>Trillian test result (tid-5080)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45093 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6742-t5080-kvm-centos7.zip
Smoke tests completed. 103 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 466.35 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6742: Ignore calls to PowerFlex for host revocation when host is null
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6742:
URL: https://github.com/apache/cloudstack/pull/6742#issuecomment-1248583749
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6742?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6742](https://codecov.io/gh/apache/cloudstack/pull/6742?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f126dd9) into [main](https://codecov.io/gh/apache/cloudstack/commit/bf4e9059dd67ee94904ef4932369c225f16b08b4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf4e905) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #6742 +/- ##
============================================
- Coverage 10.41% 10.41% -0.01%
+ Complexity 6694 6692 -2
============================================
Files 2455 2455
Lines 243141 243144 +3
Branches 38062 38063 +1
============================================
- Hits 25335 25331 -4
- Misses 214636 214645 +9
+ Partials 3170 3168 -2
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...atastore/driver/ScaleIOPrimaryDataStoreDriver.java](https://codecov.io/gh/apache/cloudstack/pull/6742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9zdG9yYWdlL3ZvbHVtZS9zY2FsZWlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N0b3JhZ2UvZGF0YXN0b3JlL2RyaXZlci9TY2FsZUlPUHJpbWFyeURhdGFTdG9yZURyaXZlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/6742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `21.15% <0.00%> (-7.70%)` | :arrow_down: |
| [...om/cloud/hypervisor/kvm/resource/LibvirtVMDef.java](https://codecov.io/gh/apache/cloudstack/pull/6742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydFZNRGVmLmphdmE=) | `62.60% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6742: Ignore calls to PowerFlex for host revocation when host is null
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6742:
URL: https://github.com/apache/cloudstack/pull/6742#issuecomment-1260518291
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6742: Ignore calls to PowerFlex for host revocation when host is null
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6742:
URL: https://github.com/apache/cloudstack/pull/6742#issuecomment-1271162043
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6742: Ignore calls to PowerFlex for host revocation when host is null
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6742:
URL: https://github.com/apache/cloudstack/pull/6742#issuecomment-1271327088
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6742: Ignore calls to PowerFlex for host revocation when host is null
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6742:
URL: https://github.com/apache/cloudstack/pull/6742#issuecomment-1261793824
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6742: Ignore calls to PowerFlex for host revocation when host is null
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6742:
URL: https://github.com/apache/cloudstack/pull/6742#issuecomment-1271130535
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6742: Ignore calls to PowerFlex for host revocation when host is null
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6742:
URL: https://github.com/apache/cloudstack/pull/6742#issuecomment-1271307936
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6742: Ignore calls to PowerFlex for host revocation when host is null
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6742:
URL: https://github.com/apache/cloudstack/pull/6742#issuecomment-1271307545
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org