You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "yesamer (via GitHub)" <gi...@apache.org> on 2026/04/14 07:57:31 UTC
[PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
yesamer opened a new pull request, #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538
Fixes: https://github.com/apache/incubator-kie-issues/issues/2029
Depends on:
https://github.com/apache/incubator-kie-drools/pull/6633
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4241
https://github.com/apache/incubator-kie-kogito-apps/pull/2317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3078378663
##########
repo/MANUAL.md:
##########
@@ -226,6 +226,28 @@ All Maven-based packages should declare it as a `dependency` on their `package.j
</parent>
```
+In case of Maven-based modules based on Quarkus, the following parent should be used:
+
+```xml
+<parent>
+ <groupId>org.kie</groupId>
+ <artifactId>kie-tools-maven-quarkus-bom</artifactId>
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3085420800
##########
packages/maven-quarkus-bom/package.json:
##########
@@ -0,0 +1,39 @@
+{
+ "private": true,
+ "name": "@kie-tools/maven-quarkus-bom",
Review Comment:
@tiagobento That means, the current status is right, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3080235147
##########
packages/maven-quarkus-bom/pom.xml:
##########
@@ -0,0 +1,66 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+<project
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"
+ xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+>
+ <parent>
+ <groupId>org.kie</groupId>
+ <artifactId>kie-tools-maven-base</artifactId>
+ <version>${revision}</version>
+ <relativePath>../maven-base/pom.xml</relativePath>
+ </parent>
+
+ <modelVersion>4.0.0</modelVersion>
+ <artifactId>kie-tools-quarkus-bom</artifactId>
+ <packaging>pom</packaging>
+
+ <name>KIE Tools :: Quarkus BOM</name>
+ <description>Bill of Materials for KIE Tools Quarkus-based projects</description>
+
+ <properties>
+ <version.io.quarkus>3.27.2</version.io.quarkus>
Review Comment:
We can remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3078069398
##########
packages/maven-quarkus-bom/package.json:
##########
@@ -0,0 +1,39 @@
+{
+ "private": true,
+ "name": "@kie-tools/maven-quarkus-bom",
Review Comment:
I would suggest to keep the name of the folder and the name of the artifacts consistent, to make things easier to maintain (it is also a sort of good-rule in the maven world, even if optional)
##########
examples/process-accelerator/pom.xml:
##########
@@ -25,9 +25,9 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.kie</groupId>
- <artifactId>kie-tools-maven-base</artifactId>
+ <artifactId>kie-tools-quarkus-bom</artifactId>
Review Comment:
Here the parent artifact is `kie-tools-quarkus-bom` , but elsewhere it is `kie-tools-maven-quarkus-bom`; I think they should be the same; beside, if there is one single name to identify the same object (the artifactId and the folder) things would be easier to follow, IMO
##########
examples/process-business-calendar/pom.xml:
##########
@@ -27,9 +27,9 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.kie</groupId>
- <artifactId>kie-tools-maven-base</artifactId>
+ <artifactId>kie-tools-maven-quarkus-bom</artifactId>
Review Comment:
Here the parent artifact is `kie-tools-maven-quarkus-bom `, but elsewhere it is `kie-tools-quarkus-bom`; I think they should be the same (`kie-tools-quarkus-bom`)
##########
repo/MANUAL.md:
##########
@@ -226,6 +226,28 @@ All Maven-based packages should declare it as a `dependency` on their `package.j
</parent>
```
+In case of Maven-based modules based on Quarkus, the following parent should be used:
+
+```xml
+<parent>
+ <groupId>org.kie</groupId>
+ <artifactId>kie-tools-maven-quarkus-bom</artifactId>
Review Comment:
IINW, this should be kie-tools-quarkus-bom
##########
packages/maven-quarkus-bom/pom.xml:
##########
@@ -0,0 +1,66 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+<project
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"
+ xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+>
+ <parent>
+ <groupId>org.kie</groupId>
+ <artifactId>kie-tools-maven-base</artifactId>
+ <version>${revision}</version>
+ <relativePath>../maven-base/pom.xml</relativePath>
+ </parent>
+
+ <modelVersion>4.0.0</modelVersion>
+ <artifactId>kie-tools-quarkus-bom</artifactId>
+ <packaging>pom</packaging>
+
+ <name>KIE Tools :: Quarkus BOM</name>
+ <description>Bill of Materials for KIE Tools Quarkus-based projects</description>
+
+ <properties>
+ <version.io.quarkus>3.27.2</version.io.quarkus>
Review Comment:
🤔 I do not really like it, TBH....
I've the impression it is better to set `kogito-apps-quarkus-bom` so that:
1. we do not need to keep the version in sync all over different repos
2. we automatically inherit the plugin configuration
Then, kie-tools-maven-base could be imported; importing it, would require to duplicate some properties or configuration, but maybe the burden to maintain such duplication in the same repo is easier.
##########
packages/maven-base/pom.xml:
##########
@@ -122,27 +122,15 @@
<version.maven.surefire.plugin>3.5.0</version.maven.surefire.plugin>
<!-- Apache KIE -->
- <version.org.kie.kogito>999-20260324-local</version.org.kie.kogito>
-
- <!-- Quarkus -->
- <version.quarkus>3.27.2</version.quarkus>
+ <version.org.kie.kogito>999-20260414-local</version.org.kie.kogito>
<!-- 3rd party dependencies -->
- <version.junit>4.13.2</version.junit>
- <version.org.apache.commons.commons-compress>1.28.0</version.org.apache.commons.commons-compress>
<version.org.iq80.snappy>0.5</version.org.iq80.snappy>
<version.org.apache.mime4j>0.8.12</version.org.apache.mime4j>
- <version.org.freemarker>2.3.34</version.org.freemarker>
- <version.org.assertj>3.27.7</version.org.assertj>
- <version.org.junit.jupiter>5.13.4</version.org.junit.jupiter>
- <version.org.mockito>5.18.0</version.org.mockito>
<version.org.kie.j2cl.tools.yaml.mapper>0.4</version.org.kie.j2cl.tools.yaml.mapper>
- <version.io.netty>4.1.131.Final</version.io.netty>
<!-- These versions are overrides for transitive dependencies, to fix security vulnerabilities.
They need to be checked with Quarkus and Spring Boot upgrades and eventually removed, if they are not needed anymore. -->
- <version.tomcat.embed.core>10.1.54</version.tomcat.embed.core>
- <version.apache.commons.lang3>3.18.0</version.apache.commons.lang3>
<version.angus.mail>2.0.5</version.angus.mail>
Review Comment:
This is already defined in kie-parent, so it should be inherited
##########
packages/kogito-jobs-service-postgresql-image/resources/app/pom.xml:
##########
@@ -25,7 +25,7 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.kie</groupId>
- <artifactId>kie-tools-maven-base</artifactId>
+ <artifactId>kie-tools-quarkus-bom</artifactId>
<version>${revision}</version>
<relativePath>../../node_modules/@kie-tools/maven-base/pom.xml</relativePath>
Review Comment:
RelativePath to be updated
##########
packages/maven-base/pom.xml:
##########
Review Comment:
This is already defined in kie-parent, so it should be inherited
##########
packages/maven-quarkus-bom/maven-quarkus-bom.iml:
##########
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<module version="4">
Review Comment:
IINW, IDE specific files should not be versioned
##########
repo/MANUAL.md:
##########
@@ -226,6 +226,28 @@ All Maven-based packages should declare it as a `dependency` on their `package.j
</parent>
```
+In case of Maven-based modules based on Quarkus, the following parent should be used:
+
+```xml
+<parent>
+ <groupId>org.kie</groupId>
+ <artifactId>kie-tools-maven-quarkus-bom</artifactId>
+ <version>${revision}</version>
+ <relativePath>./node_modules/@kie-tools/maven-quarkus-bom/pom.xml</relativePath>
+</parent>
+```
+
+In case of Maven-based modules based on Spring Boot, the following parent should be used:
+
+```xml
+<parent>
+ <groupId>org.kie</groupId>
+ <artifactId>kie-tools-maven-spring-boot-bom</artifactId>
Review Comment:
IINW, this should be kie-tools-spring-boot-bom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3078378460
##########
repo/MANUAL.md:
##########
@@ -226,6 +226,28 @@ All Maven-based packages should declare it as a `dependency` on their `package.j
</parent>
```
+In case of Maven-based modules based on Quarkus, the following parent should be used:
+
+```xml
+<parent>
+ <groupId>org.kie</groupId>
+ <artifactId>kie-tools-maven-quarkus-bom</artifactId>
+ <version>${revision}</version>
+ <relativePath>./node_modules/@kie-tools/maven-quarkus-bom/pom.xml</relativePath>
+</parent>
+```
+
+In case of Maven-based modules based on Spring Boot, the following parent should be used:
+
+```xml
+<parent>
+ <groupId>org.kie</groupId>
+ <artifactId>kie-tools-maven-spring-boot-bom</artifactId>
Review Comment:
Fixed.
##########
repo/MANUAL.md:
##########
@@ -226,6 +226,28 @@ All Maven-based packages should declare it as a `dependency` on their `package.j
</parent>
```
+In case of Maven-based modules based on Quarkus, the following parent should be used:
+
+```xml
+<parent>
+ <groupId>org.kie</groupId>
+ <artifactId>kie-tools-maven-quarkus-bom</artifactId>
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3080659836
##########
packages/jbpm-quarkus-devui/jbpm-quarkus-devui-runtime/pom.xml:
##########
@@ -141,7 +141,6 @@
<plugin>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-extension-maven-plugin</artifactId>
- <version>${version.quarkus}</version>
Review Comment:
This will make it default to the latest version, if I'm not mistaken
##########
packages/maven-quarkus-bom/package.json:
##########
@@ -0,0 +1,39 @@
+{
+ "private": true,
+ "name": "@kie-tools/maven-quarkus-bom",
Review Comment:
Let's follow whatever `maven-base` used to do.
##########
packages/maven-base/pom.xml:
##########
@@ -122,94 +122,25 @@
<version.maven.surefire.plugin>3.5.0</version.maven.surefire.plugin>
<!-- Apache KIE -->
- <version.org.kie.kogito>999-20260324-local</version.org.kie.kogito>
-
- <!-- Quarkus -->
- <version.quarkus>3.27.2</version.quarkus>
+ <version.org.kie.kogito>999-20260414-local</version.org.kie.kogito>
<!-- 3rd party dependencies -->
- <version.junit>4.13.2</version.junit>
- <version.org.apache.commons.commons-compress>1.28.0</version.org.apache.commons.commons-compress>
<version.org.iq80.snappy>0.5</version.org.iq80.snappy>
<version.org.apache.mime4j>0.8.12</version.org.apache.mime4j>
- <version.org.freemarker>2.3.34</version.org.freemarker>
- <version.org.assertj>3.27.7</version.org.assertj>
- <version.org.junit.jupiter>5.13.4</version.org.junit.jupiter>
- <version.org.mockito>5.18.0</version.org.mockito>
<version.org.kie.j2cl.tools.yaml.mapper>0.4</version.org.kie.j2cl.tools.yaml.mapper>
- <version.io.netty>4.1.131.Final</version.io.netty>
-
- <!-- These versions are overrides for transitive dependencies, to fix security vulnerabilities.
- They need to be checked with Quarkus and Spring Boot upgrades and eventually removed, if they are not needed anymore. -->
- <version.tomcat.embed.core>10.1.54</version.tomcat.embed.core>
- <version.apache.commons.lang3>3.18.0</version.apache.commons.lang3>
- <version.angus.mail>2.0.5</version.angus.mail>
Review Comment:
Why do we need to remove all those dependencies from here? Are they tightly coupled with Quarkus or Spring Boot?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3078384823
##########
packages/maven-quarkus-bom/maven-quarkus-bom.iml:
##########
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<module version="4">
Review Comment:
maven-base and other maven modules have it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg merged PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3078949435
##########
packages/kogito-jobs-service-postgresql-image/resources/app/pom.xml:
##########
@@ -25,7 +25,7 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.kie</groupId>
- <artifactId>kie-tools-maven-base</artifactId>
+ <artifactId>kie-tools-quarkus-bom</artifactId>
<version>${revision}</version>
<relativePath>../../node_modules/@kie-tools/maven-base/pom.xml</relativePath>
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3078384823
##########
packages/maven-quarkus-bom/maven-quarkus-bom.iml:
##########
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<module version="4">
Review Comment:
maven-base and other maven repos have it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3079753379
##########
packages/maven-quarkus-bom/package.json:
##########
@@ -0,0 +1,39 @@
+{
+ "private": true,
+ "name": "@kie-tools/maven-quarkus-bom",
Review Comment:
@thiagoelg Well, my point was to have the same name on folder and artifact, it is a good rule in maven world for good reason. I'm not sure why the name ->must<- be different, if I infer correctly from your answer. But if this is the case, I've no strong opinion on the name of the folder, since it is extremely "internal"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3080662901
##########
packages/jbpm-quarkus-devui/package.json:
##########
@@ -30,9 +30,10 @@
"start:win32": "pnpm build:dev && mvn -f ./dev/pom.xml clean quarkus:dev -Dquarkus.http.host=127.0.0.1 -Dkogito.service.url=http://127.0.0.1:8080/kie -Dkogito.jobs-service.url=http://127.0.0.1:8080/kie -Dkogito.data-index.urll=http://127.0.0.1:8080/kie"
},
"dependencies": {
- "@kie-tools/maven-base": "workspace:*"
+ "@kie-tools/maven-quarkus-bom": "workspace:*"
},
"devDependencies": {
+ "@kie-tools/maven-base": "workspace:*",
Review Comment:
Please keep `maven-base` as a "dependency" instead of a "devDependency" the Maven repo tail mechanism depends on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3079828477
##########
packages/maven-quarkus-bom/pom.xml:
##########
@@ -0,0 +1,66 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+<project
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"
+ xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+>
+ <parent>
+ <groupId>org.kie</groupId>
+ <artifactId>kie-tools-maven-base</artifactId>
+ <version>${revision}</version>
+ <relativePath>../maven-base/pom.xml</relativePath>
+ </parent>
+
+ <modelVersion>4.0.0</modelVersion>
+ <artifactId>kie-tools-quarkus-bom</artifactId>
+ <packaging>pom</packaging>
+
+ <name>KIE Tools :: Quarkus BOM</name>
+ <description>Bill of Materials for KIE Tools Quarkus-based projects</description>
+
+ <properties>
+ <version.io.quarkus>3.27.2</version.io.quarkus>
Review Comment:
kie-tools should follow the same Quarkus version from the upstream repositories.
The `QUARKUS_PLATFORM_version` env var is used in other places as well, not just POMs (some container images and Sonataflow packages), so we can't just straight remove it. Ideally, the default value of `QUARKUS_PLATFORM_version` should come from the `kogito-apps-bom` built by the `drools-and-kogito` package automatically; this way, it's always in sync.
I'm not sure how to programmatically retrieve a property from a POM, but if it's possible, that would be nice. Otherwise, we can maintain the `QUARKUS_PLATFORM_version` value manually for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3080183662
##########
packages/maven-quarkus-bom/pom.xml:
##########
@@ -0,0 +1,66 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+<project
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"
+ xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+>
+ <parent>
+ <groupId>org.kie</groupId>
+ <artifactId>kie-tools-maven-base</artifactId>
+ <version>${revision}</version>
+ <relativePath>../maven-base/pom.xml</relativePath>
+ </parent>
+
+ <modelVersion>4.0.0</modelVersion>
+ <artifactId>kie-tools-quarkus-bom</artifactId>
+ <packaging>pom</packaging>
+
+ <name>KIE Tools :: Quarkus BOM</name>
+ <description>Bill of Materials for KIE Tools Quarkus-based projects</description>
+
+ <properties>
+ <version.io.quarkus>3.27.2</version.io.quarkus>
Review Comment:
@thiagoelg Can you please then clarify if that highlighted property is then required or we can remove that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3281913026
##########
examples/process-accelerator/pom.xml:
##########
@@ -25,9 +25,9 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.kie</groupId>
- <artifactId>kie-tools-maven-base</artifactId>
+ <artifactId>kie-tools-quarkus-bom</artifactId>
Review Comment:
I don't think we need the `maven` prefix in the package name. Having it implies that there's also a non-Maven BOM.
To me, naming the artifacts `kie-tools-quarkus-bom` and `kie-tools-spring-boot-bom` works, and then naming the packages `quarkus-bom` and `spring-boot-bom`, since `kie-tools` is already implied.
I'm not against having the folder named the same as the artifactId, but that's not the standard in the repository right now, and it would look out of place. In the future, we can investigate whether it makes sense to do so and then update all packages that apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3079711043
##########
packages/maven-quarkus-bom/package.json:
##########
@@ -0,0 +1,39 @@
+{
+ "private": true,
+ "name": "@kie-tools/maven-quarkus-bom",
Review Comment:
Right now we have:
- Package directory: `maven-quarkus-bom`
- Package name: `@kie-tools/maven-quarkus-bom`
- Artifact name: `kie-tools-quarkus-bom`
Is that correct?
I agree that using different names might be confusing, but naming the package `@kie-tools/kie-tools-quarkus-bom` doesn't sound good either.
Maybe this is better?
- Package directory: `quarkus-bom`
- Package name: `@kie-tools/quarkus-bom`
- Artifact name: `kie-tools-quarkus-bom`
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3078937272
##########
packages/maven-base/pom.xml:
##########
Review Comment:
Removed.
##########
packages/maven-base/pom.xml:
##########
@@ -122,27 +122,15 @@
<version.maven.surefire.plugin>3.5.0</version.maven.surefire.plugin>
<!-- Apache KIE -->
- <version.org.kie.kogito>999-20260324-local</version.org.kie.kogito>
-
- <!-- Quarkus -->
- <version.quarkus>3.27.2</version.quarkus>
+ <version.org.kie.kogito>999-20260414-local</version.org.kie.kogito>
<!-- 3rd party dependencies -->
- <version.junit>4.13.2</version.junit>
- <version.org.apache.commons.commons-compress>1.28.0</version.org.apache.commons.commons-compress>
<version.org.iq80.snappy>0.5</version.org.iq80.snappy>
<version.org.apache.mime4j>0.8.12</version.org.apache.mime4j>
- <version.org.freemarker>2.3.34</version.org.freemarker>
- <version.org.assertj>3.27.7</version.org.assertj>
- <version.org.junit.jupiter>5.13.4</version.org.junit.jupiter>
- <version.org.mockito>5.18.0</version.org.mockito>
<version.org.kie.j2cl.tools.yaml.mapper>0.4</version.org.kie.j2cl.tools.yaml.mapper>
- <version.io.netty>4.1.131.Final</version.io.netty>
<!-- These versions are overrides for transitive dependencies, to fix security vulnerabilities.
They need to be checked with Quarkus and Spring Boot upgrades and eventually removed, if they are not needed anymore. -->
- <version.tomcat.embed.core>10.1.54</version.tomcat.embed.core>
- <version.apache.commons.lang3>3.18.0</version.apache.commons.lang3>
<version.angus.mail>2.0.5</version.angus.mail>
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3079756719
##########
packages/maven-quarkus-bom/pom.xml:
##########
@@ -0,0 +1,66 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+<project
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"
+ xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+>
+ <parent>
+ <groupId>org.kie</groupId>
+ <artifactId>kie-tools-maven-base</artifactId>
+ <version>${revision}</version>
+ <relativePath>../maven-base/pom.xml</relativePath>
+ </parent>
+
+ <modelVersion>4.0.0</modelVersion>
+ <artifactId>kie-tools-quarkus-bom</artifactId>
+ <packaging>pom</packaging>
+
+ <name>KIE Tools :: Quarkus BOM</name>
+ <description>Bill of Materials for KIE Tools Quarkus-based projects</description>
+
+ <properties>
+ <version.io.quarkus>3.27.2</version.io.quarkus>
Review Comment:
@gitgabrio The reason for this choice is that I’m aware the kie-tools monorepo provides a global parameter to manage the Quarkus version (QUARKUS_PLATFORM_version).
@thiagoelg, we need your input here. Do we need to explicitly declare the Quarkus version so that it is managed by the kie-tools monorepo via QUARKUS_PLATFORM_version, or can we fully delegate version management to kogito-apps-quarkus-bom, as @gitgabrio is suggesting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3084864282
##########
packages/jbpm-quarkus-devui/jbpm-quarkus-devui-runtime/pom.xml:
##########
@@ -141,7 +141,6 @@
<plugin>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-extension-maven-plugin</artifactId>
- <version>${version.quarkus}</version>
Review Comment:
@tiagobento I double-checked:
`kie-tools-quarkus-bom`
|
`jbpm-quarkus-devui-parent`
|
`jbpm-quarkus-devui`
In `kie-tools-quarkus-bom`, the `quarkus-extension-maven-plugin` is declared.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3079676629
##########
packages/maven-quarkus-bom/package.json:
##########
@@ -0,0 +1,39 @@
+{
+ "private": true,
+ "name": "@kie-tools/maven-quarkus-bom",
Review Comment:
@gitgabrio I used this naming just to be consistent with the existing maven-base approach. I'm fine with your suggestion, but I'd ask @thiagoelg what is his input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3079680750
##########
examples/process-accelerator/pom.xml:
##########
@@ -25,9 +25,9 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.kie</groupId>
- <artifactId>kie-tools-maven-base</artifactId>
+ <artifactId>kie-tools-quarkus-bom</artifactId>
Review Comment:
@gitgabrio Related to the previous comment //cc @thiagoelg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3085439148
##########
packages/maven-quarkus-bom/pom.xml:
##########
@@ -0,0 +1,66 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+<project
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"
+ xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+>
+ <parent>
+ <groupId>org.kie</groupId>
+ <artifactId>kie-tools-maven-base</artifactId>
+ <version>${revision}</version>
+ <relativePath>../maven-base/pom.xml</relativePath>
+ </parent>
+
+ <modelVersion>4.0.0</modelVersion>
+ <artifactId>kie-tools-quarkus-bom</artifactId>
+ <packaging>pom</packaging>
+
+ <name>KIE Tools :: Quarkus BOM</name>
+ <description>Bill of Materials for KIE Tools Quarkus-based projects</description>
+
+ <properties>
+ <version.io.quarkus>3.27.2</version.io.quarkus>
Review Comment:
After trying it out with @gitgabrio, we confirmed that it is not possible to use kogito-apps-quarkus-bom as a parent with the current setup. This is due to Maven’s version replacement mechanism, which ends up using the project.version defined in the leaf POM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3085655631
##########
packages/maven-base/pom.xml:
##########
@@ -122,94 +122,25 @@
<version.maven.surefire.plugin>3.5.0</version.maven.surefire.plugin>
<!-- Apache KIE -->
- <version.org.kie.kogito>999-20260324-local</version.org.kie.kogito>
-
- <!-- Quarkus -->
- <version.quarkus>3.27.2</version.quarkus>
+ <version.org.kie.kogito>999-20260414-local</version.org.kie.kogito>
<!-- 3rd party dependencies -->
- <version.junit>4.13.2</version.junit>
- <version.org.apache.commons.commons-compress>1.28.0</version.org.apache.commons.commons-compress>
<version.org.iq80.snappy>0.5</version.org.iq80.snappy>
<version.org.apache.mime4j>0.8.12</version.org.apache.mime4j>
- <version.org.freemarker>2.3.34</version.org.freemarker>
- <version.org.assertj>3.27.7</version.org.assertj>
- <version.org.junit.jupiter>5.13.4</version.org.junit.jupiter>
- <version.org.mockito>5.18.0</version.org.mockito>
<version.org.kie.j2cl.tools.yaml.mapper>0.4</version.org.kie.j2cl.tools.yaml.mapper>
- <version.io.netty>4.1.131.Final</version.io.netty>
-
- <!-- These versions are overrides for transitive dependencies, to fix security vulnerabilities.
- They need to be checked with Quarkus and Spring Boot upgrades and eventually removed, if they are not needed anymore. -->
- <version.tomcat.embed.core>10.1.54</version.tomcat.embed.core>
- <version.apache.commons.lang3>3.18.0</version.apache.commons.lang3>
- <version.angus.mail>2.0.5</version.angus.mail>
Review Comment:
@tiagobento The dependencies you mentioned are already pulled in transitively via the <artifactId>kogito-apps-bom</artifactId> imported at line 138, which was already present before this PR. Since these dependencies are duplicated, we can safely remove them and rely on the single declaration provided by kie-parent.
These are framework-agnostic dependencies, including some that are used only for testing, so no additional imports are required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3084864282
##########
packages/jbpm-quarkus-devui/jbpm-quarkus-devui-runtime/pom.xml:
##########
@@ -141,7 +141,6 @@
<plugin>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-extension-maven-plugin</artifactId>
- <version>${version.quarkus}</version>
Review Comment:
@tiagobento I double-checked:
`kie-tools-quarkus-bom`
|
`jbpm-quarkus-devui-parent`
|
`jbpm-quarkus-devui`
In `kie-tools-quarkus-bom`, the `quarkus-extension-maven-plugin` is declared.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3085440840
##########
packages/jbpm-quarkus-devui/package.json:
##########
@@ -30,9 +30,10 @@
"start:win32": "pnpm build:dev && mvn -f ./dev/pom.xml clean quarkus:dev -Dquarkus.http.host=127.0.0.1 -Dkogito.service.url=http://127.0.0.1:8080/kie -Dkogito.jobs-service.url=http://127.0.0.1:8080/kie -Dkogito.data-index.urll=http://127.0.0.1:8080/kie"
},
"dependencies": {
- "@kie-tools/maven-base": "workspace:*"
+ "@kie-tools/maven-quarkus-bom": "workspace:*"
},
"devDependencies": {
+ "@kie-tools/maven-base": "workspace:*",
Review Comment:
@tiagobento Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3078381374
##########
repo/MANUAL.md:
##########
@@ -226,6 +226,28 @@ All Maven-based packages should declare it as a `dependency` on their `package.j
</parent>
```
+In case of Maven-based modules based on Quarkus, the following parent should be used:
+
+```xml
+<parent>
+ <groupId>org.kie</groupId>
+ <artifactId>kie-tools-maven-quarkus-bom</artifactId>
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-tools]
Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #3538:
URL: https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3080016189
##########
packages/maven-quarkus-bom/pom.xml:
##########
@@ -0,0 +1,66 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+<project
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"
+ xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+>
+ <parent>
+ <groupId>org.kie</groupId>
+ <artifactId>kie-tools-maven-base</artifactId>
+ <version>${revision}</version>
+ <relativePath>../maven-base/pom.xml</relativePath>
+ </parent>
+
+ <modelVersion>4.0.0</modelVersion>
+ <artifactId>kie-tools-quarkus-bom</artifactId>
+ <packaging>pom</packaging>
+
+ <name>KIE Tools :: Quarkus BOM</name>
+ <description>Bill of Materials for KIE Tools Quarkus-based projects</description>
+
+ <properties>
+ <version.io.quarkus>3.27.2</version.io.quarkus>
Review Comment:
@thiagoelg @yesamer
`mvn help:evaluate -Dexpression=<property-name> -q -DforceStdout`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org