You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/03/29 11:36:11 UTC

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1036: MINIFICPP-1352 Fix warnings in JNI and Sensors extensions

lordgamez commented on a change in pull request #1036:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1036#discussion_r603220302



##########
File path: extensions/jni/jvm/JniReferenceObjects.h
##########
@@ -142,7 +142,7 @@ class JniByteInputStream : public minifi::InputStreamCallback {
     int read = 0;
     do {
 
-      int actual = (int) stream_->read(buffer_, remaining <= buffer_size_ ? remaining : buffer_size_);
+      int actual = (int) stream_->read(buffer_, gsl::narrow<uint64_t>(remaining) <= buffer_size_ ? remaining : buffer_size_);

Review comment:
       Updated in 613f8fe1683ee5ffcd5c0db8a67f7deddaa19ef8




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org