You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2023/01/11 16:43:30 UTC

[GitHub] [calcite] tanclary commented on a diff in pull request #3008: [CALCITE-5436] Implement DATE_SUB, TIME_SUB, TIMESTAMP_SUB (compatible w/ BigQuery)

tanclary commented on code in PR #3008:
URL: https://github.com/apache/calcite/pull/3008#discussion_r1067221618


##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -700,6 +727,14 @@ private SqlLibraryOperators() {
           ReturnTypes.TIMESTAMP_NULLABLE, OperandTypes.INTEGER,
           SqlFunctionCategory.TIMEDATE);
 
+  /** 2-argument form of the special minus-date operator

Review Comment:
   I parameterized the return-type inference because the standard MINUS_DATE operator has three arguments, and the return type is specified as ARG2. This is incompatible with BigQuery because there are only two arguments (the time/date/timestamp expression, and the interval being subtracted).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org