You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by Vivek Ratnavel Subramanian <vi...@gmail.com> on 2015/08/01 00:10:17 UTC

Re: Review Request 36806: Enabling full screen for ambari views iframe

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36806/
-----------------------------------------------------------

(Updated July 31, 2015, 10:10 p.m.)


Review request for Ambari, Jaimin Jetly and Yusaku Sako.


Bugs: AMBARI-12542
    https://issues.apache.org/jira/browse/AMBARI-12542


Repository: ambari


Description
-------

The "allowfullscreen" attribute of iframe needs to be set to "true" for the components in the iframe to toggle full screen. The "iframe" tag used in ambari-web to display different views does not have this attribute enabled. This is required for the visualization component of hive views to toggle full screen.


Diffs
-----

  ambari-web/app/views/main/views/details.js e90cb20 

Diff: https://reviews.apache.org/r/36806/diff/


Testing (updated)
-------

Tested end to end with Hive View and new Data Visualization feature being worked on via AMBARI-12615.

Existing Ambari Web unit tests pass.

[92m [0m[32m 6478 tests complete[0m[90m (10 seconds)[0m
[36m [0m[36m 94 tests pending[0m

[INFO] 
[INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: .idea/**
[INFO] Exclude: package.json
[INFO] Exclude: public/**
[INFO] Exclude: public-static/**
[INFO] Exclude: app/assets/**
[INFO] Exclude: vendor/**
[INFO] Exclude: node_modules/**
[INFO] Exclude: node/**
[INFO] Exclude: npm-debug.log
[INFO] 1192 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1192 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 22.258s
[INFO] Finished at: Fri Jul 24 18:17:49 PDT 2015
[INFO] Final Memory: 10M/308M
[INFO] ------------------------------------------------------------------------


Thanks,

Vivek Ratnavel Subramanian