You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/09 15:24:13 UTC

[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #148: Remove the temporary gRPC log channel

kezhenxu94 commented on a change in pull request #148:
URL: https://github.com/apache/skywalking-python/pull/148#discussion_r685292543



##########
File path: skywalking/agent/protocol/__init__.py
##########
@@ -35,5 +35,8 @@ def heartbeat(self):
     def report(self, queue: Queue, block: bool = True):
         raise NotImplementedError()
 
+    def report_log(self, queue: Queue, block: bool = True):
+        raise NotImplementedError()

Review comment:
       We may want to provide some dummy implementations for http and kafka and log this kind of information only once, it's better we can implement those protocols later




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org