Re: [PR] HDDS-15391. Implement Merge-Join snapshot diff with dependency ordered report. [ozone]

["SaketaChalamchala (via GitHub)" <gi...@apache.org>]

SaketaChalamchala commented on code in PR #11296:
URL: https://github.com/apache/ozone/pull/11296#discussion_r4168872610


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -165,17 +169,19 @@ public class SnapshotDiffManager implements AutoCloseable, SnapshotDiffManagerMX
   private static final Logger LOG =
       LoggerFactory.getLogger(SnapshotDiffManager.class);
   private static final Map<DiffType, String> DIFF_TYPE_STRING_MAP =
-      new EnumMap<>(ImmutableMap.of(DELETE, "1", RENAME, "2", CREATE, "3", MODIFY, "4"));
+      new EnumMap<>(ImmutableMap.of(DELETE, "1", MODIFY, "2", RENAME, "3", CREATE, "4"));

Review Comment:
   The `DIFF_TYPE_STRING_MAP ` is only affects the order of report entries. The prior order is a vague ordering of the report entries based on 3 observed scenarios and miss corner cases. 
   The order of the entries does not indicate diff type, the actual report entries maintain the correct `DiffType`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org