[GitHub] [incubator-singa] joddiy commented on a change in pull request #483: SINGA-474 identity operator

[GitBox <gi...@apache.org>]

joddiy commented on a change in pull request #483: SINGA-474 identity operator
URL: https://github.com/apache/incubator-singa/pull/483#discussion_r309664758
 
 

 ##########
 File path: test/python/test_operation.py
 ##########
 @@ -322,6 +322,27 @@ def test_LeakyRelu(self):
         np.testing.assert_array_almost_equal(tensor.to_numpy(result), XT)
         self.check_shape(dx.shape(), (3, 2))
 
+    def test_Identity_cpu(self):
+        x = np.array([-0.9, -0.3, -0.1, 0.1, 0.5, 0.9]).reshape(3, 2).astype(np.float32)
+        y = x.copy()
+        x = tensor.from_numpy(x)
+        x.to_device(cpu_dev)
 
+        result = autograd.identity(x)
+        dx = result.creator.backward(x.data)
+
+        np.testing.assert_array_almost_equal(tensor.to_numpy(result), y, decimal=5)
+        self.check_shape(dx.shape(), (3, 2))
+    def test_Identity_gpu(self):
+        x = np.array([-0.9, -0.3, -0.1, 0.1, 0.5, 0.9]).reshape(3, 2).astype(np.float32)
+        y = x.copy()
+        x = tensor.from_numpy(x)
+        x.to_device(gpu_dev)
+
+        result = autograd.identity(x)
+        dx = result.creator.backward(x.data)
+
+        np.testing.assert_array_almost_equal(tensor.to_numpy(result), y, decimal=5)
 
 Review comment:
   please add the test case of backward propagation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services