[GitHub] [spark] HeartSaVioR commented on pull request #30126: [SPARK-33215][WEBUI] Speed up event log download by skipping UI rebuild

[GitBox <gi...@apache.org>]

HeartSaVioR commented on pull request #30126:
URL: https://github.com/apache/spark/pull/30126#issuecomment-715101308


   Looks good overall. Could we have a test to confirm event log download doesn't trigger ui load? You can add below code to HistoryServerSuite (probably after the test "ui and api authorization checks").
   
   ```
     test("SPARK-33215: speed up event log download by skipping UI rebuild") {
       val appId = "local-1430917381535"
   
       stop()
       init()
   
       val port = server.boundPort
       val testUrls = Seq(
         s"http://localhost:$port/api/v1/applications/$appId/logs",
         s"http://localhost:$port/api/v1/applications/$appId/1/logs",
         s"http://localhost:$port/api/v1/applications/$appId/2/logs")
   
       testUrls.foreach { url =>
         TestUtils.httpResponseCode(new URL(url))
       }
       assert(server.cacheMetrics.loadCount.getCount === 0, "downloading event log shouldn't load ui")
     }
   ```
   
   This would fail without the patch and pass with the patch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org