You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Ufuk Celebi (JIRA)" <ji...@apache.org> on 2016/04/26 10:37:12 UTC
[jira] [Closed] (FLINK-3803) Checkpoint Stats Tracker Reads from
Wrong Configuration
[ https://issues.apache.org/jira/browse/FLINK-3803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ufuk Celebi closed FLINK-3803.
------------------------------
Resolution: Fixed
Fix Version/s: 1.0.3
1.1.0
Fixed in 8330539 (1.1.0), 7062b0a (1.0.3).
> Checkpoint Stats Tracker Reads from Wrong Configuration
> -------------------------------------------------------
>
> Key: FLINK-3803
> URL: https://issues.apache.org/jira/browse/FLINK-3803
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Affects Versions: 1.0.0
> Reporter: Aljoscha Krettek
> Assignee: Ufuk Celebi
> Fix For: 1.1.0, 1.0.3
>
>
> In {{ExecutionGraph.java}} when configuring the checkpoint stats tracker the config values are read from the {{jobConfiguration}}:
> {code}
> boolean isStatsDisabled = jobConfiguration.getBoolean(
> ConfigConstants.JOB_MANAGER_WEB_CHECKPOINTS_DISABLE,
> ConfigConstants.DEFAULT_JOB_MANAGER_WEB_CHECKPOINTS_DISABLE);
> if (isStatsDisabled) {
> checkpointStatsTracker = new DisabledCheckpointStatsTracker();
> }
> else {
> int historySize = jobConfiguration.getInteger(
> ConfigConstants.JOB_MANAGER_WEB_CHECKPOINTS_HISTORY_SIZE,
> ConfigConstants.DEFAULT_JOB_MANAGER_WEB_CHECKPOINTS_HISTORY_SIZE);
> checkpointStatsTracker = new SimpleCheckpointStatsTracker(historySize, tasksToWaitFor);
> }
> {code}
> The settings are only available in the Flink Configuration, however. Right now, the {{ExecutionGraph}} has no access to the Flink Configuration.
> I see three solutions:
> - pass the Flink Configuration to the {{ExecutionGraph}}
> - pass just the two required settings to the {{ExecutionGraph}}
> - Introduce a new {{ExecutionGraphSettings}} that contains settings only for the {{ExecutionGraph}} in order to clean up things a bit
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)