You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Stanton Sievers (JIRA)" <ji...@apache.org> on 2011/07/01 20:24:28 UTC
[jira] [Created] (SHINDIG-1555) Shindig's ProxyServlet should
implement doPost
Shindig's ProxyServlet should implement doPost
----------------------------------------------
Key: SHINDIG-1555
URL: https://issues.apache.org/jira/browse/SHINDIG-1555
Project: Shindig
Issue Type: Improvement
Components: Java
Affects Versions: 2.0.2
Reporter: Stanton Sievers
Fix For: 3.0.0
Shindig's ProxyServlet currently does not support HTTP POST. This improvement would be to augment the existing ProxyServlet to implement doPost as well as doGet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (SHINDIG-1555) Shindig's ProxyServlet should
implement doPost
Posted by "Paul Lindner (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner closed SHINDIG-1555.
---------------------------------
part of 2.5.0-beta1 release.
> Shindig's ProxyServlet should implement doPost
> ----------------------------------------------
>
> Key: SHINDIG-1555
> URL: https://issues.apache.org/jira/browse/SHINDIG-1555
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.2
> Reporter: Stanton Sievers
> Labels: proxy
> Fix For: 2.5.0-beta1
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Shindig's ProxyServlet currently does not support HTTP POST. This improvement would be to augment the existing ProxyServlet to implement doPost as well as doGet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1555) Shindig's ProxyServlet should
implement doPost
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058702#comment-13058702 ]
jiraposter@reviews.apache.org commented on SHINDIG-1555:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/991/
-----------------------------------------------------------
Review request for Ryan Baxter and Stanton Sievers.
Summary
-------
Implemented the function doPost for the shindig ProxyServlet class.
This addresses bug SHINDIG-1555.
https://issues.apache.org/jira/browse/SHINDIG-1555
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java 1141997
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java 1141997
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java 1141997
Diff: https://reviews.apache.org/r/991/diff
Testing
-------
Created a gadget that made a post request from a proxy server using the following lines of code:
var proxyURL = gadgets.io.getProxyUrl("https://www.website.com");
var request = new XMLHttpRequest();
request.open("POST", proxyURL, false);
Thanks,
Michael
> Shindig's ProxyServlet should implement doPost
> ----------------------------------------------
>
> Key: SHINDIG-1555
> URL: https://issues.apache.org/jira/browse/SHINDIG-1555
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.2
> Reporter: Stanton Sievers
> Labels: proxy
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Shindig's ProxyServlet currently does not support HTTP POST. This improvement would be to augment the existing ProxyServlet to implement doPost as well as doGet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1555) Shindig's ProxyServlet should
implement doPost
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067792#comment-13067792 ]
jiraposter@reviews.apache.org commented on SHINDIG-1555:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/991/#review1110
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
<https://reviews.apache.org/r/991/#comment2263>
Probably dont need this method anymore since its pass thourgh to new method with postBody.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
<https://reviews.apache.org/r/991/#comment2262>
Add @nullable for postContent
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
<https://reviews.apache.org/r/991/#comment2261>
Add @Nullable for postBody
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java
<https://reviews.apache.org/r/991/#comment2264>
The chunk of code below to end of method probably could be moved to a helper function since its duplicating from the one in doGet.
- Henry
On 2011-07-18 20:17:33, Michael Brockhurst wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/991/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-18 20:17:33)
bq.
bq.
bq. Review request for Ryan Baxter and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Implemented the function doPost for the shindig ProxyServlet class.
bq.
bq.
bq. This addresses bug SHINDIG-1555.
bq. https://issues.apache.org/jira/browse/SHINDIG-1555
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java 1141997
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java 1141997
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java 1141997
bq.
bq. Diff: https://reviews.apache.org/r/991/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Created a gadget that made a post request from a proxy server using the following lines of code:
bq.
bq. var proxyURL = gadgets.io.getProxyUrl("https://www.website.com");
bq. var request = new XMLHttpRequest();
bq. request.open("POST", proxyURL, false);
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Shindig's ProxyServlet should implement doPost
> ----------------------------------------------
>
> Key: SHINDIG-1555
> URL: https://issues.apache.org/jira/browse/SHINDIG-1555
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.2
> Reporter: Stanton Sievers
> Labels: proxy
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Shindig's ProxyServlet currently does not support HTTP POST. This improvement would be to augment the existing ProxyServlet to implement doPost as well as doGet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1555) Shindig's ProxyServlet should
implement doPost
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068975#comment-13068975 ]
jiraposter@reviews.apache.org commented on SHINDIG-1555:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/991/
-----------------------------------------------------------
(Updated 2011-07-21 13:21:42.992634)
Review request for Ryan Baxter and Stanton Sievers.
Changes
-------
Made changes based on the latest comments.
Summary
-------
Implemented the function doPost for the shindig ProxyServlet class.
This addresses bug SHINDIG-1555.
https://issues.apache.org/jira/browse/SHINDIG-1555
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java 1141997
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java 1141997
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java 1141997
Diff: https://reviews.apache.org/r/991/diff
Testing
-------
Created a gadget that made a post request from a proxy server using the following lines of code:
var proxyURL = gadgets.io.getProxyUrl("https://www.website.com");
var request = new XMLHttpRequest();
request.open("POST", proxyURL, false);
Thanks,
Michael
> Shindig's ProxyServlet should implement doPost
> ----------------------------------------------
>
> Key: SHINDIG-1555
> URL: https://issues.apache.org/jira/browse/SHINDIG-1555
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.2
> Reporter: Stanton Sievers
> Labels: proxy
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Shindig's ProxyServlet currently does not support HTTP POST. This improvement would be to augment the existing ProxyServlet to implement doPost as well as doGet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1555) Shindig's ProxyServlet should
implement doPost
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068992#comment-13068992 ]
jiraposter@reviews.apache.org commented on SHINDIG-1555:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/991/#review1150
-----------------------------------------------------------
Ship it!
LGTM with small nit.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
<https://reviews.apache.org/r/991/#comment2381>
Still needed?
- Henry
On 2011-07-21 13:21:42, Michael Brockhurst wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/991/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-21 13:21:42)
bq.
bq.
bq. Review request for Ryan Baxter and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Implemented the function doPost for the shindig ProxyServlet class.
bq.
bq.
bq. This addresses bug SHINDIG-1555.
bq. https://issues.apache.org/jira/browse/SHINDIG-1555
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java 1141997
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java 1141997
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java 1141997
bq.
bq. Diff: https://reviews.apache.org/r/991/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Created a gadget that made a post request from a proxy server using the following lines of code:
bq.
bq. var proxyURL = gadgets.io.getProxyUrl("https://www.website.com");
bq. var request = new XMLHttpRequest();
bq. request.open("POST", proxyURL, false);
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Shindig's ProxyServlet should implement doPost
> ----------------------------------------------
>
> Key: SHINDIG-1555
> URL: https://issues.apache.org/jira/browse/SHINDIG-1555
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.2
> Reporter: Stanton Sievers
> Labels: proxy
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Shindig's ProxyServlet currently does not support HTTP POST. This improvement would be to augment the existing ProxyServlet to implement doPost as well as doGet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1555) Shindig's ProxyServlet should
implement doPost
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059129#comment-13059129 ]
jiraposter@reviews.apache.org commented on SHINDIG-1555:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/991/#review957
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
<https://reviews.apache.org/r/991/#comment2027>
Is there a reason why the new lines for these parameters changed? Or is this the diff tool being dumb?
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
<https://reviews.apache.org/r/991/#comment2028>
If we are going to add the @throws to the javadoc we might as well add the GadgetException and say why these are being thrown
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
<https://reviews.apache.org/r/991/#comment2029>
Make "POST" private static final
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
<https://reviews.apache.org/r/991/#comment2030>
Why create a new string variable for post content? Can't we just do postContent.getBytes() in the constructor of the ByteArrayInputStream?
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java
<https://reviews.apache.org/r/991/#comment2032>
Do not catch Exception, I would rather you catch the specific exceptions instead of the more general one
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java
<https://reviews.apache.org/r/991/#comment2033>
This should probably be in a finally block
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java
<https://reviews.apache.org/r/991/#comment2034>
Couldn't you define this variable in the ServletInputStream?
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java
<https://reviews.apache.org/r/991/#comment2035>
It's ok to make is2 private right?
- Ryan
On 2011-07-01 18:50:42, Michael Brockhurst wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/991/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-01 18:50:42)
bq.
bq.
bq. Review request for Ryan Baxter and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Implemented the function doPost for the shindig ProxyServlet class.
bq.
bq.
bq. This addresses bug SHINDIG-1555.
bq. https://issues.apache.org/jira/browse/SHINDIG-1555
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java 1141997
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java 1141997
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java 1141997
bq.
bq. Diff: https://reviews.apache.org/r/991/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Created a gadget that made a post request from a proxy server using the following lines of code:
bq.
bq. var proxyURL = gadgets.io.getProxyUrl("https://www.website.com");
bq. var request = new XMLHttpRequest();
bq. request.open("POST", proxyURL, false);
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Shindig's ProxyServlet should implement doPost
> ----------------------------------------------
>
> Key: SHINDIG-1555
> URL: https://issues.apache.org/jira/browse/SHINDIG-1555
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.2
> Reporter: Stanton Sievers
> Labels: proxy
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Shindig's ProxyServlet currently does not support HTTP POST. This improvement would be to augment the existing ProxyServlet to implement doPost as well as doGet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1555) Shindig's ProxyServlet should
implement doPost
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069340#comment-13069340 ]
jiraposter@reviews.apache.org commented on SHINDIG-1555:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/991/#review1163
-----------------------------------------------------------
Looks like some of my previous code review comments weren't addressed. Please make sure you fix those as well. The refactoring we talked about looks good to me.
- Ryan
On 2011-07-21 14:59:57, Michael Brockhurst wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/991/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-21 14:59:57)
bq.
bq.
bq. Review request for Ryan Baxter and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Implemented the function doPost for the shindig ProxyServlet class.
bq.
bq.
bq. This addresses bug SHINDIG-1555.
bq. https://issues.apache.org/jira/browse/SHINDIG-1555
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java 1141997
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java 1141997
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java 1141997
bq.
bq. Diff: https://reviews.apache.org/r/991/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Created a gadget that made a post request from a proxy server using the following lines of code:
bq.
bq. var proxyURL = gadgets.io.getProxyUrl("https://www.website.com");
bq. var request = new XMLHttpRequest();
bq. request.open("POST", proxyURL, false);
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Shindig's ProxyServlet should implement doPost
> ----------------------------------------------
>
> Key: SHINDIG-1555
> URL: https://issues.apache.org/jira/browse/SHINDIG-1555
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.2
> Reporter: Stanton Sievers
> Labels: proxy
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Shindig's ProxyServlet currently does not support HTTP POST. This improvement would be to augment the existing ProxyServlet to implement doPost as well as doGet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1555) Shindig's ProxyServlet should
implement doPost
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069014#comment-13069014 ]
jiraposter@reviews.apache.org commented on SHINDIG-1555:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/991/
-----------------------------------------------------------
(Updated 2011-07-21 14:59:57.536685)
Review request for Ryan Baxter and Stanton Sievers.
Changes
-------
Removed the unnecessary buildHttpRequest method.
Summary
-------
Implemented the function doPost for the shindig ProxyServlet class.
This addresses bug SHINDIG-1555.
https://issues.apache.org/jira/browse/SHINDIG-1555
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java 1141997
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java 1141997
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java 1141997
Diff: https://reviews.apache.org/r/991/diff
Testing
-------
Created a gadget that made a post request from a proxy server using the following lines of code:
var proxyURL = gadgets.io.getProxyUrl("https://www.website.com");
var request = new XMLHttpRequest();
request.open("POST", proxyURL, false);
Thanks,
Michael
> Shindig's ProxyServlet should implement doPost
> ----------------------------------------------
>
> Key: SHINDIG-1555
> URL: https://issues.apache.org/jira/browse/SHINDIG-1555
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.2
> Reporter: Stanton Sievers
> Labels: proxy
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Shindig's ProxyServlet currently does not support HTTP POST. This improvement would be to augment the existing ProxyServlet to implement doPost as well as doGet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1555) Shindig's ProxyServlet should
implement doPost
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058760#comment-13058760 ]
jiraposter@reviews.apache.org commented on SHINDIG-1555:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/991/#review956
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java
<https://reviews.apache.org/r/991/#comment2026>
I'm concerned that doPost and doGet are reusing a lot of the same code. Can these be refactored in such a way as to enable reuse of the common code?
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java
<https://reviews.apache.org/r/991/#comment2025>
Small nit... this could have a more descriptive name.
- Stanton
On 2011-07-01 18:50:42, Michael Brockhurst wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/991/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-01 18:50:42)
bq.
bq.
bq. Review request for Ryan Baxter and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Implemented the function doPost for the shindig ProxyServlet class.
bq.
bq.
bq. This addresses bug SHINDIG-1555.
bq. https://issues.apache.org/jira/browse/SHINDIG-1555
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java 1141997
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java 1141997
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java 1141997
bq.
bq. Diff: https://reviews.apache.org/r/991/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Created a gadget that made a post request from a proxy server using the following lines of code:
bq.
bq. var proxyURL = gadgets.io.getProxyUrl("https://www.website.com");
bq. var request = new XMLHttpRequest();
bq. request.open("POST", proxyURL, false);
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Shindig's ProxyServlet should implement doPost
> ----------------------------------------------
>
> Key: SHINDIG-1555
> URL: https://issues.apache.org/jira/browse/SHINDIG-1555
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.2
> Reporter: Stanton Sievers
> Labels: proxy
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Shindig's ProxyServlet currently does not support HTTP POST. This improvement would be to augment the existing ProxyServlet to implement doPost as well as doGet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1555) Shindig's ProxyServlet should
implement doPost
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Saputra resolved SHINDIG-1555.
------------------------------------
Resolution: Fixed
Fixed with revision 1149614
> Shindig's ProxyServlet should implement doPost
> ----------------------------------------------
>
> Key: SHINDIG-1555
> URL: https://issues.apache.org/jira/browse/SHINDIG-1555
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.2
> Reporter: Stanton Sievers
> Labels: proxy
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Shindig's ProxyServlet currently does not support HTTP POST. This improvement would be to augment the existing ProxyServlet to implement doPost as well as doGet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1555) Shindig's ProxyServlet should
implement doPost
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067265#comment-13067265 ]
jiraposter@reviews.apache.org commented on SHINDIG-1555:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/991/
-----------------------------------------------------------
(Updated 2011-07-18 20:17:33.600867)
Review request for Ryan Baxter and Stanton Sievers.
Changes
-------
Made small changes based on the feedback.
Summary
-------
Implemented the function doPost for the shindig ProxyServlet class.
This addresses bug SHINDIG-1555.
https://issues.apache.org/jira/browse/SHINDIG-1555
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java 1141997
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java 1141997
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java 1141997
Diff: https://reviews.apache.org/r/991/diff
Testing
-------
Created a gadget that made a post request from a proxy server using the following lines of code:
var proxyURL = gadgets.io.getProxyUrl("https://www.website.com");
var request = new XMLHttpRequest();
request.open("POST", proxyURL, false);
Thanks,
Michael
> Shindig's ProxyServlet should implement doPost
> ----------------------------------------------
>
> Key: SHINDIG-1555
> URL: https://issues.apache.org/jira/browse/SHINDIG-1555
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.2
> Reporter: Stanton Sievers
> Labels: proxy
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Shindig's ProxyServlet currently does not support HTTP POST. This improvement would be to augment the existing ProxyServlet to implement doPost as well as doGet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira