You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2024/01/01 12:33:12 UTC

[PR] RATIS-1988. Provide Jacoco report to Sonar [ratis]

adoroszlai opened a new pull request, #1002:
URL: https://github.com/apache/ratis/pull/1002

   ## What changes were proposed in this pull request?
   
   RATIS-1985 added code coverage calculation. SonarCloud expects the report in a different location, so it still shows 0%.
   
   ```
   [INFO] 'sonar.coverage.jacoco.xmlReportPaths' is not defined. Using default locations: target/site/jacoco/jacoco.xml,target/site/jacoco-it/jacoco.xml,build/reports/jacoco/test/jacocoTestReport.xml
   [INFO] No report imported, no coverage information will be imported by JaCoCo XML Report Importer
   ```
   
   This change sets the property to the location of the aggregate XML report generated by `coverage.sh`.
   
   https://issues.apache.org/jira/browse/RATIS-1988
   
   ## How was this patch tested?
   
   Tested in (non-fork) [CI run](https://github.com/apache/ratis/actions/runs/7377131200/job/20070984036#step:8:1298):
   
   ```
   [INFO] Sensor JaCoCo XML Report Importer [jacoco]
   [INFO] Importing 1 report(s). Turn your logs in debug mode in order to see the exhaustive list.
   ```
   
   SonarCloud now shows 76.3% coverage for [this branch](https://sonarcloud.io/summary/new_code?id=apache-ratis&branch=RATIS-1988).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] RATIS-1988. Provide Jacoco report to Sonar [ratis]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #1002:
URL: https://github.com/apache/ratis/pull/1002#issuecomment-1873420165

   Thanks @szetszwo for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] RATIS-1988. Provide Jacoco report to Sonar [ratis]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #1002:
URL: https://github.com/apache/ratis/pull/1002


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org