You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/04/06 10:45:39 UTC
[GitHub] [incubator-seatunnel] BenJFan opened a new pull request, #1665: [Improve] Update version to 2.1.1-SNAPSHOT
BenJFan opened a new pull request, #1665:
URL: https://github.com/apache/incubator-seatunnel/pull/1665
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
Update version to 2.1.1-SNAPSHOT.
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in you PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/development/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1665: [Improve] Update version to 2.1.1-SNAPSHOT
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #1665:
URL: https://github.com/apache/incubator-seatunnel/pull/1665#issuecomment-1091147050
> @CalvinKirs @BenJFan Maybe it's better to use [`${revision}`](https://maven.apache.org/maven-ci-friendly.html) to manage the project version. Once we need to change the version, we just need to change the parent pom. I have test on my laptop, it can work.
In fact, usually we will automatically generate the development version of the next version, just because we have been developing on dev.
In addition, there are some problems when using the release plug-in in this way, and the corresponding version cannot be read for modification. Can you try it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1665: [Improve] Update version to 2.1.1-SNAPSHOT
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged PR #1665:
URL: https://github.com/apache/incubator-seatunnel/pull/1665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1665: [Improve] Update version to 2.1.1-SNAPSHOT
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1665:
URL: https://github.com/apache/incubator-seatunnel/pull/1665#issuecomment-1091504457
>
Yes, after execute `./mvnw release:prepare -Prelease, -DautoVersionSubmodules=true -DpushChanges=false `, will genetate two files in `seatunnel-dist/target`
```
apache-seatunnel-incubating-2.1.1-bin.tar.gz
apache-seatunnel-incubating-2.1.1-src.tar.gz
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1665: [Improve] Update version to 2.1.1-SNAPSHOT
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1665:
URL: https://github.com/apache/incubator-seatunnel/pull/1665#issuecomment-1091135297
@CalvinKirs @BenJFan Maybe it's better to use [`${revision}`](https://maven.apache.org/maven-ci-friendly.html) to manage the project version. Once we need to change the version, we just need to change the parent pom.
I have test on my laptop, it can work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1665: [Improve] Update version to 2.1.1-SNAPSHOT
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1665:
URL: https://github.com/apache/incubator-seatunnel/pull/1665#issuecomment-1091174349
> > @CalvinKirs @BenJFan Maybe it's better to use [`${revision}`](https://maven.apache.org/maven-ci-friendly.html) to manage the project version. Once we need to change the version, we just need to change the parent pom. I have test on my laptop, it can work.
>
> In fact, usually we will automatically generate the development version of the next version, just because we have been developing on dev.
>
> In addition, there are some problems when using the release plug-in in this way, and the corresponding version cannot be read for modification. Can you try it?
Ok, we can use release plugin to generate the version and modify the version in all pom. So we don't need to use revision.
I have tested with `release:prepare` it seems it can work well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1665: [Improve] Update version to 2.1.1-SNAPSHOT
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #1665:
URL: https://github.com/apache/incubator-seatunnel/pull/1665#issuecomment-1091292194
> > > @CalvinKirs @BenJFan Maybe it's better to use [`${revision}`](https://maven.apache.org/maven-ci-friendly.html) to manage the project version. Once we need to change the version, we just need to change the parent pom. I have test on my laptop, it can work.
> >
> >
> > In fact, usually we will automatically generate the development version of the next version, just because we have been developing on dev.
> > In addition, there are some problems when using the release plug-in in this way, and the corresponding version cannot be read for modification. Can you try it?
>
> Ok, we can use release plugin to generate the version and modify the version in all pom. So we don't need to use revision.
>
> I have tested with `release:prepare` it seems it can work well.
did you try it ``` ./mvnw release:prepare -Prelease, -DautoVersionSubmodules=true -DpushChanges=false```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org