You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "chibenwa (via GitHub)" <gi...@apache.org> on 2025/12/19 13:34:11 UTC

[PR] [ENHANCEMENT] OIDC SASL code refactoring [james-project]

chibenwa opened a new pull request, #2888:
URL: https://github.com/apache/james-project/pull/2888

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] [ENHANCEMENT] OIDC SASL code refactoring [james-project]

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2888:
URL: https://github.com/apache/james-project/pull/2888#issuecomment-3695419036

   Ok I think when applying the docker fix it made an other change I didn't see in jenkinsfile (an extra clean in mvn for tests). I reverted it. It seems now it's building.
   
   Will monitor


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] [ENHANCEMENT] OIDC SASL code refactoring [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #2888:
URL: https://github.com/apache/james-project/pull/2888#issuecomment-3680661143

   Please help push fixes on this...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] [ENHANCEMENT] OIDC SASL code refactoring [james-project]

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2888:
URL: https://github.com/apache/james-project/pull/2888#issuecomment-3698447408

   https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-2888/10/testReport/
   
   This one is related... 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] [ENHANCEMENT] OIDC SASL code refactoring [james-project]

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2888:
URL: https://github.com/apache/james-project/pull/2888#issuecomment-3695366253

   Ok earlier I was struggling because I forgot the 3.8 version is running on jdk 11 (my bad)
   
   However now I compiles fine. mailetdocs-maven-plugin does tests well locally too. I'm not too sure what's going on with the CI?
   
   Will dig a bit more but... or can we just remove that mailetdocs-maven-plugin thing for the 3.8.x branch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] [ENHANCEMENT] OIDC SASL code refactoring [james-project]

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2888:
URL: https://github.com/apache/james-project/pull/2888#issuecomment-3698876351

   Green locally. We are missing https://github.com/apache/james-project/pull/2744 in 3.8.x. I did try to backport it too but it's a bit complicated (paradigms used from java version upper than jdk11, some java classes even not present in jdk11, etc)
   
   Then checking again... I think we can reapply the previous verification on signature and claim extraction. 
   
   But not 100% sure. @chibenwa when you are available I think it would be best to have a final review on your side regarding this, thanks :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] [ENHANCEMENT] OIDC SASL code refactoring [james-project]

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2888:
URL: https://github.com/apache/james-project/pull/2888#issuecomment-3701547553

   Green... finally :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] [ENHANCEMENT] OIDC SASL code refactoring [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa merged PR #2888:
URL: https://github.com/apache/james-project/pull/2888


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] [ENHANCEMENT] OIDC SASL code refactoring [james-project]

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2888:
URL: https://github.com/apache/james-project/pull/2888#issuecomment-3680094732

   [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (check-style) on project protocols-imap: You have 1 Checkstyle violation. -> [Help 1]
   
   will check...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

Re: [PR] [ENHANCEMENT] OIDC SASL code refactoring [james-project]

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2888:
URL: https://github.com/apache/james-project/pull/2888#issuecomment-3695260921

   I honestly dont know... I can't even reproduce I have other issues locally, the branch is old and I moved on a new install since. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org