You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/01/23 15:04:30 UTC
[GitHub] [incubator-dolphinscheduler] zt-1997 opened a new pull request #4543: [FIX-2101]It solves the problem that the name of the branch will not change after the name of the branch is changed in the workflow page and instance page.
zt-1997 opened a new pull request #4543:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4543
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] zt-1997 closed pull request #4543: [FIX-2101]It solves the problem that the name of the branch will not change after the name of the branch is changed in the workflow page and instance page.
Posted by GitBox <gi...@apache.org>.
zt-1997 closed pull request #4543:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4543
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] lenboo commented on a change in pull request #4543: [FIX-2101]It solves the problem that the name of the branch will not change after the name of the branch is changed in the workflow page and instance page.
Posted by GitBox <gi...@apache.org>.
lenboo commented on a change in pull request #4543:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4543#discussion_r563310657
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessInstanceService.java
##########
@@ -460,6 +460,58 @@ private void addDependResultForTaskList(List<TaskInstance> taskInstanceList) thr
if (tenant != null) {
processInstance.setTenantCode(tenant.getTenantCode());
}
+ // get the processinstancejson before saving,and then save the name and taskid
+ String oldJson = processInstance.getProcessInstanceJson();
Review comment:
duplicate code can be extracted to method in ProcessService
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessInstanceService.java
##########
@@ -460,6 +460,58 @@ private void addDependResultForTaskList(List<TaskInstance> taskInstanceList) thr
if (tenant != null) {
processInstance.setTenantCode(tenant.getTenantCode());
}
+ // get the processinstancejson before saving,and then save the name and taskid
+ String oldJson = processInstance.getProcessInstanceJson();
Review comment:
duplicate code can be extracted to a method in ProcessService
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] zt-1997 closed pull request #4543: [FIX-2101]It solves the problem that the name of the branch will not change after the name of the branch is changed in the workflow page and instance page.
Posted by GitBox <gi...@apache.org>.
zt-1997 closed pull request #4543:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4543
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] lenboo commented on a change in pull request #4543: [FIX-2101]It solves the problem that the name of the branch will not change after the name of the branch is changed in the workflow page and instance page.
Posted by GitBox <gi...@apache.org>.
lenboo commented on a change in pull request #4543:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4543#discussion_r563310657
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessInstanceService.java
##########
@@ -460,6 +460,58 @@ private void addDependResultForTaskList(List<TaskInstance> taskInstanceList) thr
if (tenant != null) {
processInstance.setTenantCode(tenant.getTenantCode());
}
+ // get the processinstancejson before saving,and then save the name and taskid
+ String oldJson = processInstance.getProcessInstanceJson();
Review comment:
duplicate code can be extracted to a method in ProcessService
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] chengshiwen commented on pull request #4543: [FIX-2101]It solves the problem that the name of the branch will not change after the name of the branch is changed in the workflow page and instance page.
Posted by GitBox <gi...@apache.org>.
chengshiwen commented on pull request #4543:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4543#issuecomment-766799288
@zt-1997 What is the relationship between this PR and the duplicated PR #4555? Could you close one of them?
By the way, you should pass the **SonarCloud Code Analysis**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #4543: [FIX-2101]It solves the problem that the name of the branch will not change after the name of the branch is changed in the workflow page and instance page.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #4543:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4543#issuecomment-766094467
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4543?src=pr&el=h1) Report
> Merging [#4543](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4543?src=pr&el=desc) (dede0f1) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/cfa88a4a804b3bc565f6571d5a6e842df18644a2?el=desc) (cfa88a4) will **decrease** coverage by `0.08%`.
> The diff coverage is `30.76%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4543?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #4543 +/- ##
============================================
- Coverage 44.76% 44.68% -0.09%
- Complexity 3340 3341 +1
============================================
Files 527 527
Lines 22815 22893 +78
Branches 2667 2683 +16
============================================
+ Hits 10214 10230 +16
- Misses 11680 11741 +61
- Partials 921 922 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4543?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...api/service/impl/ProcessDefinitionServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9Qcm9jZXNzRGVmaW5pdGlvblNlcnZpY2VJbXBsLmphdmE=) | `65.50% <5.12%> (-2.99%)` | `108.00 <0.00> (ø)` | |
| [...nscheduler/api/service/ProcessInstanceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0luc3RhbmNlU2VydmljZS5qYXZh) | `71.86% <56.41%> (-1.89%)` | `40.00 <0.00> (+4.00)` | :arrow_down: |
| [...he/dolphinscheduler/common/enums/SqoopJobType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1Nxb29wSm9iVHlwZS5qYXZh) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `77.77% <0.00%> (-5.56%)` | `3.00% <0.00%> (-1.00%)` | |
| [...inscheduler/common/task/sqoop/SqoopParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3AvU3Fvb3BQYXJhbWV0ZXJzLmphdmE=) | `74.00% <0.00%> (-2.00%)` | `25.00% <0.00%> (ø%)` | |
| [...inscheduler/service/zk/CuratorZookeeperClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvemsvQ3VyYXRvclpvb2tlZXBlckNsaWVudC5qYXZh) | `65.85% <0.00%> (+4.87%)` | `8.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4543?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4543?src=pr&el=footer). Last update [cfa88a4...dede0f1](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4543?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] lenboo commented on a change in pull request #4543: [FIX-2101]It solves the problem that the name of the branch will not change after the name of the branch is changed in the workflow page and instance page.
Posted by GitBox <gi...@apache.org>.
lenboo commented on a change in pull request #4543:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4543#discussion_r563310657
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessInstanceService.java
##########
@@ -460,6 +460,58 @@ private void addDependResultForTaskList(List<TaskInstance> taskInstanceList) thr
if (tenant != null) {
processInstance.setTenantCode(tenant.getTenantCode());
}
+ // get the processinstancejson before saving,and then save the name and taskid
+ String oldJson = processInstance.getProcessInstanceJson();
Review comment:
duplicate code can be extracted to method in ProcessService
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] chengshiwen commented on pull request #4543: [FIX-2101]It solves the problem that the name of the branch will not change after the name of the branch is changed in the workflow page and instance page.
Posted by GitBox <gi...@apache.org>.
chengshiwen commented on pull request #4543:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4543#issuecomment-766799288
@zt-1997 What is the relationship between this PR and the duplicated PR #4555? Could you close one of them?
By the way, you should pass the **SonarCloud Code Analysis**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #4543: [FIX-2101]It solves the problem that the name of the branch will not change after the name of the branch is changed in the workflow page and instance page.
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #4543:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4543#issuecomment-766094932
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4543&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4543&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4543&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4543&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4543&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4543&resolved=false&types=VULNERABILITY)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=4543&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=4543&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=4543&resolved=false&types=SECURITY_HOTSPOT)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4543&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4543&resolved=false&types=CODE_SMELL) [8 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4543&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/25.png' alt='31.6%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4543&metric=new_coverage&view=list) [31.6% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4543&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/20plus.png' alt='86.4%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4543&metric=new_duplicated_lines_density&view=list) [86.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4543&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org