You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/06/26 10:55:25 UTC
[GitHub] [airflow] potiuk commented on pull request #32132: Fixup config var types under the scheduler section
potiuk commented on PR #32132:
URL: https://github.com/apache/airflow/pull/32132#issuecomment-1607209690
Side comment - I **think** those kind of changes should be treated carefully. I do remember a case when changing type of the configuration introduced breaking change that we were struggling to fix (I think it was chaning an int into float or the other way). Not sure if there will be some effects here but I think some careful thinking here of edge scenarios and looking at the code when those changed values are used should be part of the change. There might be non-obvious side-effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org