You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Igor Galić <i....@brainsware.org> on 2011/09/26 15:20:43 UTC
Re: svn commit: r1175847 - /trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc
----- Original Message -----
> Author: jim
> Date: Mon Sep 26 12:59:42 2011
> New Revision: 1175847
>
> URL: http://svn.apache.org/viewvc?rev=1175847&view=rev
> Log:
> remove weird cast
>
> Modified:
> trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc
Which leads to the next weird cast, which is probably equally
awkward handled in trunk:
http://ci.apache.org/builders/tserver-branch3.0.x/builds/15/steps/compile_2/logs/stdio
> Modified:
> trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc
> URL:
> http://svn.apache.org/viewvc/trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc?rev=1175847&r1=1175846&r2=1175847&view=diff
> ==============================================================================
> ---
> trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc
> (original)
> +++
> trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc
> Mon Sep 26 12:59:42 2011
> @@ -1863,7 +1863,7 @@ ClusterHandler::add_small_controlmsg_des
> c->freeall();
> p = (char *) DOUBLE_ALIGN(p);
> #ifdef PURIFY
> - if ((unsigned int) endp < (unsigned int) p)
> + if (endp < p)
> memset(endp, 0, (p - endp));
> #endif
> }
i
--
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 571B 8B8A FC97 266D BDA3 EF6F 43AD 80A4 5779 3257
Re: svn commit: r1175847 - /trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc
Posted by Jim Jagielski <ji...@apache.org>.
trunk handles this correctly.
On Sep 26, 2011, at 9:35 AM, Jim Jagielski wrote:
> I'm thinking about enabling purify locally… :)
>
> Will look at this one too.
>
> On Sep 26, 2011, at 9:20 AM, Igor Galić wrote:
>
>>
>>
>> ----- Original Message -----
>>> Author: jim
>>> Date: Mon Sep 26 12:59:42 2011
>>> New Revision: 1175847
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1175847&view=rev
>>> Log:
>>> remove weird cast
>>>
>>> Modified:
>>> trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc
>>
>>
>> Which leads to the next weird cast, which is probably equally
>> awkward handled in trunk:
>>
>> http://ci.apache.org/builders/tserver-branch3.0.x/builds/15/steps/compile_2/logs/stdio
>>
>>> Modified:
>>> trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc
>>> URL:
>>> http://svn.apache.org/viewvc/trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc?rev=1175847&r1=1175846&r2=1175847&view=diff
>>> ==============================================================================
>>> ---
>>> trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc
>>> (original)
>>> +++
>>> trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc
>>> Mon Sep 26 12:59:42 2011
>>> @@ -1863,7 +1863,7 @@ ClusterHandler::add_small_controlmsg_des
>>> c->freeall();
>>> p = (char *) DOUBLE_ALIGN(p);
>>> #ifdef PURIFY
>>> - if ((unsigned int) endp < (unsigned int) p)
>>> + if (endp < p)
>>> memset(endp, 0, (p - endp));
>>> #endif
>>> }
>>
>> i
>>
>> --
>> Igor Galić
>>
>> Tel: +43 (0) 664 886 22 883
>> Mail: i.galic@brainsware.org
>> URL: http://brainsware.org/
>> GPG: 571B 8B8A FC97 266D BDA3 EF6F 43AD 80A4 5779 3257
>>
>
Re: svn commit: r1175847 - /trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc
Posted by Jim Jagielski <ji...@apache.org>.
trunk handles this correctly.
On Sep 26, 2011, at 9:35 AM, Jim Jagielski wrote:
> I'm thinking about enabling purify locally… :)
>
> Will look at this one too.
>
> On Sep 26, 2011, at 9:20 AM, Igor Galić wrote:
>
>>
>>
>> ----- Original Message -----
>>> Author: jim
>>> Date: Mon Sep 26 12:59:42 2011
>>> New Revision: 1175847
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1175847&view=rev
>>> Log:
>>> remove weird cast
>>>
>>> Modified:
>>> trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc
>>
>>
>> Which leads to the next weird cast, which is probably equally
>> awkward handled in trunk:
>>
>> http://ci.apache.org/builders/tserver-branch3.0.x/builds/15/steps/compile_2/logs/stdio
>>
>>> Modified:
>>> trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc
>>> URL:
>>> http://svn.apache.org/viewvc/trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc?rev=1175847&r1=1175846&r2=1175847&view=diff
>>> ==============================================================================
>>> ---
>>> trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc
>>> (original)
>>> +++
>>> trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc
>>> Mon Sep 26 12:59:42 2011
>>> @@ -1863,7 +1863,7 @@ ClusterHandler::add_small_controlmsg_des
>>> c->freeall();
>>> p = (char *) DOUBLE_ALIGN(p);
>>> #ifdef PURIFY
>>> - if ((unsigned int) endp < (unsigned int) p)
>>> + if (endp < p)
>>> memset(endp, 0, (p - endp));
>>> #endif
>>> }
>>
>> i
>>
>> --
>> Igor Galić
>>
>> Tel: +43 (0) 664 886 22 883
>> Mail: i.galic@brainsware.org
>> URL: http://brainsware.org/
>> GPG: 571B 8B8A FC97 266D BDA3 EF6F 43AD 80A4 5779 3257
>>
>
Re: svn commit: r1175847 - /trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc
Posted by Jim Jagielski <ji...@jaguNET.com>.
I'm thinking about enabling purify locally… :)
Will look at this one too.
On Sep 26, 2011, at 9:20 AM, Igor Galić wrote:
>
>
> ----- Original Message -----
>> Author: jim
>> Date: Mon Sep 26 12:59:42 2011
>> New Revision: 1175847
>>
>> URL: http://svn.apache.org/viewvc?rev=1175847&view=rev
>> Log:
>> remove weird cast
>>
>> Modified:
>> trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc
>
>
> Which leads to the next weird cast, which is probably equally
> awkward handled in trunk:
>
> http://ci.apache.org/builders/tserver-branch3.0.x/builds/15/steps/compile_2/logs/stdio
>
>> Modified:
>> trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc
>> URL:
>> http://svn.apache.org/viewvc/trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc?rev=1175847&r1=1175846&r2=1175847&view=diff
>> ==============================================================================
>> ---
>> trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc
>> (original)
>> +++
>> trafficserver/traffic/branches/3.0.x/iocore/cluster/ClusterHandler.cc
>> Mon Sep 26 12:59:42 2011
>> @@ -1863,7 +1863,7 @@ ClusterHandler::add_small_controlmsg_des
>> c->freeall();
>> p = (char *) DOUBLE_ALIGN(p);
>> #ifdef PURIFY
>> - if ((unsigned int) endp < (unsigned int) p)
>> + if (endp < p)
>> memset(endp, 0, (p - endp));
>> #endif
>> }
>
> i
>
> --
> Igor Galić
>
> Tel: +43 (0) 664 886 22 883
> Mail: i.galic@brainsware.org
> URL: http://brainsware.org/
> GPG: 571B 8B8A FC97 266D BDA3 EF6F 43AD 80A4 5779 3257
>