You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wayang.apache.org by "juripetersen (via GitHub)" <gi...@apache.org> on 2024/05/28 07:34:46 UTC
[PR] Set logLevel on WayangContext to allow doing it without conf file [incubator-wayang]
juripetersen opened a new pull request, #453:
URL: https://github.com/apache/incubator-wayang/pull/453
This proposes a functional interface to change the Loggers level with the `WayangContext`:
```java
context.setLogLevel(Level.ERROR);
```
The change provides better ergonomics and prevents having to fiddle with configuration files, when Context objects etc. can be created during plan building. Furthermore, this aligns with the API presented in other Apache projects like [Spark](https://github.com/apache/spark/blob/df5ef91f44bacf60b39bccecc049eb8cb5714b39/core/src/main/scala/org/apache/spark/SparkContext.scala#L398)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Set logLevel on WayangContext to allow doing it without conf file [incubator-wayang]
Posted by "zkaoudi (via GitHub)" <gi...@apache.org>.
zkaoudi commented on PR #453:
URL: https://github.com/apache/incubator-wayang/pull/453#issuecomment-2144966769
But the change does not concern the missing module, so that is weird. Also the module is locally located.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Set logLevel on WayangContext to allow doing it without conf file [incubator-wayang]
Posted by "juripetersen (via GitHub)" <gi...@apache.org>.
juripetersen commented on PR #453:
URL: https://github.com/apache/incubator-wayang/pull/453#issuecomment-2151494672
@zkaoudi @kbeedkar I can reproduce this by running `./mvnw clean verify -B -Dmaven.test.skip=false -Dwayang.configuration=file:$(pwd)/tools/test/config/wayang.properties` on a fresh setup. The error occurs because some modules are not on mvn central as they are not in a release yet. I think this is sensible and the build should be constructed from the current state of the repo and not from central. If I run `mvn clean install` before, the local modules are built and then used for the verification step. This resolves the error.
Is including install as a step before verification in our action a solution, or does this introduce something I am unaware of?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Set logLevel on WayangContext to allow doing it without conf file [incubator-wayang]
Posted by "zkaoudi (via GitHub)" <gi...@apache.org>.
zkaoudi commented on PR #453:
URL: https://github.com/apache/incubator-wayang/pull/453#issuecomment-2151574588
@juripetersen makes totally sense. @2pk03 do you see any issue with that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Set logLevel on WayangContext to allow doing it without conf file [incubator-wayang]
Posted by "juripetersen (via GitHub)" <gi...@apache.org>.
juripetersen commented on PR #453:
URL: https://github.com/apache/incubator-wayang/pull/453#issuecomment-2144578823
@kbeedkar it seems like the build can't find `wayang-api-json` in https://repo.maven.apache.org/maven2/org/apache/wayang/. This seems to be correct, as that module is not to be found there. Do we have to publish a release for that module to be in maven-central?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Set logLevel on WayangContext to allow doing it without conf file [incubator-wayang]
Posted by "2pk03 (via GitHub)" <gi...@apache.org>.
2pk03 merged PR #453:
URL: https://github.com/apache/incubator-wayang/pull/453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Set logLevel on WayangContext to allow doing it without conf file [incubator-wayang]
Posted by "juripetersen (via GitHub)" <gi...@apache.org>.
juripetersen commented on PR #453:
URL: https://github.com/apache/incubator-wayang/pull/453#issuecomment-2136580055
> Can you check why some unit tests are failing?
I can't replicate the error locally. It looks like building the assembly fails due to local/cache problems? Maybe a rerun of the action solves it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Set logLevel on WayangContext to allow doing it without conf file [incubator-wayang]
Posted by "kbeedkar (via GitHub)" <gi...@apache.org>.
kbeedkar commented on PR #453:
URL: https://github.com/apache/incubator-wayang/pull/453#issuecomment-2135201629
Can you check why some unit tests are failing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Set logLevel on WayangContext to allow doing it without conf file [incubator-wayang]
Posted by "2pk03 (via GitHub)" <gi...@apache.org>.
2pk03 commented on PR #453:
URL: https://github.com/apache/incubator-wayang/pull/453#issuecomment-2144875691
@juripetersen - yes I think so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org