[GitHub] [hadoop] steveloughran commented on a change in pull request #3332: HADOOP-17863. ABFS: Fix compiler deprecation warning in TextFileBasedIdentityHandler

[GitBox <gi...@apache.org>]

steveloughran commented on a change in pull request #3332:
URL: https://github.com/apache/hadoop/pull/3332#discussion_r703051987



##########
File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TextFileBasedIdentityHandler.java
##########
@@ -186,6 +188,14 @@ private static void loadMap(HashMap<String, String> cache, String fileLocation,
       LOG.debug("Loaded map stats - File: {}, Loaded: {}, Error: {} ", fileLocation, cache.size(), errorRecord);
     } catch (ArrayIndexOutOfBoundsException e) {
       LOG.error("Error while parsing mapping file", e);
+    } finally {
+      try {

Review comment:
       if it is an instance of closeable, we could use IOUtils.cleanupWithLogger() here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org