You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/07/13 06:22:27 UTC

[GitHub] [skywalking-cli] Tom-DaLin opened a new pull request #99: Optimize output

Tom-DaLin opened a new pull request #99:
URL: https://github.com/apache/skywalking-cli/pull/99


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] wu-sheng merged pull request #99: Optimize output by adding color to help information

Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #99:
URL: https://github.com/apache/skywalking-cli/pull/99


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] fgksgf commented on a change in pull request #99: Optimize output

Posted by GitBox <gi...@apache.org>.
fgksgf commented on a change in pull request #99:
URL: https://github.com/apache/skywalking-cli/pull/99#discussion_r669313562



##########
File path: pkg/util/template.go
##########
@@ -0,0 +1,81 @@
+package util
+
+// Variable beginning with a capital letter can make the text bold

Review comment:
       ```suggestion
   // TextFormat defines variables of style and colors.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] fgksgf commented on a change in pull request #99: Optimize output

Posted by GitBox <gi...@apache.org>.
fgksgf commented on a change in pull request #99:
URL: https://github.com/apache/skywalking-cli/pull/99#discussion_r669310942



##########
File path: pkg/util/template.go
##########
@@ -0,0 +1,81 @@
+package util
+
+// Variable beginning with a capital letter can make the text bold
+const TextFormat = `
+{{- $bold	:="\x1b[1m" -}}
+{{- $black	:="\x1b[0;30m" -}}	{{- $Black	:="\x1b[1;30m" -}}	
+{{- $red	:="\x1b[0;31m" -}}	{{- $Red	:="\x1b[1;31m" -}}
+{{- $green	:="\x1b[0;32m" -}}	{{- $Green	:="\x1b[1;32m" -}}
+{{- $yellow	:="\x1b[0;33m" -}}	{{- $Yellow	:="\x1b[1;33m" -}}
+{{- $blue	:="\x1b[0;34m" -}}	{{- $Blue	:="\x1b[1;34m" -}}
+{{- $pruple	:="\x1b[0;35m" -}}	{{- $Pruple	:="\x1b[1;35m" -}}
+{{- $cyan	:="\x1b[0;36m" -}}	{{- $Cyan	:="\x1b[1;36m" -}}
+{{- $white	:="\x1b[0;37m" -}}	{{- $White	:="\x1b[1;37m" -}}
+{{- $plain	:="\x1b[0m" -}}
+`
+
+const AppHelpTemplate = TextFormat + `{{$Green -}}
+NAME:
+	{{$green}}{{.Name}}{{if .Usage}} - {{.Usage}}{{end}}{{$Green}}
+
+USAGE:
+	{{$green}}{{if .UsageText}}{{.UsageText}}{{else}}{{.HelpName}} {{if .VisibleFlags}}[global options]{{end}}{{if .Commands}} command [command options]{{end}} {{if .ArgsUsage}}{{.ArgsUsage}}{{else}}[arguments...]{{end}}{{end}}{{$Yellow}}{{if .Version}}{{if not .HideVersion}}
+VERSION:

Review comment:
       Need to add a blank line before this




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] fgksgf commented on a change in pull request #99: Optimize output

Posted by GitBox <gi...@apache.org>.
fgksgf commented on a change in pull request #99:
URL: https://github.com/apache/skywalking-cli/pull/99#discussion_r669310942



##########
File path: pkg/util/template.go
##########
@@ -0,0 +1,81 @@
+package util
+
+// Variable beginning with a capital letter can make the text bold
+const TextFormat = `
+{{- $bold	:="\x1b[1m" -}}
+{{- $black	:="\x1b[0;30m" -}}	{{- $Black	:="\x1b[1;30m" -}}	
+{{- $red	:="\x1b[0;31m" -}}	{{- $Red	:="\x1b[1;31m" -}}
+{{- $green	:="\x1b[0;32m" -}}	{{- $Green	:="\x1b[1;32m" -}}
+{{- $yellow	:="\x1b[0;33m" -}}	{{- $Yellow	:="\x1b[1;33m" -}}
+{{- $blue	:="\x1b[0;34m" -}}	{{- $Blue	:="\x1b[1;34m" -}}
+{{- $pruple	:="\x1b[0;35m" -}}	{{- $Pruple	:="\x1b[1;35m" -}}
+{{- $cyan	:="\x1b[0;36m" -}}	{{- $Cyan	:="\x1b[1;36m" -}}
+{{- $white	:="\x1b[0;37m" -}}	{{- $White	:="\x1b[1;37m" -}}
+{{- $plain	:="\x1b[0m" -}}
+`
+
+const AppHelpTemplate = TextFormat + `{{$Green -}}
+NAME:
+	{{$green}}{{.Name}}{{if .Usage}} - {{.Usage}}{{end}}{{$Green}}
+
+USAGE:
+	{{$green}}{{if .UsageText}}{{.UsageText}}{{else}}{{.HelpName}} {{if .VisibleFlags}}[global options]{{end}}{{if .Commands}} command [command options]{{end}} {{if .ArgsUsage}}{{.ArgsUsage}}{{else}}[arguments...]{{end}}{{end}}{{$Yellow}}{{if .Version}}{{if not .HideVersion}}
+VERSION:

Review comment:
       Need to add a blank line before `VERSION:`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] fgksgf commented on a change in pull request #99: Optimize output

Posted by GitBox <gi...@apache.org>.
fgksgf commented on a change in pull request #99:
URL: https://github.com/apache/skywalking-cli/pull/99#discussion_r668464117



##########
File path: pkg/util/template.go
##########
@@ -0,0 +1,81 @@
+package util
+

Review comment:
       Add the license header, please




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] codecov-commenter commented on pull request #99: Optimize output

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #99:
URL: https://github.com/apache/skywalking-cli/pull/99#issuecomment-879631414


   # [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/99?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#99](https://codecov.io/gh/apache/skywalking-cli/pull/99?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (20145d9) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/21ba64dd2ddfd6cfeca14801e7c3888f1befc3ca?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (21ba64d) will **increase** coverage by `0.82%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking-cli/pull/99/graphs/tree.svg?width=650&height=150&src=pr&token=oivudZDTNJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking-cli/pull/99?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master      #99      +/-   ##
   ==========================================
   + Coverage   46.29%   47.12%   +0.82%     
   ==========================================
     Files          11       11              
     Lines         162      191      +29     
   ==========================================
   + Hits           75       90      +15     
   - Misses         79       93      +14     
     Partials        8        8              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking-cli/pull/99?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/graphql/utils/adapter.go](https://codecov.io/gh/apache/skywalking-cli/pull/99/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2dyYXBocWwvdXRpbHMvYWRhcHRlci5nbw==) | `27.27% <0.00%> (-1.90%)` | :arrow_down: |
   | [pkg/graphql/utils/parser.go](https://codecov.io/gh/apache/skywalking-cli/pull/99/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2dyYXBocWwvdXRpbHMvcGFyc2VyLmdv) | `68.18% <0.00%> (-1.82%)` | :arrow_down: |
   | [pkg/display/table/table.go](https://codecov.io/gh/apache/skywalking-cli/pull/99/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Rpc3BsYXkvdGFibGUvdGFibGUuZ28=) | `100.00% <0.00%> (ø)` | |
   | [pkg/graphql/utils/constants.go](https://codecov.io/gh/apache/skywalking-cli/pull/99/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2dyYXBocWwvdXRpbHMvY29uc3RhbnRzLmdv) | `0.00% <0.00%> (ø)` | |
   | [internal/commands/interceptor/event.go](https://codecov.io/gh/apache/skywalking-cli/pull/99/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvY29tbWFuZHMvaW50ZXJjZXB0b3IvZXZlbnQuZ28=) | `100.00% <0.00%> (ø)` | |
   | [internal/commands/interceptor/entity.go](https://codecov.io/gh/apache/skywalking-cli/pull/99/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvY29tbWFuZHMvaW50ZXJjZXB0b3IvZW50aXR5Lmdv) | `0.00% <0.00%> (ø)` | |
   | [internal/commands/interceptor/timezone.go](https://codecov.io/gh/apache/skywalking-cli/pull/99/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvY29tbWFuZHMvaW50ZXJjZXB0b3IvdGltZXpvbmUuZ28=) | `0.00% <0.00%> (ø)` | |
   | [internal/commands/interceptor/interceptor.go](https://codecov.io/gh/apache/skywalking-cli/pull/99/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvY29tbWFuZHMvaW50ZXJjZXB0b3IvaW50ZXJjZXB0b3IuZ28=) | `0.00% <0.00%> (ø)` | |
   | [internal/commands/interceptor/duration.go](https://codecov.io/gh/apache/skywalking-cli/pull/99/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvY29tbWFuZHMvaW50ZXJjZXB0b3IvZHVyYXRpb24uZ28=) | `49.05% <0.00%> (+3.22%)` | :arrow_up: |
   | [pkg/display/json/json.go](https://codecov.io/gh/apache/skywalking-cli/pull/99/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Rpc3BsYXkvanNvbi9qc29uLmdv) | `66.66% <0.00%> (+6.66%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/skywalking-cli/pull/99/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/99?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/99?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [21ba64d...20145d9](https://codecov.io/gh/apache/skywalking-cli/pull/99?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org