You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2023/09/05 14:57:02 UTC
[GitHub] [maven] cstamas opened a new pull request, #1224: [MNG-7870] Undeprecate G level metadata
cstamas opened a new pull request, #1224:
URL: https://github.com/apache/maven/pull/1224
The modello generated classes should not be deprecated, and they are in use.
---
https://issues.apache.org/jira/browse/MNG-7870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #1224: [MNG-7870] Undeprecate G level metadata
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1224:
URL: https://github.com/apache/maven/pull/1224#issuecomment-1708247622
Closed by mistake, reopened
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #1224: [MNG-7870] Undeprecate G level metadata
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1224:
URL: https://github.com/apache/maven/pull/1224#issuecomment-1707855200
My point is, that the related code change simply made G level metadata work the "same way" as GA and GAV level metadata worked: user needs not to manage it, it all happens transparently from user POV, is done by resolver "behind the curtains", without user interaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on a diff in pull request #1224: [MNG-7870] Undeprecate G level metadata
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #1224:
URL: https://github.com/apache/maven/pull/1224#discussion_r1317120384
##########
maven-repository-metadata/src/site/apt/index.apt:
##########
@@ -27,38 +27,8 @@ Maven Repository Metadata Model
This is strictly the model for Maven Repository Metadata, so really just plain objects.
- The metadata file name is:
-
- * <<<maven-metadata.xml>>> in a remote repository,
-
- * <<<maven-metadata-\<repo-id>.xml>>> in a local repository, for metadata from a repository with <<<repo-id>>> identifier.
-
- []
-
- Depending on what the directory represents ("groupId", "groupId/artifactId" or "groupId/artifactId/version"),
- the Maven Repository Metadata file contains 3 different sets of metadata:
-
- [[1]] in a "groupId" directory: a "groupId" directory may contain Maven plugins artifacts, which are described in metadata's <<<plugins>>> element,
-
- [[2]] in a "groupId/artifactId" directory: metadata describes <<<groupId>>>, <<<artifactId>>> and <<<versioning>>> element that
- gives data about available versions (<<<latest>>>, <<<release>>>, <<<versions>>> list and <<<lastUpdated>>>),
-
- [[3]] in a "groupId/artifactId/version" snapshot artifact directory: metadata describes <<<groupId>>>, <<<artifactId>>>, <<<version>>> (base version, i.e. ending in <<<-SNAPSHOT>>>) and
- <<<versioning>>> element that gives data about snaphot (<<<snapshot>>>, <<<lastUpdated>>> and <<<snapshotVersions>>> list). Notice that a
- release artifact directory is not expected to provide metadata.
-
- []
-
Review Comment:
If we document those things here, scattered (as filename is layout matter, caching names are LRM internal matters), this will just become yet another spot to update somewhere in the future, that I bet we will miss, directly leading just to even more "documentation deterioration"....
I mean, my original intent was to _remove_ IDE/compiler warning about use of (wrongly) deprecated classe., I will restore this page to it's original state, remove the deprecation message and add a link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #1224: [MNG-7870] Undeprecate G level metadata
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1224:
URL: https://github.com/apache/maven/pull/1224#issuecomment-1707840631
Yes, it was done as part of MNG-7055:
* https://github.com/apache/maven/pull/555 (master)
* https://github.com/apache/maven/pull/691 (port to maven-3.9.x)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on a diff in pull request #1224: [MNG-7870] Undeprecate G level metadata
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #1224:
URL: https://github.com/apache/maven/pull/1224#discussion_r1316315088
##########
maven-repository-metadata/src/site/apt/index.apt:
##########
@@ -54,11 +54,3 @@ Maven Repository Metadata Model
* {{{./apidocs/index.html}Java sources}} with Reader and Writers for the Xpp3 XML parser, to read and write <<<maven-metadata(-*).xml>>> files,
* a {{{./repository-metadata.html}Descriptor Reference}}.
-
- Notice: data about plugins in a directory representing a groupId is deprecated and will be removed in a future Maven version.
-~~ logic behind this:
-~~ 1. MNG-7266: maven-compat will be removed from future Maven version
-~~ 2. this will remove the code that updates plugins data: see MNG-7375/MPLUGIN-384 https://maven.apache.org/ref/3.8.4/maven-compat/apidocs/org/apache/maven/artifact/repository/metadata/GroupRepositoryMetadata.html
-~~ 3. this will lead to inconsistent data: removing it will be safer/more clear
-~~ but this logic still remains to be confirmed by clear consensus of the whole team
Review Comment:
No, this is plain wrong: assumes that two distinct things are "same thing" (maven-repository-metadata generated classes and maven-compat Metadata coming from Maven2, pre Aether times).
It blurs by mistake two distinct things, while they are not same (but their purpose WAS same, but latter should not be used anymore, while former is and should be used by resolver-provider ONLY)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] hboutemy commented on a diff in pull request #1224: [MNG-7870] Undeprecate G level metadata
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on code in PR #1224:
URL: https://github.com/apache/maven/pull/1224#discussion_r1317109620
##########
maven-repository-metadata/src/site/apt/index.apt:
##########
@@ -27,38 +27,8 @@ Maven Repository Metadata Model
This is strictly the model for Maven Repository Metadata, so really just plain objects.
- The metadata file name is:
-
- * <<<maven-metadata.xml>>> in a remote repository,
-
- * <<<maven-metadata-\<repo-id>.xml>>> in a local repository, for metadata from a repository with <<<repo-id>>> identifier.
-
- []
-
- Depending on what the directory represents ("groupId", "groupId/artifactId" or "groupId/artifactId/version"),
- the Maven Repository Metadata file contains 3 different sets of metadata:
-
- [[1]] in a "groupId" directory: a "groupId" directory may contain Maven plugins artifacts, which are described in metadata's <<<plugins>>> element,
-
- [[2]] in a "groupId/artifactId" directory: metadata describes <<<groupId>>>, <<<artifactId>>> and <<<versioning>>> element that
- gives data about available versions (<<<latest>>>, <<<release>>>, <<<versions>>> list and <<<lastUpdated>>>),
-
- [[3]] in a "groupId/artifactId/version" snapshot artifact directory: metadata describes <<<groupId>>>, <<<artifactId>>>, <<<version>>> (base version, i.e. ending in <<<-SNAPSHOT>>>) and
- <<<versioning>>> element that gives data about snaphot (<<<snapshot>>>, <<<lastUpdated>>> and <<<snapshotVersions>>> list). Notice that a
- release artifact directory is not expected to provide metadata.
-
- []
-
Review Comment:
I really prefer keeping this explanation here (for example the local repository filename is specific)
but yes, adding a link to https://maven.apache.org/repositories/metadata.html is useful
we always have feelings about what goes to release documentation from code vs what goes to main Maven site: both have an interest, it's useful to cross link more than having one swallow the other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] hboutemy commented on a diff in pull request #1224: [MNG-7870] Undeprecate G level metadata
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on code in PR #1224:
URL: https://github.com/apache/maven/pull/1224#discussion_r1321083887
##########
maven-repository-metadata/src/site/apt/index.apt:
##########
@@ -27,38 +27,8 @@ Maven Repository Metadata Model
This is strictly the model for Maven Repository Metadata, so really just plain objects.
- The metadata file name is:
-
- * <<<maven-metadata.xml>>> in a remote repository,
-
- * <<<maven-metadata-\<repo-id>.xml>>> in a local repository, for metadata from a repository with <<<repo-id>>> identifier.
-
- []
-
- Depending on what the directory represents ("groupId", "groupId/artifactId" or "groupId/artifactId/version"),
- the Maven Repository Metadata file contains 3 different sets of metadata:
-
- [[1]] in a "groupId" directory: a "groupId" directory may contain Maven plugins artifacts, which are described in metadata's <<<plugins>>> element,
-
- [[2]] in a "groupId/artifactId" directory: metadata describes <<<groupId>>>, <<<artifactId>>> and <<<versioning>>> element that
- gives data about available versions (<<<latest>>>, <<<release>>>, <<<versions>>> list and <<<lastUpdated>>>),
-
- [[3]] in a "groupId/artifactId/version" snapshot artifact directory: metadata describes <<<groupId>>>, <<<artifactId>>>, <<<version>>> (base version, i.e. ending in <<<-SNAPSHOT>>>) and
- <<<versioning>>> element that gives data about snaphot (<<<snapshot>>>, <<<lastUpdated>>> and <<<snapshotVersions>>> list). Notice that a
- release artifact directory is not expected to provide metadata.
-
- []
-
Review Comment:
sorry, I finally overlooked the last update: I think we have the best of every world now, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on a diff in pull request #1224: [MNG-7870] Undeprecate G level metadata
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #1224:
URL: https://github.com/apache/maven/pull/1224#discussion_r1317126822
##########
maven-repository-metadata/src/site/apt/index.apt:
##########
@@ -27,38 +27,8 @@ Maven Repository Metadata Model
This is strictly the model for Maven Repository Metadata, so really just plain objects.
- The metadata file name is:
-
- * <<<maven-metadata.xml>>> in a remote repository,
-
- * <<<maven-metadata-\<repo-id>.xml>>> in a local repository, for metadata from a repository with <<<repo-id>>> identifier.
-
- []
-
- Depending on what the directory represents ("groupId", "groupId/artifactId" or "groupId/artifactId/version"),
- the Maven Repository Metadata file contains 3 different sets of metadata:
-
- [[1]] in a "groupId" directory: a "groupId" directory may contain Maven plugins artifacts, which are described in metadata's <<<plugins>>> element,
-
- [[2]] in a "groupId/artifactId" directory: metadata describes <<<groupId>>>, <<<artifactId>>> and <<<versioning>>> element that
- gives data about available versions (<<<latest>>>, <<<release>>>, <<<versions>>> list and <<<lastUpdated>>>),
-
- [[3]] in a "groupId/artifactId/version" snapshot artifact directory: metadata describes <<<groupId>>>, <<<artifactId>>>, <<<version>>> (base version, i.e. ending in <<<-SNAPSHOT>>>) and
- <<<versioning>>> element that gives data about snaphot (<<<snapshot>>>, <<<lastUpdated>>> and <<<snapshotVersions>>> list). Notice that a
- release artifact directory is not expected to provide metadata.
-
- []
-
Review Comment:
Pushed a change that removes (wrong) sentence about deprecation (along with comments), and added link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas closed pull request #1224: [MNG-7870] Undeprecate G level metadata
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas closed pull request #1224: [MNG-7870] Undeprecate G level metadata
URL: https://github.com/apache/maven/pull/1224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] hboutemy commented on a diff in pull request #1224: [MNG-7870] Undeprecate G level metadata
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on code in PR #1224:
URL: https://github.com/apache/maven/pull/1224#discussion_r1316766835
##########
maven-repository-metadata/src/site/apt/index.apt:
##########
@@ -54,11 +54,3 @@ Maven Repository Metadata Model
* {{{./apidocs/index.html}Java sources}} with Reader and Writers for the Xpp3 XML parser, to read and write <<<maven-metadata(-*).xml>>> files,
* a {{{./repository-metadata.html}Descriptor Reference}}.
-
- Notice: data about plugins in a directory representing a groupId is deprecated and will be removed in a future Maven version.
-~~ logic behind this:
-~~ 1. MNG-7266: maven-compat will be removed from future Maven version
-~~ 2. this will remove the code that updates plugins data: see MNG-7375/MPLUGIN-384 https://maven.apache.org/ref/3.8.4/maven-compat/apidocs/org/apache/maven/artifact/repository/metadata/GroupRepositoryMetadata.html
-~~ 3. this will lead to inconsistent data: removing it will be safer/more clear
-~~ but this logic still remains to be confirmed by clear consensus of the whole team
Review Comment:
can we clarify what fills the (effectively non-deprecated) metadata? And when Maven was fixed to update this metadata?
because this is the part that is not clear to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #1224: [MNG-7870] Undeprecate G level metadata
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1224:
URL: https://github.com/apache/maven/pull/1224#issuecomment-1708247331
ping?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas merged pull request #1224: [MNG-7870] Undeprecate G level metadata
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #1224:
URL: https://github.com/apache/maven/pull/1224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #1224: [MNG-7870] Undeprecate G level metadata
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1224:
URL: https://github.com/apache/maven/pull/1224#issuecomment-1707871954
And finally, i find this page (rendered as part of maven-repository-metadata site) a bit anemic, and IMHO missing the point: https://maven.apache.org/ref/3.9.4/maven-repository-metadata/index.html
Especially when I put it next to this page:
https://maven.apache.org/repositories/metadata.html
Former page, that is about maven-repository-metadata module (that contains ONLY the modello generated model classes) talks about "local" and "remote" metadata, that is totally irrelevant, and none of those things happens in given module. The "metadata file names" are irrelevant (are defined by layout), and page https://maven.apache.org/repositories/metadata.html IMHO describes much better all of it (from remote repo aspect, it does not mention "locally cached" metadata either).
So, I'd propose to modify page even more, and just keep this:
```
# Maven Repository Metadata Model
This is strictly the model for Maven Repository Metadata, so really just plain objects.
The following are generated from this model:
* [Java sources](https://maven.apache.org/ref/3.9.4/maven-repository-metadata/apidocs/index.html) with Reader and Writers for the Xpp3 XML parser, to read and write maven-metadata(-*).xml files,
* a [Descriptor Reference](https://maven.apache.org/ref/3.9.4/maven-repository-metadata/repository-metadata.html).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on a diff in pull request #1224: [MNG-7870] Undeprecate G level metadata
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #1224:
URL: https://github.com/apache/maven/pull/1224#discussion_r1316874385
##########
maven-repository-metadata/src/site/apt/index.apt:
##########
@@ -54,11 +54,3 @@ Maven Repository Metadata Model
* {{{./apidocs/index.html}Java sources}} with Reader and Writers for the Xpp3 XML parser, to read and write <<<maven-metadata(-*).xml>>> files,
* a {{{./repository-metadata.html}Descriptor Reference}}.
-
- Notice: data about plugins in a directory representing a groupId is deprecated and will be removed in a future Maven version.
-~~ logic behind this:
-~~ 1. MNG-7266: maven-compat will be removed from future Maven version
-~~ 2. this will remove the code that updates plugins data: see MNG-7375/MPLUGIN-384 https://maven.apache.org/ref/3.8.4/maven-compat/apidocs/org/apache/maven/artifact/repository/metadata/GroupRepositoryMetadata.html
-~~ 3. this will lead to inconsistent data: removing it will be safer/more clear
-~~ but this logic still remains to be confirmed by clear consensus of the whole team
Review Comment:
It was done on master (https://github.com/apache/maven/pull/555) and ported to maven-3.9.x (https://github.com/apache/maven/pull/691)
The code is (and should remain) confined in maven-resolver-provider, as it "hooks" into resolver https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/impl/MetadataGeneratorFactory.java and does the job by simply inspecting the payload. Also notice that all this code is package protected (again, as this happens by "hooking into resolver, and is not an API that one should tamper/call").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on a diff in pull request #1224: [MNG-7870] Undeprecate G level metadata
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #1224:
URL: https://github.com/apache/maven/pull/1224#discussion_r1316279964
##########
maven-repository-metadata/src/site/apt/index.apt:
##########
@@ -54,11 +54,3 @@ Maven Repository Metadata Model
* {{{./apidocs/index.html}Java sources}} with Reader and Writers for the Xpp3 XML parser, to read and write <<<maven-metadata(-*).xml>>> files,
* a {{{./repository-metadata.html}Descriptor Reference}}.
-
- Notice: data about plugins in a directory representing a groupId is deprecated and will be removed in a future Maven version.
-~~ logic behind this:
-~~ 1. MNG-7266: maven-compat will be removed from future Maven version
-~~ 2. this will remove the code that updates plugins data: see MNG-7375/MPLUGIN-384 https://maven.apache.org/ref/3.8.4/maven-compat/apidocs/org/apache/maven/artifact/repository/metadata/GroupRepositoryMetadata.html
-~~ 3. this will lead to inconsistent data: removing it will be safer/more clear
-~~ but this logic still remains to be confirmed by clear consensus of the whole team
Review Comment:
IIUC, this is not wrong, but just too early, right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org