You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/25 15:00:57 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #37660: [WIP][SPARK-40220][SQL] Don't output the empty map of error message parameters
MaxGekk opened a new pull request, #37660:
URL: https://github.com/apache/spark/pull/37660
### What changes were proposed in this pull request?
In the PR, I propose to output the JSON map `messageParameters` of error messages in the MINIMAL and STANDARD formats only when the map is not empty.
### Why are the changes needed?
To be consistent w/ output of other JSON fields of error messages.
### Does this PR introduce _any_ user-facing change?
Yes. The PR can change user-facing error message in the MINIMAL and STANDARD formats of error messages.
### How was this patch tested?
By running the affected test suites:
```
$ build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #37660: [SPARK-40220][SQL] Don't output the empty map of error message parameters
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #37660: [SPARK-40220][SQL] Don't output the empty map of error message parameters
URL: https://github.com/apache/spark/pull/37660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37660: [SPARK-40220][SQL] Don't output the empty map of error message parameters
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37660:
URL: https://github.com/apache/spark/pull/37660#issuecomment-1227535141
@srielau @anchovYu Please, have a look at the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37660: [SPARK-40220][SQL] Don't output the empty map of error message parameters
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37660:
URL: https://github.com/apache/spark/pull/37660#issuecomment-1228153950
Merging to master. Thank you, @srielau @cloud-fan for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org