You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/02 12:40:57 UTC
[GitHub] [superset] villebro opened a new pull request #12890: fix(explore): missing select when groupby without metrics
villebro opened a new pull request #12890:
URL: https://github.com/apache/superset/pull/12890
### SUMMARY
When a query has a `groupby` without a metric, the `groupby` columns don't show up in the query.
### TEST PLAN
Local testing of all examples dashboards + CI
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12890: fix(explore): missing select when groupby without metrics
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12890:
URL: https://github.com/apache/superset/pull/12890#issuecomment-771811086
Thanks for the fix and sorry for the inconvenience!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12890: fix(explore): missing select when groupby without metrics
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12890:
URL: https://github.com/apache/superset/pull/12890#issuecomment-771645442
# [Codecov](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=h1) Report
> Merging [#12890](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=desc) (022d4b5) into [master](https://codecov.io/gh/apache/superset/commit/2adfb8559736bff97b47c6fee2725b4344c4ebf3?el=desc) (2adfb85) will **decrease** coverage by `1.24%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12890 +/- ##
==========================================
- Coverage 64.89% 63.65% -1.25%
==========================================
Files 1024 489 -535
Lines 50168 30185 -19983
Branches 5148 0 -5148
==========================================
- Hits 32557 19214 -13343
+ Misses 17433 10971 -6462
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.65% <100.00%> (-0.43%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.65% <100.00%> (-0.93%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `93.42% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [533 more](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=footer). Last update [38a21bf...022d4b5](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12890: fix(explore): missing select when groupby without metrics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12890:
URL: https://github.com/apache/superset/pull/12890#issuecomment-771645442
# [Codecov](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=h1) Report
> Merging [#12890](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=desc) (022d4b5) into [master](https://codecov.io/gh/apache/superset/commit/2adfb8559736bff97b47c6fee2725b4344c4ebf3?el=desc) (2adfb85) will **decrease** coverage by `1.91%`.
> The diff coverage is `38.86%`.
[](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12890 +/- ##
==========================================
- Coverage 64.89% 62.97% -1.92%
==========================================
Files 1024 1024
Lines 50168 50245 +77
Branches 5148 5241 +93
==========================================
- Hits 32557 31644 -913
- Misses 17433 18389 +956
- Partials 178 212 +34
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.84% <38.54%> (-0.07%)` | :arrow_down: |
| python | `63.73% <100.00%> (-0.35%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `34.78% <0.00%> (-4.35%)` | :arrow_down: |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `69.74% <ø> (-0.16%)` | :arrow_down: |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `34.78% <ø> (-26.09%)` | :arrow_down: |
| [...src/filters/components/Select/AntdSelectFilter.tsx](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvQW50ZFNlbGVjdEZpbHRlci50c3g=) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/filters/utils.ts](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvdXRpbHMudHM=) | `88.88% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (-67.65%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.ts](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLnRz) | `0.00% <0.00%> (ø)` | |
| [...hboard/components/nativeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvQ2FzY2FkZVBvcG92ZXIudHN4) | `19.11% <7.69%> (+0.93%)` | :arrow_up: |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `51.36% <30.00%> (+2.32%)` | :arrow_up: |
| ... and [124 more](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=footer). Last update [38a21bf...022d4b5](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12890: fix(explore): missing select when groupby without metrics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12890:
URL: https://github.com/apache/superset/pull/12890#issuecomment-771645442
# [Codecov](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=h1) Report
> Merging [#12890](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=desc) (022d4b5) into [master](https://codecov.io/gh/apache/superset/commit/2adfb8559736bff97b47c6fee2725b4344c4ebf3?el=desc) (2adfb85) will **decrease** coverage by `1.19%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12890 +/- ##
==========================================
- Coverage 64.89% 63.70% -1.20%
==========================================
Files 1024 489 -535
Lines 50168 30185 -19983
Branches 5148 0 -5148
==========================================
- Hits 32557 19228 -13329
+ Misses 17433 10957 -6476
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.70% <100.00%> (-0.39%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.57% <100.00%> (-0.02%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `93.42% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.79% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [529 more](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=footer). Last update [38a21bf...022d4b5](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12890: fix(explore): missing select when groupby without metrics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12890:
URL: https://github.com/apache/superset/pull/12890#issuecomment-771645442
# [Codecov](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=h1) Report
> Merging [#12890](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=desc) (022d4b5) into [master](https://codecov.io/gh/apache/superset/commit/2adfb8559736bff97b47c6fee2725b4344c4ebf3?el=desc) (2adfb85) will **decrease** coverage by `1.84%`.
> The diff coverage is `38.86%`.
[](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12890 +/- ##
==========================================
- Coverage 64.89% 63.05% -1.85%
==========================================
Files 1024 1024
Lines 50168 50245 +77
Branches 5148 5241 +93
==========================================
- Hits 32557 31680 -877
- Misses 17433 18353 +920
- Partials 178 212 +34
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.84% <38.54%> (-0.07%)` | :arrow_down: |
| python | `63.85% <100.00%> (-0.24%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `34.78% <0.00%> (-4.35%)` | :arrow_down: |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `69.74% <ø> (-0.16%)` | :arrow_down: |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `34.78% <ø> (-26.09%)` | :arrow_down: |
| [...src/filters/components/Select/AntdSelectFilter.tsx](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvQW50ZFNlbGVjdEZpbHRlci50c3g=) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/filters/utils.ts](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvdXRpbHMudHM=) | `88.88% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (-67.65%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.ts](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLnRz) | `0.00% <0.00%> (ø)` | |
| [...hboard/components/nativeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvQ2FzY2FkZVBvcG92ZXIudHN4) | `19.11% <7.69%> (+0.93%)` | :arrow_up: |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `51.36% <30.00%> (+2.32%)` | :arrow_up: |
| ... and [122 more](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=footer). Last update [38a21bf...022d4b5](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #12890: fix(explore): missing select when groupby without metrics
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #12890:
URL: https://github.com/apache/superset/pull/12890
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12890: fix(explore): missing select when groupby without metrics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12890:
URL: https://github.com/apache/superset/pull/12890#issuecomment-771645442
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12890: fix(explore): missing select when groupby without metrics
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12890:
URL: https://github.com/apache/superset/pull/12890#issuecomment-771811086
Thanks for the fix and sorry for the inconvenience!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #12890: fix(explore): missing select when groupby without metrics
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #12890:
URL: https://github.com/apache/superset/pull/12890
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12890: fix(explore): missing select when groupby without metrics
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12890:
URL: https://github.com/apache/superset/pull/12890#issuecomment-771645442
# [Codecov](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=h1) Report
> Merging [#12890](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=desc) (022d4b5) into [master](https://codecov.io/gh/apache/superset/commit/2adfb8559736bff97b47c6fee2725b4344c4ebf3?el=desc) (2adfb85) will **decrease** coverage by `1.24%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12890 +/- ##
==========================================
- Coverage 64.89% 63.65% -1.25%
==========================================
Files 1024 489 -535
Lines 50168 30185 -19983
Branches 5148 0 -5148
==========================================
- Hits 32557 19214 -13343
+ Misses 17433 10971 -6462
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.65% <100.00%> (-0.43%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.65% <100.00%> (-0.93%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `93.42% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [533 more](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=footer). Last update [38a21bf...022d4b5](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12890: fix(explore): missing select when groupby without metrics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12890:
URL: https://github.com/apache/superset/pull/12890#issuecomment-771645442
# [Codecov](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=h1) Report
> Merging [#12890](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=desc) (022d4b5) into [master](https://codecov.io/gh/apache/superset/commit/2adfb8559736bff97b47c6fee2725b4344c4ebf3?el=desc) (2adfb85) will **decrease** coverage by `1.93%`.
> The diff coverage is `38.86%`.
[](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12890 +/- ##
==========================================
- Coverage 64.89% 62.96% -1.94%
==========================================
Files 1024 1024
Lines 50168 50230 +62
Branches 5148 5241 +93
==========================================
- Hits 32557 31625 -932
- Misses 17433 18393 +960
- Partials 178 212 +34
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.84% <38.54%> (-0.07%)` | :arrow_down: |
| python | `63.70% <100.00%> (-0.39%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `34.78% <0.00%> (-4.35%)` | :arrow_down: |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `69.74% <ø> (-0.16%)` | :arrow_down: |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `34.78% <ø> (-26.09%)` | :arrow_down: |
| [...src/filters/components/Select/AntdSelectFilter.tsx](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvQW50ZFNlbGVjdEZpbHRlci50c3g=) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/filters/utils.ts](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvdXRpbHMudHM=) | `88.88% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (-67.65%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.ts](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLnRz) | `0.00% <0.00%> (ø)` | |
| [...hboard/components/nativeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvQ2FzY2FkZVBvcG92ZXIudHN4) | `19.11% <7.69%> (+0.93%)` | :arrow_up: |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `51.36% <30.00%> (+2.32%)` | :arrow_up: |
| ... and [135 more](https://codecov.io/gh/apache/superset/pull/12890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=footer). Last update [38a21bf...022d4b5](https://codecov.io/gh/apache/superset/pull/12890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org