[GitHub] [incubator-tvm] masahi commented on pull request #6900: PyTorch frontend: make type inference incremental

[GitBox <gi...@apache.org>]

masahi commented on pull request #6900:
URL: https://github.com/apache/incubator-tvm/pull/6900#issuecomment-725871111


   > The other question is whether we would want to make the translator a use a class interface so that the type inference can directly access the outputs' types.
   
   Yes we can consider this approach. Initially I thought function-only approach would be cleaner (e.g. for recursively converting blocks in `If` and `Loop`) but this resulted in passing various constants such as `convert_map`, `prelude`, `default_dtype` etc around each function. 
   
   We can introduce a global object (like a class) to hold these constants. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org