[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #983: Fix: fix client error message #972

[GitBox <gi...@apache.org>]

AlexStocks commented on a change in pull request #983:
URL: https://github.com/apache/dubbo-go/pull/983#discussion_r551306448



##########
File path: remoting/getty/getty_client.go
##########
@@ -38,9 +38,9 @@ import (
 )
 
 var (
-	errSessionNotExist   = perrors.New("session not exist")
-	errClientClosed      = perrors.New("client closed")
-	errClientReadTimeout = perrors.New("client read timeout")
+	errSessionNotExist               = perrors.New("session not exist")
+	errClientClosed                  = perrors.New("client closed")
+	errClientReadTimeoutOrDecoedFail = perrors.New("client read timeout or decode pkg fail")

Review comment:
       Decoed？ may be  it should be decoded?

##########
File path: remoting/getty/getty_client.go
##########
@@ -38,9 +38,9 @@ import (
 )
 
 var (
-	errSessionNotExist   = perrors.New("session not exist")
-	errClientClosed      = perrors.New("client closed")
-	errClientReadTimeout = perrors.New("client read timeout")
+	errSessionNotExist               = perrors.New("session not exist")
+	errClientClosed                  = perrors.New("client closed")
+	errClientReadTimeoutOrDecoedFail = perrors.New("client read timeout or decode pkg fail")

Review comment:
       "client read timeout or decode pkg fail" --> "maybe the client read timeout or fail to decode tcp stream in Writer.Write"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org