You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/12/11 08:38:40 UTC

[GitHub] [mynewt-core] brianwyld commented on a change in pull request #2106: PR for 3 changes : NDEBUG build, fix SPI on STM32, bitbang uart tx only

brianwyld commented on a change in pull request #2106: PR for 3 changes : NDEBUG build, fix SPI on STM32, bitbang uart tx only
URL: https://github.com/apache/mynewt-core/pull/2106#discussion_r356460888
 
 

 ##########
 File path: hw/mcu/stm/stm32_common/src/hal_uart.c
 ##########
 @@ -24,6 +24,7 @@
 #include "bsp/bsp.h"
 #include <assert.h>
 #include <stdlib.h>
+#include "os/mynewt.h"
 
 Review comment:
   I confirm this file did not include os/mynewt.h (and hence does not compile if NDEBUG is defined)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services