You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Joe Stein <cr...@gmail.com> on 2014/01/15 23:59:28 UTC
Review Request 16923: Patch for KAFKA-1206
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16923/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1206
https://issues.apache.org/jira/browse/KAFKA-1206
Repository: kafka
Description
-------
KAFKA-1206 allow Kafka to start from a resource negotiator system
Diffs
-----
core/src/main/scala/kafka/Kafka.scala 988014a51c332ba04609ee7fbb06f0b09546f267
Diff: https://reviews.apache.org/r/16923/diff/
Testing
-------
Thanks,
Joe Stein
Re: Review Request 16923: Patch for KAFKA-1206
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16923/#review34829
-----------------------------------------------------------
I'm no Kafka/Scala expert, but I'm interested in seeing Kafka on Mesos, so here are my few comments.
core/src/main/scala/kafka/Kafka.scala
<https://reviews.apache.org/r/16923/#comment65204>
s/Startble/Startable/
core/src/main/scala/kafka/Kafka.scala
<https://reviews.apache.org/r/16923/#comment65203>
May not need the try around the args.length check, just the launch() call.
core/src/main/scala/kafka/Kafka.scala
<https://reviews.apache.org/r/16923/#comment65202>
s/ressource/resource/
- Adam B
On Jan. 15, 2014, 9:40 p.m., Joe Stein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16923/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 9:40 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1206
> https://issues.apache.org/jira/browse/KAFKA-1206
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1206 we don't need the mesos jar for this change
>
>
> KAFKA-1206 we don't need the mesos jar for this change
>
>
> Merge branch 'trunk' of https://git-wip-us.apache.org/repos/asf/kafka into KAFKA-1206
>
>
> KAFKA-1206 allow Kafka to start from a resource negotiator system
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/Kafka.scala 988014a51c332ba04609ee7fbb06f0b09546f267
>
> Diff: https://reviews.apache.org/r/16923/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joe Stein
>
>
Re: Review Request 16923: Patch for KAFKA-1206
Posted by Joe Stein <cr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16923/
-----------------------------------------------------------
(Updated Jan. 16, 2014, 5:40 a.m.)
Review request for kafka.
Bugs: KAFKA-1206
https://issues.apache.org/jira/browse/KAFKA-1206
Repository: kafka
Description (updated)
-------
KAFKA-1206 we don't need the mesos jar for this change
KAFKA-1206 we don't need the mesos jar for this change
Merge branch 'trunk' of https://git-wip-us.apache.org/repos/asf/kafka into KAFKA-1206
KAFKA-1206 allow Kafka to start from a resource negotiator system
Diffs (updated)
-----
core/src/main/scala/kafka/Kafka.scala 988014a51c332ba04609ee7fbb06f0b09546f267
Diff: https://reviews.apache.org/r/16923/diff/
Testing
-------
Thanks,
Joe Stein
Re: Review Request 16923: Patch for KAFKA-1206
Posted by Joe Stein <cr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16923/
-----------------------------------------------------------
(Updated Jan. 16, 2014, 5:39 a.m.)
Review request for kafka.
Bugs: KAFKA-1206
https://issues.apache.org/jira/browse/KAFKA-1206
Repository: kafka
Description (updated)
-------
KAFKA-1206 we don't need the mesos jar for this change
Merge branch 'trunk' of https://git-wip-us.apache.org/repos/asf/kafka into KAFKA-1206
KAFKA-1206 allow Kafka to start from a resource negotiator system
Diffs (updated)
-----
core/build.sbt b5bcb44f783ae6fe2cfdc091e53e867a56a1e592
core/src/main/scala/kafka/Kafka.scala 988014a51c332ba04609ee7fbb06f0b09546f267
Diff: https://reviews.apache.org/r/16923/diff/
Testing
-------
Thanks,
Joe Stein
Re: Review Request 16923: Patch for KAFKA-1206
Posted by Joe Stein <cr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16923/
-----------------------------------------------------------
(Updated Jan. 16, 2014, 5:37 a.m.)
Review request for kafka.
Bugs: KAFKA-1206
https://issues.apache.org/jira/browse/KAFKA-1206
Repository: kafka
Description (updated)
-------
Merge branch 'trunk' of https://git-wip-us.apache.org/repos/asf/kafka into KAFKA-1206
KAFKA-1206 allow Kafka to start from a resource negotiator system
Diffs (updated)
-----
core/src/main/scala/kafka/Kafka.scala 988014a51c332ba04609ee7fbb06f0b09546f267
Diff: https://reviews.apache.org/r/16923/diff/
Testing
-------
Thanks,
Joe Stein