You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/06 06:26:34 UTC
[GitHub] [pulsar] leizhiyuan opened a new issue, #15038: produce message supports rate limit in fail-fast
leizhiyuan opened a new issue, #15038:
URL: https://github.com/apache/pulsar/issues/15038
**Is your feature request related to a problem? Please describe.**
now if one topic was rate limited, we will use disableCnxAutoRead, which will not read data from buffer.
one topic sends a message in t1, we disabled then, and in t2, we start to read, and processed (maybe t2-t1 > the timeout of users)
but when we processed in t3, when we send result to producer, it is timeout.
**Describe the solution you'd like**
we can choose the rate limit stratery, failfast or disableautoread
**Describe alternatives you've considered**
implement the fail fast mode, when rate limited, we will send servererror to producer
**Additional context**
Add any other context or screenshots about the feature request here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tjiuming commented on issue #15038: produce message supports rate limit in fail-fast
Posted by GitBox <gi...@apache.org>.
tjiuming commented on issue #15038:
URL: https://github.com/apache/pulsar/issues/15038#issuecomment-1091067965
You mean when broker in rate-limit, provide a new strategy, fail-fast instead of disableAutoRead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tjiuming commented on issue #15038: produce message supports rate limit in fail-fast
Posted by GitBox <gi...@apache.org>.
tjiuming commented on issue #15038:
URL: https://github.com/apache/pulsar/issues/15038#issuecomment-1091066669
I've read the issue carefully, there is one question:
When broker disable auto-read, how could broker know reply ServerError to which request? Those requests pending in buffer and they even not be read.
Actually, in client side already has flow-control, when there are too many requests in pending, new requests will be rejected directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tjiuming commented on issue #15038: produce message supports rate limit in fail-fast
Posted by GitBox <gi...@apache.org>.
tjiuming commented on issue #15038:
URL: https://github.com/apache/pulsar/issues/15038#issuecomment-1091070532
> > You mean when broker in rate-limit, provide a new strategy, fail-fast instead of disableAutoRead?
>
> yes，then cleint can know they are limited，maybe they will receive an exception （ratelimtexception）
It makes sence, I'd like to handle it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #15038: produce message supports rate limit in fail-fast
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #15038:
URL: https://github.com/apache/pulsar/issues/15038#issuecomment-1148116529
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] leizhiyuan commented on issue #15038: produce message supports rate limit in fail-fast
Posted by GitBox <gi...@apache.org>.
leizhiyuan commented on issue #15038:
URL: https://github.com/apache/pulsar/issues/15038#issuecomment-1091069663
> You mean when broker in rate-limit, provide a new strategy, fail-fast instead of disableAutoRead?
yes，then cleint can know they are limited，maybe they will receive an exception （ratelimtexception）
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #15038: produce message supports rate limit in fail-fast
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #15038:
URL: https://github.com/apache/pulsar/issues/15038#issuecomment-1120334268
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tjiuming commented on issue #15038: produce message supports rate limit in fail-fast
Posted by GitBox <gi...@apache.org>.
tjiuming commented on issue #15038:
URL: https://github.com/apache/pulsar/issues/15038#issuecomment-1090381365
seems that there are no back pressure control in client side? Generally, before send a message, client needs to ensure `channel` is writable(io.netty.channel.Channel#isWritale).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tjiuming commented on issue #15038: produce message supports rate limit in fail-fast
Posted by GitBox <gi...@apache.org>.
tjiuming commented on issue #15038:
URL: https://github.com/apache/pulsar/issues/15038#issuecomment-1091045798
@leizhiyuan I'd like to handle the issue and I’ll send a discuss to community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org