You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Ondrej Florian <on...@gmail.com> on 2013/05/08 19:26:13 UTC
support for JSTL 1.2
Hi,
I'd like to contribute pom.xml for JSTL 1.2.1.
As far as I can see, the Sling supports 1.1.2 at the moment which doesn't seem to work with the JSP EL.
Re: support for JSTL 1.2 (SLING-2648)
Posted by Ondrej Florian <on...@gmail.com>.
another issue is with the function declarations
OLD
<function>
<name>findResources</name>
<function-class>org.apache.sling.scripting.jsp.taglib.SlingFunctions
</function-class>
<function-signature>java.util.Iterator
findResources(org.apache.sling.api.resource.ResourceResolver,
java.lang.String, java.lang.String)
</function-signature>
</function>
NEW
<function>
<name>findResources</name>
<function-class>org.apache.sling.scripting.jsp.taglib.SlingFunctions</function-class>
<function-signature>java.util.Iterator findResources(org.apache.sling.api.resource.ResourceResolver, java.lang.String, java.lang.String)</function-signature>
</function>
==> the function-signature must be on the same line
...so should I fix these issues as well?
Ondrej
On 8 May 2013, at 22:48, Dan Klco <da...@sixdimensions.com> wrote:
> Ondrej,
>
> From the code snippet you specified it looks like the version attribute and the XSD version did not match in the old copy of the code. I would image that would be the source of the issue you described.
>
> -Dan
>
> -----Original Message-----
> From: Ondrej Florian [mailto:onflapp@gmail.com]
> Sent: Wednesday, May 08, 2013 4:36 PM
> To: dev@sling.apache.org
> Subject: Re: support for JSTL 1.2 (SLING-2648)
>
> Hi Dan,
>
> I am also facing problems getting 'resource tags' working (https://issues.apache.org/jira/browse/SLING-2648).
> I ended up changing the taglib tld which seem to fix the problem.
>
> ...I am just wondering whether these are genuine bugs I am facing or whether there is something wrong with my build (I did a clean checkout and build today)
>
> OLD:
> <taglib xmlns="http://java.sun.com/xml/ns/j2ee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> xsi:schemaLocation="http://java.sun.com/xml/ns/javaee/web-jsptaglibrary_2_1.xsd"
> version="2.0">
>
> NEW:
> <taglib xmlns="http://java.sun.com/xml/ns/j2ee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/web-jsptaglibrary_2_1.xsd"
> version="2.1">
>
>
>
> On 8 May 2013, at 21:42, Dan Klco <da...@sixdimensions.com> wrote:
>
>> Ondrej,
>>
>> This sounds interesting, though it seems like Expression Language support was added in JSTL 1.1, so it should be supported currently. Could you please create an issue and attach a patch file for the proposed change?
>>
>> It looks like the dependency being referenced is GlassFish's JSTL implementation, are there any concerns about including it as it is licensed under the CDDL (https://jstl.java.net/)?
>>
>> From what I have read, it seems like binaries licensed under the CDDL can be included in Apache projects, however since we re-wrap the Jar in a bundle I don't know if it might be problematic. Additionally, I think we will need to include a notice that a CDDL license work has been included in Sling:
>> http://www.apache.org/legal/3party.html#category-b
>>
>> -Dan
>>
>> -----Original Message-----
>> From: Ondrej Florian [mailto:onflapp@gmail.com]
>> Sent: Wednesday, May 08, 2013 1:26 PM
>> To: dev@sling.apache.org
>> Subject: support for JSTL 1.2
>>
>> Hi,
>>
>> I'd like to contribute pom.xml for JSTL 1.2.1.
>> As far as I can see, the Sling supports 1.1.2 at the moment which doesn't seem to work with the JSP EL.
>>
>>
>> -----
>> No virus found in this message.
>> Checked by AVG - www.avg.com
>> Version: 2013.0.3272 / Virus Database: 3162/6287 - Release Date: 04/30/13 Internal Virus Database is out of date.
>>
>
>
> -----
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 2013.0.3272 / Virus Database: 3162/6287 - Release Date: 04/30/13 Internal Virus Database is out of date.
>
RE: support for JSTL 1.2 (SLING-2648)
Posted by Dan Klco <da...@sixdimensions.com>.
Ondrej,
>From the code snippet you specified it looks like the version attribute and the XSD version did not match in the old copy of the code. I would image that would be the source of the issue you described.
-Dan
-----Original Message-----
From: Ondrej Florian [mailto:onflapp@gmail.com]
Sent: Wednesday, May 08, 2013 4:36 PM
To: dev@sling.apache.org
Subject: Re: support for JSTL 1.2 (SLING-2648)
Hi Dan,
I am also facing problems getting 'resource tags' working (https://issues.apache.org/jira/browse/SLING-2648).
I ended up changing the taglib tld which seem to fix the problem.
...I am just wondering whether these are genuine bugs I am facing or whether there is something wrong with my build (I did a clean checkout and build today)
OLD:
<taglib xmlns="http://java.sun.com/xml/ns/j2ee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee/web-jsptaglibrary_2_1.xsd"
version="2.0">
NEW:
<taglib xmlns="http://java.sun.com/xml/ns/j2ee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/web-jsptaglibrary_2_1.xsd"
version="2.1">
On 8 May 2013, at 21:42, Dan Klco <da...@sixdimensions.com> wrote:
> Ondrej,
>
> This sounds interesting, though it seems like Expression Language support was added in JSTL 1.1, so it should be supported currently. Could you please create an issue and attach a patch file for the proposed change?
>
> It looks like the dependency being referenced is GlassFish's JSTL implementation, are there any concerns about including it as it is licensed under the CDDL (https://jstl.java.net/)?
>
> From what I have read, it seems like binaries licensed under the CDDL can be included in Apache projects, however since we re-wrap the Jar in a bundle I don't know if it might be problematic. Additionally, I think we will need to include a notice that a CDDL license work has been included in Sling:
> http://www.apache.org/legal/3party.html#category-b
>
> -Dan
>
> -----Original Message-----
> From: Ondrej Florian [mailto:onflapp@gmail.com]
> Sent: Wednesday, May 08, 2013 1:26 PM
> To: dev@sling.apache.org
> Subject: support for JSTL 1.2
>
> Hi,
>
> I'd like to contribute pom.xml for JSTL 1.2.1.
> As far as I can see, the Sling supports 1.1.2 at the moment which doesn't seem to work with the JSP EL.
>
>
> -----
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 2013.0.3272 / Virus Database: 3162/6287 - Release Date: 04/30/13 Internal Virus Database is out of date.
>
-----
No virus found in this message.
Checked by AVG - www.avg.com
Version: 2013.0.3272 / Virus Database: 3162/6287 - Release Date: 04/30/13 Internal Virus Database is out of date.
Re: support for JSTL 1.2 (SLING-2648)
Posted by Ondrej Florian <on...@gmail.com>.
Hi Dan,
I am also facing problems getting 'resource tags' working (https://issues.apache.org/jira/browse/SLING-2648).
I ended up changing the taglib tld which seem to fix the problem.
...I am just wondering whether these are genuine bugs I am facing or whether there is something wrong with my build (I did a clean checkout and build today)
OLD:
<taglib xmlns="http://java.sun.com/xml/ns/j2ee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee/web-jsptaglibrary_2_1.xsd"
version="2.0">
NEW:
<taglib xmlns="http://java.sun.com/xml/ns/j2ee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/web-jsptaglibrary_2_1.xsd"
version="2.1">
On 8 May 2013, at 21:42, Dan Klco <da...@sixdimensions.com> wrote:
> Ondrej,
>
> This sounds interesting, though it seems like Expression Language support was added in JSTL 1.1, so it should be supported currently. Could you please create an issue and attach a patch file for the proposed change?
>
> It looks like the dependency being referenced is GlassFish's JSTL implementation, are there any concerns about including it as it is licensed under the CDDL (https://jstl.java.net/)?
>
> From what I have read, it seems like binaries licensed under the CDDL can be included in Apache projects, however since we re-wrap the Jar in a bundle I don't know if it might be problematic. Additionally, I think we will need to include a notice that a CDDL license work has been included in Sling:
> http://www.apache.org/legal/3party.html#category-b
>
> -Dan
>
> -----Original Message-----
> From: Ondrej Florian [mailto:onflapp@gmail.com]
> Sent: Wednesday, May 08, 2013 1:26 PM
> To: dev@sling.apache.org
> Subject: support for JSTL 1.2
>
> Hi,
>
> I'd like to contribute pom.xml for JSTL 1.2.1.
> As far as I can see, the Sling supports 1.1.2 at the moment which doesn't seem to work with the JSP EL.
>
>
> -----
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 2013.0.3272 / Virus Database: 3162/6287 - Release Date: 04/30/13 Internal Virus Database is out of date.
>
RE: support for JSTL 1.2
Posted by Dan Klco <da...@sixdimensions.com>.
Ondrej,
Entirely agreed. The 1.3 version of the taglibs is not yet released, so we can make changes as necessary.
Thanks,
Dan
-----Original Message-----
From: Ondrej Florian [mailto:onflapp@gmail.com]
Sent: Thursday, May 09, 2013 12:26 PM
To: dev@sling.apache.org
Subject: Re: support for JSTL 1.2
Many Thanks Dan,
just a little comment;
shouldn't we make the naming of functions / tags more consistent?
e.g. there is a function listChildResources but the tag is called listChildren
I know this is small thing, but I would try to make the naming to fit the one used by the Resource API whenever possible.
What do you think?
BTW: I can go through the code and make appropriate changes - if you agree
Ondrej
On 9 May 2013, at 17:11, Dan Klco <da...@sixdimensions.com> wrote:
> Ondrej,
>
> Thank you for all of the investigation and patch. I have tested and committed the patch you provided, it looks good.
>
> Please let me know if you find anything else. This new Resource Access Tag API is still pretty new.
>
> Thanks again!
>
> -Dan
>
> -----Original Message-----
> From: Ondrej Florian [mailto:onflapp@gmail.com]
> Sent: Thursday, May 09, 2013 9:17 AM
> To: dev@sling.apache.org
> Subject: Re: support for JSTL 1.2
>
> Hi Dan,
>
> I backtracked and re-tested everything again, and yes you are right, the JSTL 1.1 should be sufficient (it works with the EL and the functions correctly).
> The real cause of the problems I've been having is documented in JIRA under SLING-2863 and SLING-2864.
> I also provided a patch to fix it in SLING-2864
>
> Thanks,
> Ondrej
>
> On 8 May 2013, at 21:42, Dan Klco <da...@sixdimensions.com> wrote:
>
>> Ondrej,
>>
>> This sounds interesting, though it seems like Expression Language support was added in JSTL 1.1, so it should be supported currently. Could you please create an issue and attach a patch file for the proposed change?
>>
>> It looks like the dependency being referenced is GlassFish's JSTL implementation, are there any concerns about including it as it is licensed under the CDDL (https://jstl.java.net/)?
>>
>> From what I have read, it seems like binaries licensed under the CDDL can be included in Apache projects, however since we re-wrap the Jar in a bundle I don't know if it might be problematic. Additionally, I think we will need to include a notice that a CDDL license work has been included in Sling:
>> http://www.apache.org/legal/3party.html#category-b
>>
>> -Dan
>>
>> -----Original Message-----
>> From: Ondrej Florian [mailto:onflapp@gmail.com]
>> Sent: Wednesday, May 08, 2013 1:26 PM
>> To: dev@sling.apache.org
>> Subject: support for JSTL 1.2
>>
>> Hi,
>>
>> I'd like to contribute pom.xml for JSTL 1.2.1.
>> As far as I can see, the Sling supports 1.1.2 at the moment which doesn't seem to work with the JSP EL.
>>
>>
>> -----
>> No virus found in this message.
>> Checked by AVG - www.avg.com
>> Version: 2013.0.3272 / Virus Database: 3162/6287 - Release Date: 04/30/13 Internal Virus Database is out of date.
>>
>
>
>
> -----
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 2013.0.3272 / Virus Database: 3162/6287 - Release Date: 04/30/13 Internal Virus Database is out of date.
>
-----
No virus found in this message.
Checked by AVG - www.avg.com
Version: 2013.0.3272 / Virus Database: 3162/6287 - Release Date: 04/30/13 Internal Virus Database is out of date.
Re: support for JSTL 1.2
Posted by Ondrej Florian <on...@gmail.com>.
Many Thanks Dan,
just a little comment;
shouldn't we make the naming of functions / tags more consistent?
e.g. there is a function listChildResources but the tag is called listChildren
I know this is small thing, but I would try to make the naming to fit the one used by the Resource API whenever possible.
What do you think?
BTW: I can go through the code and make appropriate changes - if you agree
Ondrej
On 9 May 2013, at 17:11, Dan Klco <da...@sixdimensions.com> wrote:
> Ondrej,
>
> Thank you for all of the investigation and patch. I have tested and committed the patch you provided, it looks good.
>
> Please let me know if you find anything else. This new Resource Access Tag API is still pretty new.
>
> Thanks again!
>
> -Dan
>
> -----Original Message-----
> From: Ondrej Florian [mailto:onflapp@gmail.com]
> Sent: Thursday, May 09, 2013 9:17 AM
> To: dev@sling.apache.org
> Subject: Re: support for JSTL 1.2
>
> Hi Dan,
>
> I backtracked and re-tested everything again, and yes you are right, the JSTL 1.1 should be sufficient (it works with the EL and the functions correctly).
> The real cause of the problems I've been having is documented in JIRA under SLING-2863 and SLING-2864.
> I also provided a patch to fix it in SLING-2864
>
> Thanks,
> Ondrej
>
> On 8 May 2013, at 21:42, Dan Klco <da...@sixdimensions.com> wrote:
>
>> Ondrej,
>>
>> This sounds interesting, though it seems like Expression Language support was added in JSTL 1.1, so it should be supported currently. Could you please create an issue and attach a patch file for the proposed change?
>>
>> It looks like the dependency being referenced is GlassFish's JSTL implementation, are there any concerns about including it as it is licensed under the CDDL (https://jstl.java.net/)?
>>
>> From what I have read, it seems like binaries licensed under the CDDL can be included in Apache projects, however since we re-wrap the Jar in a bundle I don't know if it might be problematic. Additionally, I think we will need to include a notice that a CDDL license work has been included in Sling:
>> http://www.apache.org/legal/3party.html#category-b
>>
>> -Dan
>>
>> -----Original Message-----
>> From: Ondrej Florian [mailto:onflapp@gmail.com]
>> Sent: Wednesday, May 08, 2013 1:26 PM
>> To: dev@sling.apache.org
>> Subject: support for JSTL 1.2
>>
>> Hi,
>>
>> I'd like to contribute pom.xml for JSTL 1.2.1.
>> As far as I can see, the Sling supports 1.1.2 at the moment which doesn't seem to work with the JSP EL.
>>
>>
>> -----
>> No virus found in this message.
>> Checked by AVG - www.avg.com
>> Version: 2013.0.3272 / Virus Database: 3162/6287 - Release Date: 04/30/13 Internal Virus Database is out of date.
>>
>
>
>
> -----
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 2013.0.3272 / Virus Database: 3162/6287 - Release Date: 04/30/13 Internal Virus Database is out of date.
>
Re: getting JSTL to work
Posted by Ondrej Florian <on...@gmail.com>.
Hi Dan,
I found another issue which prevents JSTL to work correctly.
in launchpad/builder/src/main/bundles/list.xml
- org.apache.sling.scripting.jsp.jstl was missing
- org.apache.sling.scripting.jsp.taglib has wrong version
I added required patch to SLING-2863
=> https://issues.apache.org/jira/secure/attachment/12584550/list.xml.patch
Ondrej
On 9 May 2013, at 17:11, Dan Klco <da...@sixdimensions.com> wrote:
> Ondrej,
>
> Thank you for all of the investigation and patch. I have tested and committed the patch you provided, it looks good.
>
> Please let me know if you find anything else. This new Resource Access Tag API is still pretty new.
>
> Thanks again!
>
> -Dan
>
> -----Original Message-----
> From: Ondrej Florian [mailto:onflapp@gmail.com]
> Sent: Thursday, May 09, 2013 9:17 AM
> To: dev@sling.apache.org
> Subject: Re: support for JSTL 1.2
>
> Hi Dan,
>
> I backtracked and re-tested everything again, and yes you are right, the JSTL 1.1 should be sufficient (it works with the EL and the functions correctly).
> The real cause of the problems I've been having is documented in JIRA under SLING-2863 and SLING-2864.
> I also provided a patch to fix it in SLING-2864
>
> Thanks,
> Ondrej
>
> On 8 May 2013, at 21:42, Dan Klco <da...@sixdimensions.com> wrote:
>
>> Ondrej,
>>
>> This sounds interesting, though it seems like Expression Language support was added in JSTL 1.1, so it should be supported currently. Could you please create an issue and attach a patch file for the proposed change?
>>
>> It looks like the dependency being referenced is GlassFish's JSTL implementation, are there any concerns about including it as it is licensed under the CDDL (https://jstl.java.net/)?
>>
>> From what I have read, it seems like binaries licensed under the CDDL can be included in Apache projects, however since we re-wrap the Jar in a bundle I don't know if it might be problematic. Additionally, I think we will need to include a notice that a CDDL license work has been included in Sling:
>> http://www.apache.org/legal/3party.html#category-b
>>
>> -Dan
>>
>> -----Original Message-----
>> From: Ondrej Florian [mailto:onflapp@gmail.com]
>> Sent: Wednesday, May 08, 2013 1:26 PM
>> To: dev@sling.apache.org
>> Subject: support for JSTL 1.2
>>
>> Hi,
>>
>> I'd like to contribute pom.xml for JSTL 1.2.1.
>> As far as I can see, the Sling supports 1.1.2 at the moment which doesn't seem to work with the JSP EL.
>>
>>
>> -----
>> No virus found in this message.
>> Checked by AVG - www.avg.com
>> Version: 2013.0.3272 / Virus Database: 3162/6287 - Release Date: 04/30/13 Internal Virus Database is out of date.
>>
>
>
>
> -----
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 2013.0.3272 / Virus Database: 3162/6287 - Release Date: 04/30/13 Internal Virus Database is out of date.
>
RE: support for JSTL 1.2
Posted by Dan Klco <da...@sixdimensions.com>.
Ondrej,
Thank you for all of the investigation and patch. I have tested and committed the patch you provided, it looks good.
Please let me know if you find anything else. This new Resource Access Tag API is still pretty new.
Thanks again!
-Dan
-----Original Message-----
From: Ondrej Florian [mailto:onflapp@gmail.com]
Sent: Thursday, May 09, 2013 9:17 AM
To: dev@sling.apache.org
Subject: Re: support for JSTL 1.2
Hi Dan,
I backtracked and re-tested everything again, and yes you are right, the JSTL 1.1 should be sufficient (it works with the EL and the functions correctly).
The real cause of the problems I've been having is documented in JIRA under SLING-2863 and SLING-2864.
I also provided a patch to fix it in SLING-2864
Thanks,
Ondrej
On 8 May 2013, at 21:42, Dan Klco <da...@sixdimensions.com> wrote:
> Ondrej,
>
> This sounds interesting, though it seems like Expression Language support was added in JSTL 1.1, so it should be supported currently. Could you please create an issue and attach a patch file for the proposed change?
>
> It looks like the dependency being referenced is GlassFish's JSTL implementation, are there any concerns about including it as it is licensed under the CDDL (https://jstl.java.net/)?
>
> From what I have read, it seems like binaries licensed under the CDDL can be included in Apache projects, however since we re-wrap the Jar in a bundle I don't know if it might be problematic. Additionally, I think we will need to include a notice that a CDDL license work has been included in Sling:
> http://www.apache.org/legal/3party.html#category-b
>
> -Dan
>
> -----Original Message-----
> From: Ondrej Florian [mailto:onflapp@gmail.com]
> Sent: Wednesday, May 08, 2013 1:26 PM
> To: dev@sling.apache.org
> Subject: support for JSTL 1.2
>
> Hi,
>
> I'd like to contribute pom.xml for JSTL 1.2.1.
> As far as I can see, the Sling supports 1.1.2 at the moment which doesn't seem to work with the JSP EL.
>
>
> -----
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 2013.0.3272 / Virus Database: 3162/6287 - Release Date: 04/30/13 Internal Virus Database is out of date.
>
-----
No virus found in this message.
Checked by AVG - www.avg.com
Version: 2013.0.3272 / Virus Database: 3162/6287 - Release Date: 04/30/13 Internal Virus Database is out of date.
Re: support for JSTL 1.2
Posted by Ondrej Florian <on...@gmail.com>.
Hi Dan,
I backtracked and re-tested everything again, and yes you are right, the JSTL 1.1 should be sufficient (it works with the EL and the functions correctly).
The real cause of the problems I've been having is documented in JIRA under SLING-2863 and SLING-2864.
I also provided a patch to fix it in SLING-2864
Thanks,
Ondrej
On 8 May 2013, at 21:42, Dan Klco <da...@sixdimensions.com> wrote:
> Ondrej,
>
> This sounds interesting, though it seems like Expression Language support was added in JSTL 1.1, so it should be supported currently. Could you please create an issue and attach a patch file for the proposed change?
>
> It looks like the dependency being referenced is GlassFish's JSTL implementation, are there any concerns about including it as it is licensed under the CDDL (https://jstl.java.net/)?
>
> From what I have read, it seems like binaries licensed under the CDDL can be included in Apache projects, however since we re-wrap the Jar in a bundle I don't know if it might be problematic. Additionally, I think we will need to include a notice that a CDDL license work has been included in Sling:
> http://www.apache.org/legal/3party.html#category-b
>
> -Dan
>
> -----Original Message-----
> From: Ondrej Florian [mailto:onflapp@gmail.com]
> Sent: Wednesday, May 08, 2013 1:26 PM
> To: dev@sling.apache.org
> Subject: support for JSTL 1.2
>
> Hi,
>
> I'd like to contribute pom.xml for JSTL 1.2.1.
> As far as I can see, the Sling supports 1.1.2 at the moment which doesn't seem to work with the JSP EL.
>
>
> -----
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 2013.0.3272 / Virus Database: 3162/6287 - Release Date: 04/30/13 Internal Virus Database is out of date.
>
Re: support for JSTL 1.2
Posted by Ondrej Florian <on...@gmail.com>.
Hi Dan,
I added 1.2 because I just could't get JSTL 1.1 working with EL in Sling.
e.g. <c:forEach items="${list}" var="it"> would not work.
...maybe I am doing something wrong?
On 8 May 2013, at 21:42, Dan Klco <da...@sixdimensions.com> wrote:
> Ondrej,
>
> This sounds interesting, though it seems like Expression Language support was added in JSTL 1.1, so it should be supported currently. Could you please create an issue and attach a patch file for the proposed change?
>
> It looks like the dependency being referenced is GlassFish's JSTL implementation, are there any concerns about including it as it is licensed under the CDDL (https://jstl.java.net/)?
>
> From what I have read, it seems like binaries licensed under the CDDL can be included in Apache projects, however since we re-wrap the Jar in a bundle I don't know if it might be problematic. Additionally, I think we will need to include a notice that a CDDL license work has been included in Sling:
> http://www.apache.org/legal/3party.html#category-b
>
> -Dan
>
> -----Original Message-----
> From: Ondrej Florian [mailto:onflapp@gmail.com]
> Sent: Wednesday, May 08, 2013 1:26 PM
> To: dev@sling.apache.org
> Subject: support for JSTL 1.2
>
> Hi,
>
> I'd like to contribute pom.xml for JSTL 1.2.1.
> As far as I can see, the Sling supports 1.1.2 at the moment which doesn't seem to work with the JSP EL.
>
>
> -----
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 2013.0.3272 / Virus Database: 3162/6287 - Release Date: 04/30/13 Internal Virus Database is out of date.
>
RE: support for JSTL 1.2
Posted by Dan Klco <da...@sixdimensions.com>.
Ondrej,
This sounds interesting, though it seems like Expression Language support was added in JSTL 1.1, so it should be supported currently. Could you please create an issue and attach a patch file for the proposed change?
It looks like the dependency being referenced is GlassFish's JSTL implementation, are there any concerns about including it as it is licensed under the CDDL (https://jstl.java.net/)?
>From what I have read, it seems like binaries licensed under the CDDL can be included in Apache projects, however since we re-wrap the Jar in a bundle I don't know if it might be problematic. Additionally, I think we will need to include a notice that a CDDL license work has been included in Sling:
http://www.apache.org/legal/3party.html#category-b
-Dan
-----Original Message-----
From: Ondrej Florian [mailto:onflapp@gmail.com]
Sent: Wednesday, May 08, 2013 1:26 PM
To: dev@sling.apache.org
Subject: support for JSTL 1.2
Hi,
I'd like to contribute pom.xml for JSTL 1.2.1.
As far as I can see, the Sling supports 1.1.2 at the moment which doesn't seem to work with the JSP EL.
-----
No virus found in this message.
Checked by AVG - www.avg.com
Version: 2013.0.3272 / Virus Database: 3162/6287 - Release Date: 04/30/13 Internal Virus Database is out of date.