You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by an...@apache.org on 2014/09/08 17:13:47 UTC

svn commit: r1623421 - /tomee/tomee/branches/tomee-1.7.x/examples/projectstage-demo/src/test/java/org/superbiz/projectstage/BaseTestForProjectStage.java

Author: andygumbrecht
Date: Mon Sep  8 15:13:46 2014
New Revision: 1623421

URL: http://svn.apache.org/r1623421
Log:
Why was this allowed before?

Modified:
    tomee/tomee/branches/tomee-1.7.x/examples/projectstage-demo/src/test/java/org/superbiz/projectstage/BaseTestForProjectStage.java

Modified: tomee/tomee/branches/tomee-1.7.x/examples/projectstage-demo/src/test/java/org/superbiz/projectstage/BaseTestForProjectStage.java
URL: http://svn.apache.org/viewvc/tomee/tomee/branches/tomee-1.7.x/examples/projectstage-demo/src/test/java/org/superbiz/projectstage/BaseTestForProjectStage.java?rev=1623421&r1=1623420&r2=1623421&view=diff
==============================================================================
--- tomee/tomee/branches/tomee-1.7.x/examples/projectstage-demo/src/test/java/org/superbiz/projectstage/BaseTestForProjectStage.java (original)
+++ tomee/tomee/branches/tomee-1.7.x/examples/projectstage-demo/src/test/java/org/superbiz/projectstage/BaseTestForProjectStage.java Mon Sep  8 15:13:46 2014
@@ -36,7 +36,7 @@ import javax.inject.Inject;
 import static org.junit.Assert.assertEquals;
 
 @RunWith(Arquillian.class)
-public abstract class BaseTestForProjectStage {
+public class BaseTestForProjectStage {
 
     @Inject
     protected Manager manager;

Re: Fwd: svn commit: r1623421 - /tomee/tomee/branches/tomee-1.7.x/examples/projectstage-demo/src/test/java/org/superbiz/projectstage/BaseTestForProjectStage.java

Posted by Romain Manni-Bucau <rm...@gmail.com>.
I guess http://svn.apache.org/repos/asf/tomee/tomee/trunk/examples/projectstage-demo/src/test/java/org/superbiz/projectstage/DevProjectStageTest.java


Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau


2014-09-08 17:34 GMT+02:00 Andy Gumbrecht <ag...@tomitribe.com>:
> So the test was OK being abstract - Which means there is an issue with the
> backport?
>
> Andy.
>
>
> On 08/09/2014 17:17, Romain Manni-Bucau wrote:
>>
>> because it was not a test so shouldn't be instantiated
>>
>>
>
>
> --
>   Andy Gumbrecht
>   https://twitter.com/AndyGeeDe
>   http://www.tomitribe.com
>

Re: Fwd: svn commit: r1623421 - /tomee/tomee/branches/tomee-1.7.x/examples/projectstage-demo/src/test/java/org/superbiz/projectstage/BaseTestForProjectStage.java

Posted by Andy Gumbrecht <ag...@tomitribe.com>.
So the test was OK being abstract - Which means there is an issue with 
the backport?

Andy.

On 08/09/2014 17:17, Romain Manni-Bucau wrote:
> because it was not a test so shouldn't be instantiated
>
>


-- 
   Andy Gumbrecht
   https://twitter.com/AndyGeeDe
   http://www.tomitribe.com

Fwd: svn commit: r1623421 - /tomee/tomee/branches/tomee-1.7.x/examples/projectstage-demo/src/test/java/org/superbiz/projectstage/BaseTestForProjectStage.java

Posted by Romain Manni-Bucau <rm...@gmail.com>.
because it was not a test so shouldn't be instantiated


Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau



---------- Forwarded message ----------
From:  <an...@apache.org>
Date: 2014-09-08 17:13 GMT+02:00
Subject: svn commit: r1623421 -
/tomee/tomee/branches/tomee-1.7.x/examples/projectstage-demo/src/test/java/org/superbiz/projectstage/BaseTestForProjectStage.java
To: commits@tomee.apache.org


Author: andygumbrecht
Date: Mon Sep  8 15:13:46 2014
New Revision: 1623421

URL: http://svn.apache.org/r1623421
Log:
Why was this allowed before?

Modified:
    tomee/tomee/branches/tomee-1.7.x/examples/projectstage-demo/src/test/java/org/superbiz/projectstage/BaseTestForProjectStage.java

Modified: tomee/tomee/branches/tomee-1.7.x/examples/projectstage-demo/src/test/java/org/superbiz/projectstage/BaseTestForProjectStage.java
URL: http://svn.apache.org/viewvc/tomee/tomee/branches/tomee-1.7.x/examples/projectstage-demo/src/test/java/org/superbiz/projectstage/BaseTestForProjectStage.java?rev=1623421&r1=1623420&r2=1623421&view=diff
==============================================================================
--- tomee/tomee/branches/tomee-1.7.x/examples/projectstage-demo/src/test/java/org/superbiz/projectstage/BaseTestForProjectStage.java
(original)
+++ tomee/tomee/branches/tomee-1.7.x/examples/projectstage-demo/src/test/java/org/superbiz/projectstage/BaseTestForProjectStage.java
Mon Sep  8 15:13:46 2014
@@ -36,7 +36,7 @@ import javax.inject.Inject;
 import static org.junit.Assert.assertEquals;

 @RunWith(Arquillian.class)
-public abstract class BaseTestForProjectStage {
+public class BaseTestForProjectStage {

     @Inject
     protected Manager manager;