You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/08 11:43:29 UTC

[GitHub] [flink] liyubin117 opened a new pull request, #21260: [FLINK-29929][table] Correct conversions from ResolvedSchema to TableSchema

liyubin117 opened a new pull request, #21260:
URL: https://github.com/apache/flink/pull/21260

   ## What is the purpose of the change
   
   Previously, conversions from ResolvedSchema to TableSchema generate wrong Timestamp DataType.
   
   ## Brief change log
   
   * remove time attribute addition.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   CatalogBaseTableResolutionTest#testWatermarkOnTimestampEqualityWithConverted
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] liyubin117 closed pull request #21260: [FLINK-29929][table] Correct conversions from ResolvedSchema to TableSchema

Posted by GitBox <gi...@apache.org>.
liyubin117 closed pull request #21260: [FLINK-29929][table] Correct conversions from ResolvedSchema to TableSchema
URL: https://github.com/apache/flink/pull/21260


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21260: [FLINK-29929][table] Correct conversions from ResolvedSchema to TableSchema

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21260:
URL: https://github.com/apache/flink/pull/21260#issuecomment-1307086106

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "94083a66280f0b07e48271c738c151f626d72d42",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "94083a66280f0b07e48271c738c151f626d72d42",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 94083a66280f0b07e48271c738c151f626d72d42 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org