You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by dangogh <gi...@git.apache.org> on 2017/01/04 21:40:40 UTC
[GitHub] incubator-trafficcontrol pull request #157: [TC-84] compiles goose from sour...
GitHub user dangogh opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/157
[TC-84] compiles goose from source; installs cpan modules during rpm install
This is needed for 1.8 -- apache compliance does not allow release of goose binary
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dangogh/incubator-trafficcontrol vendor-goose
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/157.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #157
----
commit 4bbcffd91b045f5f8da3f0ab8a56f712ad402d12
Author: Dan Kirkwood <da...@gmail.com>
Date: 2017-01-04T20:02:13Z
add goose source to build during install
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #157: [TC-84] compiles goose from source; ins...
Posted by knutsel <gi...@git.apache.org>.
Github user knutsel commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/157
Do we have to add all these to our repo? Can't we just say you have to "go get" them before you do the build? And do the same in the installer?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #157: [TC-84] compiles goose from sour...
Posted by dangogh <gi...@git.apache.org>.
Github user dangogh closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/157
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #157: [TC-84] compiles goose from source; ins...
Posted by mtorluemke <gi...@git.apache.org>.
Github user mtorluemke commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/157
Yeah, 715 files and almost 390k lines seems excessive. On the other hand, "go get" requires more babysitting over time. Feels like we should choose either of the two evils in the short-term, and add a longer-term item to revisit our schema migration strategy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #157: [TC-84] compiles goose from source; ins...
Posted by dangogh <gi...@git.apache.org>.
Github user dangogh commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/157
yep -- catch-22.. I'll get build instructions set up that details this instead..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---